| Message ID | 1614154581-33967-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
| Series | x86: platform: iosf_mbi: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE | expand |
On Wed, Feb 24, 2021 at 10:16 AM Yang Li <yang.lee@linux.alibaba.com> wrote: > > Fix the following coccicheck warning: > ./arch/x86/platform/intel/iosf_mbi.c:482:0-23: WARNING: iosf_mcr_fops > should be defined with DEFINE_DEBUGFS_ATTRIBUTE Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > arch/x86/platform/intel/iosf_mbi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/platform/intel/iosf_mbi.c b/arch/x86/platform/intel/iosf_mbi.c > index 526f70f..ba70597 100644 > --- a/arch/x86/platform/intel/iosf_mbi.c > +++ b/arch/x86/platform/intel/iosf_mbi.c > @@ -479,7 +479,7 @@ static int mcr_set(void *data, u64 val) > > return err; > } > -DEFINE_SIMPLE_ATTRIBUTE(iosf_mcr_fops, mcr_get, mcr_set , "%llx\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(iosf_mcr_fops, mcr_get, mcr_set, "%llx\n"); > > static struct dentry *iosf_dbg; > > -- > 1.8.3.1 >
diff --git a/arch/x86/platform/intel/iosf_mbi.c b/arch/x86/platform/intel/iosf_mbi.c index 526f70f..ba70597 100644 --- a/arch/x86/platform/intel/iosf_mbi.c +++ b/arch/x86/platform/intel/iosf_mbi.c @@ -479,7 +479,7 @@ static int mcr_set(void *data, u64 val) return err; } -DEFINE_SIMPLE_ATTRIBUTE(iosf_mcr_fops, mcr_get, mcr_set , "%llx\n"); +DEFINE_DEBUGFS_ATTRIBUTE(iosf_mcr_fops, mcr_get, mcr_set, "%llx\n"); static struct dentry *iosf_dbg;
Fix the following coccicheck warning: ./arch/x86/platform/intel/iosf_mbi.c:482:0-23: WARNING: iosf_mcr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- arch/x86/platform/intel/iosf_mbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)