| Message ID | 1623811809-65099-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [-next] platform/x86: think-lmi: Add missing MODULE_DEVICE_TABLE | expand |
On 6/16/21 4:50 AM, Zou Wei wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/platform/x86/think-lmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c > index 7771c93..6e1fbc4 100644 > --- a/drivers/platform/x86/think-lmi.c > +++ b/drivers/platform/x86/think-lmi.c > @@ -873,6 +873,7 @@ static const struct wmi_device_id tlmi_id_table[] = { > { .guid_string = LENOVO_BIOS_SETTING_GUID }, > { } > }; > +MODULE_DEVICE_TABLE(vmi, tlmi_id_table); I assume this should be "wmi", i.e. MODULE_DEVICE_TABLE(wmi, tlmi_id_table); instead of "vmi"? Regards, Max > > static struct wmi_driver tlmi_driver = { > .driver = { >
Hi, On 6/16/21 4:50 AM, Zou Wei wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I've fixed up the vmi typo notices by Maximillian while applying the patch. Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/think-lmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c > index 7771c93..6e1fbc4 100644 > --- a/drivers/platform/x86/think-lmi.c > +++ b/drivers/platform/x86/think-lmi.c > @@ -873,6 +873,7 @@ static const struct wmi_device_id tlmi_id_table[] = { > { .guid_string = LENOVO_BIOS_SETTING_GUID }, > { } > }; > +MODULE_DEVICE_TABLE(vmi, tlmi_id_table); > > static struct wmi_driver tlmi_driver = { > .driver = { >
diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c index 7771c93..6e1fbc4 100644 --- a/drivers/platform/x86/think-lmi.c +++ b/drivers/platform/x86/think-lmi.c @@ -873,6 +873,7 @@ static const struct wmi_device_id tlmi_id_table[] = { { .guid_string = LENOVO_BIOS_SETTING_GUID }, { } }; +MODULE_DEVICE_TABLE(vmi, tlmi_id_table); static struct wmi_driver tlmi_driver = { .driver = {
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/platform/x86/think-lmi.c | 1 + 1 file changed, 1 insertion(+)