| Message ID | 20160126092425.GA15717@mwanda (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Tue, Jan 26, 2016 at 12:24:25PM +0300, Dan Carpenter wrote: > "count" is controlled by the user and it can be negative. Let's prevent > that by making it unsigned. You have to have CAP_SYS_RAWIO to call this > function so the bug is not as serious as it could be. > > Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Queued to fixes for 4.5-rc1 as well as stable. Thanks Dan,
diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c index 02bc5a6..aa45424 100644 --- a/drivers/platform/x86/intel_scu_ipcutil.c +++ b/drivers/platform/x86/intel_scu_ipcutil.c @@ -49,7 +49,7 @@ struct scu_ipc_data { static int scu_reg_access(u32 cmd, struct scu_ipc_data *data) { - int count = data->count; + unsigned int count = data->count; if (count == 0 || count == 3 || count > 4) return -EINVAL;
"count" is controlled by the user and it can be negative. Let's prevent that by making it unsigned. You have to have CAP_SYS_RAWIO to call this function so the bug is not as serious as it could be. Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html