From patchwork Mon Jul 4 11:35:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajneesh Bhardwaj X-Patchwork-Id: 9212277 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 465CF60752 for ; Mon, 4 Jul 2016 11:35:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34A3D2863F for ; Mon, 4 Jul 2016 11:35:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 272BB286C3; Mon, 4 Jul 2016 11:35:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D1E92863F for ; Mon, 4 Jul 2016 11:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753560AbcGDLfZ (ORCPT ); Mon, 4 Jul 2016 07:35:25 -0400 Received: from mga01.intel.com ([192.55.52.88]:2206 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753558AbcGDLfW (ORCPT ); Mon, 4 Jul 2016 07:35:22 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 04 Jul 2016 04:35:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,574,1459839600"; d="scan'208";a="729410067" Received: from rajaneesh-optiplex-9010.iind.intel.com (HELO rajaneesh-OptiPlex-9010) ([10.223.135.11]) by FMSMGA003.fm.intel.com with ESMTP; 04 Jul 2016 04:35:20 -0700 Date: Mon, 4 Jul 2016 17:05:18 +0530 From: Rajneesh Bhardwaj To: Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, Darren Hart , Vishwanath Somayaji Subject: Re: [PATCH v1 1/1] platform/x86/intel_pmc_core: Convert to DEFINE_DEBUGFS_ATTRIBUTE Message-ID: <20160704113518.GC1177@rajaneesh-OptiPlex-9010> References: <1465840609-136143-1-git-send-email-andriy.shevchenko@linux.intel.com> <20160628090504.GA2169@rajaneesh-OptiPlex-9010> <1467108307.30123.303.camel@linux.intel.com> <20160629080325.GA11318@rajaneesh-OptiPlex-9010> <1467200985.30123.320.camel@linux.intel.com> <20160629121604.GA26750@rajaneesh-OptiPlex-9010> <1467204505.30123.326.camel@linux.intel.com> <20160629132038.GB26750@rajaneesh-OptiPlex-9010> <1467207230.30123.329.camel@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1467207230.30123.329.camel@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > > So, if there is no objections (taking into consideration minors you > mentioned) I think the patch can be applied. > I think we still need to address a couple of minor issues and might need a version 2 of this patch. In case we want to apply this one here is one patch that can applied on top of this one. Please see the proposed changes below. From 42d899968c8c07f103390fcaebdaf2ba54cb3363 Mon Sep 17 00:00:00 2001 From: Rajneesh Bhardwaj Date: Mon, 4 Jul 2016 16:22:31 +0530 Subject: [PATCH] platform/x86/intel_pmc_core: Enhances debugfs attribute patch Refines "convert to DEFINE_DEBUGFS_ATTRIBUTE" patch for PMC Core. This change can be applied over the Convert to DEFINE_DEBUGFS_ATTRIBUTE patch sent by Andy Shevchenko to the platform drivers mailing list. This helps preserve usage of seq_file.h in the pmc_core driver. This also caters to some minor cosmetic changes suggested during the code review process. Signed-off-by: Rajneesh Bhardwaj --- drivers/platform/x86/intel_pmc_core.c | 4 +++- drivers/platform/x86/intel_pmc_core.h | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) -- 1.9.1 > -- > > Andy Shevchenko > Intel Finland Oy diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index c29f59b..18af49f 100644 --- a/drivers/platform/x86/intel_pmc_core.c +++ b/drivers/platform/x86/intel_pmc_core.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include @@ -88,7 +89,8 @@ static int pmc_core_dev_state_get(void *data, u64 *val) return 0; } -DEFINE_DEBUGFS_ATTRIBUTE(pmc_core_dev_state, pmc_core_dev_state_get, NULL, "%llu"); +DEFINE_DEBUGFS_ATTRIBUTE(pmc_core_dev_state, pmc_core_dev_state_get, NULL, + "%llu\n"); static void pmc_core_dbgfs_unregister(struct pmc_dev *pmcdev) { diff --git a/drivers/platform/x86/intel_pmc_core.h b/drivers/platform/x86/intel_pmc_core.h index 9689b92..6265480 100644 --- a/drivers/platform/x86/intel_pmc_core.h +++ b/drivers/platform/x86/intel_pmc_core.h @@ -29,7 +29,6 @@ #define SPT_PMC_MMIO_REG_LEN 0x100 #define SPT_PMC_SLP_S0_RES_COUNTER_STEP 0x64 -struct dentry; /** * struct pmc_dev - pmc device structure