diff mbox

ideapad-laptop: Add another DMI entry for Yoga 900

Message ID 20161019102740.74567-1-mika.westerberg@linux.intel.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Mika Westerberg Oct. 19, 2016, 10:27 a.m. UTC
This particular laptop has its motherboard replaced and after that, even
with the latest BIOS, some DMI identification strings have become
"INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
blocked.

It seems that DMI_BOARD_NAME is still valid so use that as an
alternative for Lenovo Yoga 900.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Andy Shevchenko Oct. 19, 2016, 4:36 p.m. UTC | #1
On Wed, Oct 19, 2016 at 1:27 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> This particular laptop has its motherboard replaced and after that, even
> with the latest BIOS, some DMI identification strings have become
> "INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
> blocked.
>
> It seems that DMI_BOARD_NAME is still valid so use that as an
> alternative for Lenovo Yoga 900.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Reviewed-by: Andy Shevchenko <andy.shevchenko@linux.intel.com>

> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -933,6 +933,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>                         DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 900"),
>                 },
>         },
> +       {
> +               .ident = "Lenovo Yoga 900",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +                       DMI_MATCH(DMI_BOARD_NAME, "VIUU4"),
> +               },
> +       },
>         {}
>  };
Darren Hart Oct. 19, 2016, 8:10 p.m. UTC | #2
On Wed, Oct 19, 2016 at 01:27:40PM +0300, Mika Westerberg wrote:
> This particular laptop has its motherboard replaced and after that, even
> with the latest BIOS, some DMI identification strings have become
> "INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
> blocked.
> 
> It seems that DMI_BOARD_NAME is still valid so use that as an
> alternative for Lenovo Yoga 900.

Well, that stinks. We have a similar split for the Yoga 2 11/13/Pro.

Applied.
Ike Panhc Oct. 20, 2016, 12:56 a.m. UTC | #3
On 10/20/2016 04:10 AM, Darren Hart wrote:
> On Wed, Oct 19, 2016 at 01:27:40PM +0300, Mika Westerberg wrote:
>> This particular laptop has its motherboard replaced and after that, even
>> with the latest BIOS, some DMI identification strings have become
>> "INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
>> blocked.
>>
>> It seems that DMI_BOARD_NAME is still valid so use that as an
>> alternative for Lenovo Yoga 900.
> 
> Well, that stinks. We have a similar split for the Yoga 2 11/13/Pro.
> 
> Applied.
> 

Hi Mika,

Could you post output of acpidump and `cat /sys/class/dmi/id/modalias` for record please?

Thanks a lot.

--
Ike Panhc
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mika Westerberg Oct. 20, 2016, 7:37 a.m. UTC | #4
On Thu, Oct 20, 2016 at 08:56:30AM +0800, Ike Panhc wrote:
> On 10/20/2016 04:10 AM, Darren Hart wrote:
> > On Wed, Oct 19, 2016 at 01:27:40PM +0300, Mika Westerberg wrote:
> >> This particular laptop has its motherboard replaced and after that, even
> >> with the latest BIOS, some DMI identification strings have become
> >> "INVALID". This includes DMI_PRODUCT_VERSION which results Wifi being
> >> blocked.
> >>
> >> It seems that DMI_BOARD_NAME is still valid so use that as an
> >> alternative for Lenovo Yoga 900.
> > 
> > Well, that stinks. We have a similar split for the Yoga 2 11/13/Pro.
> > 
> > Applied.
> > 
> 
> Hi Mika,
> 
> Could you post output of acpidump and `cat /sys/class/dmi/id/modalias` for record please?
> 

Here it is:

dmi:bvnLENOVO:bvrC6CN37WW:bd03/01/2016:svnLENOVO:pnINVALID:pvrINVALID:rvnLENOVO:rnVIUU4:rvrSDK0K17763WIN:cvnLENOVO:ct10:cvrINVALID:
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index d1a091b..d99b45e 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -933,6 +933,13 @@  static const struct dmi_system_id no_hw_rfkill_list[] = {
 			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 900"),
 		},
 	},
+	{
+		.ident = "Lenovo Yoga 900",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_BOARD_NAME, "VIUU4"),
+		},
+	},
 	{}
 };