diff mbox

thinkpad_acpi: Fix old style declaration GCC warning

Message ID 20161125131807.3885-1-tklauser@distanz.ch (mailing list archive)
State Accepted, archived
Delegated to: Darren Hart
Headers show

Commit Message

Tobias Klauser Nov. 25, 2016, 1:18 p.m. UTC 
Fix an [-Wold-style-declaration] GCC warning by moving the inline
keyword before the return type.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/platform/x86/thinkpad_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Henrique de Moraes Holschuh Nov. 25, 2016, 3:31 p.m. UTC | #1 
On Fri, 25 Nov 2016, Tobias Klauser wrote:
> Fix an [-Wold-style-declaration] GCC warning by moving the inline
> keyword before the return type.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

> ---
>  drivers/platform/x86/thinkpad_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index b65ce7519411..c24ce1adc577 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -7716,7 +7716,7 @@ static struct ibm_struct volume_driver_data = {
>  
>  #define alsa_card NULL
>  
> -static void inline volume_alsa_notify_change(void)
> +static inline void volume_alsa_notify_change(void)
>  {
>  }
>
Darren Hart Dec. 12, 2016, 6:46 p.m. UTC | #2 
On Fri, Nov 25, 2016 at 01:31:30PM -0200, Henrique de Moraes Holschuh wrote:
> On Fri, 25 Nov 2016, Tobias Klauser wrote:
> > Fix an [-Wold-style-declaration] GCC warning by moving the inline
> > keyword before the return type.
> > 
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> 
> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> 

Queued to testing, thank you.
diff mbox

Patch

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index b65ce7519411..c24ce1adc577 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -7716,7 +7716,7 @@  static struct ibm_struct volume_driver_data = {
 
 #define alsa_card NULL
 
-static void inline volume_alsa_notify_change(void)
+static inline void volume_alsa_notify_change(void)
 {
 }