| Message ID | 20161208123618.28603-5-kernel@kempniu.pl (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: > All calls to dell_app_wmi_led_set() have been replaced with direct > calls to dell_micmute_led_set(), so the former can be safely removed > along with its related enum. > > Signed-off-by: Michał Kępień <kernel@kempniu.pl> I would suggest to squash patches 2,3,4 into one. But I let decision to alsa & led maintainers. Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote: > On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: >> All calls to dell_app_wmi_led_set() have been replaced with direct >> calls to dell_micmute_led_set(), so the former can be safely removed >> along with its related enum. >> >> Signed-off-by: Michał Kępień <kernel@kempniu.pl> > > I would suggest to squash patches 2,3,4 into one. But I let decision to > alsa & led maintainers. I don't like the part where we are exporting something for just one moment. So, +1 to squashed version. > > Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup > > Reviewed-by: Pali Rohár <pali.rohar@gmail.com> > > -- > Pali Rohár > pali.rohar@gmail.com
On Wed, Dec 14, 2016 at 3:54 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote: >> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: >>> All calls to dell_app_wmi_led_set() have been replaced with direct >>> calls to dell_micmute_led_set(), so the former can be safely removed >>> along with its related enum. >>> >>> Signed-off-by: Michał Kępień <kernel@kempniu.pl> >> >> I would suggest to squash patches 2,3,4 into one. But I let decision to >> alsa & led maintainers. > > I don't like the part where we are exporting something for just one > moment. Oops, misread function name, though still valid vote for one patch. > So, +1 to squashed version. > >> >> Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup >> >> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> On Wed, Dec 14, 2016 at 3:54 AM, Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote: > >> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: > >>> All calls to dell_app_wmi_led_set() have been replaced with direct > >>> calls to dell_micmute_led_set(), so the former can be safely removed > >>> along with its related enum. > >>> > >>> Signed-off-by: Michał Kępień <kernel@kempniu.pl> > >> > >> I would suggest to squash patches 2,3,4 into one. But I let decision to > >> alsa & led maintainers. > > > > I don't like the part where we are exporting something for just one > > moment. > > Oops, misread function name, though still valid vote for one patch. Thanks, I will do that in v2 (and thanks to Pali for suggesting it).
diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c index b215248..f9002d9 100644 --- a/drivers/leds/dell-led.c +++ b/drivers/leds/dell-led.c @@ -71,23 +71,6 @@ int dell_micmute_led_set(int state) } EXPORT_SYMBOL_GPL(dell_micmute_led_set); -int dell_app_wmi_led_set(int whichled, int on) -{ - int state = 0; - - switch (whichled) { - case DELL_LED_MICMUTE: - state = dell_micmute_led_set(on); - break; - default: - pr_warn("led type %x is not supported\n", whichled); - break; - } - - return state; -} -EXPORT_SYMBOL_GPL(dell_app_wmi_led_set); - struct bios_args { unsigned char length; unsigned char result_code; diff --git a/include/linux/dell-led.h b/include/linux/dell-led.h index 1b03275..3f033c4 100644 --- a/include/linux/dell-led.h +++ b/include/linux/dell-led.h @@ -1,11 +1,6 @@ #ifndef __DELL_LED_H__ #define __DELL_LED_H__ -enum { - DELL_LED_MICMUTE, -}; - int dell_micmute_led_set(int on); -int dell_app_wmi_led_set(int whichled, int on); #endif
All calls to dell_app_wmi_led_set() have been replaced with direct calls to dell_micmute_led_set(), so the former can be safely removed along with its related enum. Signed-off-by: Michał Kępień <kernel@kempniu.pl> --- drivers/leds/dell-led.c | 17 ----------------- include/linux/dell-led.h | 5 ----- 2 files changed, 22 deletions(-)