From patchwork Fri Feb 17 07:57:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9579053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1D75060586 for ; Fri, 17 Feb 2017 07:59:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11872283B4 for ; Fri, 17 Feb 2017 07:59:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05128286AE; Fri, 17 Feb 2017 07:59:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A09F286AD for ; Fri, 17 Feb 2017 07:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755274AbdBQH6G (ORCPT ); Fri, 17 Feb 2017 02:58:06 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34083 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754216AbdBQH6E (ORCPT ); Fri, 17 Feb 2017 02:58:04 -0500 Received: by mail-lf0-f68.google.com with SMTP id q89so3183983lfi.1 for ; Thu, 16 Feb 2017 23:58:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GxTfth66a0trkxgaq+W4VyclQnoCQhchqNrGFI95cXo=; b=U75bouLL/HSQASrqjN9Xl+izZ6uPDNlR8YHOw0vYN91m/+UD4aQr9cwNAvjTlyY/lM QnnVcQfkQmQbPsnItmFYJXr7+OKrVk0lovkSXCSj109IDv0dSs6y2wa1smHjK7TihzyP JAe/ISAlEyLltMBljWkzeH2S+zXmpd+VJ3NJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GxTfth66a0trkxgaq+W4VyclQnoCQhchqNrGFI95cXo=; b=fRZfBmoXShUUZwfpfyPF3mxbBSK7zMbDSdqMZbd8BLB5Lzj/XZgb5+Bon7oZfloEJ8 mNhZvymN/pcDZBY4hJueMU6DNUEprq/sU1LLmHiiZprS43fxFukJ46/79pcUFyzxn6e6 tcBfBLRT0mqtlSbjCKmJzPS3SEbTw3KJD3Qjq5yqrJ0GL39YB2e443FoDQQ/l/XTiund XqiXhzx7GEW9GPeLZVj/bbPff2Xl3teff6+TQDHDb0oDFBhnX7ZzbALOgN6c0lZITYR1 JWaAnuPOHMbJORM1lj5x0s46gITjYHZzLtFg86Co3Sz01IDS+VmFVJ+Atgq/s2326ofq Mtww== X-Gm-Message-State: AMke39l4HSNiPu65itcMCdTiamj65x+up+16vGdmF4RR+RGJsN/uB3xRJxbWJ0+arwGk4g== X-Received: by 10.25.19.67 with SMTP id j64mr1898580lfi.34.1487318283103; Thu, 16 Feb 2017 23:58:03 -0800 (PST) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id 206sm2336457ljf.35.2017.02.16.23.58.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 23:58:02 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Richard Purdie , Jacek Anaszewski , Pavel Machek , Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Darren Hart , Andy Shevchenko , Jaroslav Kysela , Takashi Iwai Cc: Alex Hung , linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/7] dell-led: remove GUID check from dell_micmute_led_set() Date: Fri, 17 Feb 2017 08:57:47 +0100 Message-Id: <20170217075753.12702-2-kernel@kempniu.pl> X-Mailer: git-send-email 2.11.1 In-Reply-To: <20170217075753.12702-1-kernel@kempniu.pl> References: <20170217075753.12702-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As dell_micmute_led_set() no longer uses the dell_wmi_perform_query() method, which was removed in commit 0c41a08e131d ("dell-led: use dell_smbios_send_request() for performing SMBIOS calls"), the DELL_APP_GUID check is redundant and thus can be safely removed. Signed-off-by: Michał Kępień Tested-by: Alex Hung Reviewed-by: Pali Rohár --- drivers/leds/dell-led.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c index b3d6e9c15cf9..e8e8f67224c1 100644 --- a/drivers/leds/dell-led.c +++ b/drivers/leds/dell-led.c @@ -51,9 +51,6 @@ static int dell_micmute_led_set(int state) struct calling_interface_buffer *buffer; struct calling_interface_token *token; - if (!wmi_has_guid(DELL_APP_GUID)) - return -ENODEV; - if (state == 0) token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE); else if (state == 1)