From patchwork Fri Feb 24 10:33:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9589865 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01C1D6057F for ; Fri, 24 Feb 2017 10:34:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA50C287F7 for ; Fri, 24 Feb 2017 10:34:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DF5902891C; Fri, 24 Feb 2017 10:34:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99DA4288DC for ; Fri, 24 Feb 2017 10:34:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbdBXKeR (ORCPT ); Fri, 24 Feb 2017 05:34:17 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34713 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbdBXKdp (ORCPT ); Fri, 24 Feb 2017 05:33:45 -0500 Received: by mail-lf0-f67.google.com with SMTP id x142so292158lfd.1 for ; Fri, 24 Feb 2017 02:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X33h8KYDitMfZN1PIyavcVWn2EMs6n4CmtQ5H+AavgE=; b=UKEJwnFOPlsSQq9IwlNI3P5IVjeuQsnE7sqzV8HODZEd0DaEx4ErZ7kddMz85c9qr6 ygmHadgWBjOHeV2Fr1j0TvKHukBbIwYzwaw+iwlV+2QdWMoaDESTsHHVoX1biL6Zu2IG v9uCCsOb1aPd7UgD3yVnV0szYfUl2QPrt+s6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X33h8KYDitMfZN1PIyavcVWn2EMs6n4CmtQ5H+AavgE=; b=fMQOJfuz/OmJ7rVTzjhBwb5OtNwHfbGqwQU0GK0KMa9WHbDBYbV6X4kDFx5YR0P/pK 9ai9uhJvLgvXW9+Ot6OwP0xWJEJnnLwMXgyMA4++umnFEPBV0UuhsHVbDtrgoZrb612N du5cFBiovOOu28ESFbqCajWZc0ON32X2D4+wzwHbi+rnvh2CYonkFjtraaN8WTk3yY6X BliTJcdTfIT0LtY6dKrw3qfLm8mVpLlKi+wPH8i09/ePgsGC86Vyjd7R8+6hKzHZvxtK eH/k0bBvlsj2Aa+5btYabvvFFxJjl7/p8DRPwgcxbymHVK+zq/GOKlp+wuIzDT+a/YJi X1Ng== X-Gm-Message-State: AMke39l9pVjCH+TTfsT3lLxVo7vXZSLZm/LVqANiVq7DqhF5DviunO3nQqn+0BrZ2p7NmQ== X-Received: by 10.25.25.133 with SMTP id 127mr623703lfz.153.1487932395342; Fri, 24 Feb 2017 02:33:15 -0800 (PST) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id x26sm8678538lja.10.2017.02.24.02.33.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Feb 2017 02:33:14 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Alex Hung , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] platform/x86: intel-hid: simplify enabling/disabling HID events Date: Fri, 24 Feb 2017 11:33:06 +0100 Message-Id: <20170224103309.19463-2-kernel@kempniu.pl> X-Mailer: git-send-email 2.11.1 In-Reply-To: <20170224103309.19463-1-kernel@kempniu.pl> References: <20170224103309.19463-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ACPI method HDSM takes a single integer argument. Use acpi_execute_simple_method() instead of acpi_evaluate_object() for calling that ACPI method to simplify code and reduce the number of local variables inside intel_hid_set_enable(). Signed-off-by: Michał Kępień --- drivers/platform/x86/intel-hid.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index bcf438f38781..4d1c5eb3a96d 100644 --- a/drivers/platform/x86/intel-hid.c +++ b/drivers/platform/x86/intel-hid.c @@ -79,12 +79,10 @@ struct intel_hid_priv { static int intel_hid_set_enable(struct device *device, int enable) { - union acpi_object arg0 = { ACPI_TYPE_INTEGER }; - struct acpi_object_list args = { 1, &arg0 }; acpi_status status; - arg0.integer.value = enable; - status = acpi_evaluate_object(ACPI_HANDLE(device), "HDSM", &args, NULL); + status = acpi_execute_simple_method(ACPI_HANDLE(device), "HDSM", + enable); if (ACPI_FAILURE(status)) { dev_warn(device, "failed to %sable hotkeys\n", enable ? "en" : "dis");