From patchwork Thu Mar 9 09:36:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9612807 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5605860417 for ; Thu, 9 Mar 2017 09:44:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5296E285AE for ; Thu, 9 Mar 2017 09:44:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 472A2285E6; Thu, 9 Mar 2017 09:44:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD48F285AE for ; Thu, 9 Mar 2017 09:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbdCIJoA (ORCPT ); Thu, 9 Mar 2017 04:44:00 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35557 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753291AbdCIJn7 (ORCPT ); Thu, 9 Mar 2017 04:43:59 -0500 Received: by mail-lf0-f66.google.com with SMTP id v2so4196525lfi.2 for ; Thu, 09 Mar 2017 01:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HISyxkdacMSkFGUav0pnVl7/LUspPE/ZXSFAzFPFyB4=; b=k16fKZi7tAtkTagATNaRMHWIABE0CWl7JBYLU3uzGZ26Gz1K0BfFGFt/l1GtTDjOMC /y7g0A9w77JA9PcorFmcGLR6HRBXXWyiytl7kymZfheUyJPNrR23XQmJmgv2CarEVvH+ 4RnyuTUiRuAaCOnibzFcyZJQLeM8tA7zByNxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HISyxkdacMSkFGUav0pnVl7/LUspPE/ZXSFAzFPFyB4=; b=tXI89lZCOhvcblh80QFmj1KzIMLTZ+6GZFgLJEFCcHksWuYHQjz2gQSYn7SWXH6Chv mVc390/xjkC70jLVNbTDuHzTN4C6zETiMr7Ns5aWFwTxDMRS4sLrhFpe+Qlg+CJpraJH GyBIZK/VKSuZxRwCGVggCvnSHndQGJU/mnGbJoqhcxsvDsx77ktFiOPWWA7TTS5r/GTv eMPAZbTSV4EP4gDxCdd0PQTirQ+lRJyFjHHsl1HAiuZ0yWvDJm9l519OHRSCfexjIeX6 vWGqr7ZFTgowFYtnp+x1plj6cTG+sbp8ZGJYxH5F7M45zUjebKnAz49Mif1UGM5956y2 FobQ== X-Gm-Message-State: AMke39mWl+KSVYV3qyarqjIrcsA2SWc4ojYDomR/svc4N/HS79dXvE5lSi/DZIK90fc0yA== X-Received: by 10.25.25.147 with SMTP id 141mr3036059lfz.87.1489052216502; Thu, 09 Mar 2017 01:36:56 -0800 (PST) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id j6sm1129327lfg.60.2017.03.09.01.36.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Mar 2017 01:36:56 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Alex Hung , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly Date: Thu, 9 Mar 2017 10:36:51 +0100 Message-Id: <20170309093651.7824-1-kernel@kempniu.pl> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP devm_input_allocate_device() already causes the supplied struct device to be set as the parent of the input device, so doing it again is redundant. Signed-off-by: Michał Kępień --- This patch needs my recent intel-hid cleanup series to apply cleanly. In other words, it should apply on top of testing, but not for-next. drivers/platform/x86/intel-hid.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index 5eab31659cba..b40059aba856 100644 --- a/drivers/platform/x86/intel-hid.c +++ b/drivers/platform/x86/intel-hid.c @@ -152,7 +152,6 @@ static int intel_hid_input_setup(struct platform_device *device) if (ret) return ret; - priv->input_dev->dev.parent = &device->dev; priv->input_dev->name = "Intel HID events"; priv->input_dev->id.bustype = BUS_HOST; @@ -173,7 +172,6 @@ static int intel_button_array_input_setup(struct platform_device *device) if (ret) return ret; - priv->array->dev.parent = &device->dev; priv->array->name = "Intel HID 5 button array"; priv->array->id.bustype = BUS_HOST;