From patchwork Thu Mar 9 12:11:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9613215 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5E4CC602B4 for ; Thu, 9 Mar 2017 12:12:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A05B285CE for ; Thu, 9 Mar 2017 12:12:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3C70728600; Thu, 9 Mar 2017 12:12:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB8C2285CE for ; Thu, 9 Mar 2017 12:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754793AbdCIMMe (ORCPT ); Thu, 9 Mar 2017 07:12:34 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35807 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754640AbdCIMMd (ORCPT ); Thu, 9 Mar 2017 07:12:33 -0500 Received: by mail-lf0-f65.google.com with SMTP id v2so4478050lfi.2 for ; Thu, 09 Mar 2017 04:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ci1n8UiOnCso4XKXFVDVh47b2ehoETjt8i2gygVZmDI=; b=tzvRs8xYsG4krNHF+F6LA6OF3MJOdcEJaEtqG/FwIq4P856mGQA9RB/6u9rYqKAOsD AidW4IvdnuN8PRI1UrUb6bHEmSFcTgaQUItYg4aCKG6yKp1SRQ6Tl5MZ5NcBWgta5Bgr /LBogUYSGEyJYbaJDjq5oU3kqmlVeQrsov6Pc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ci1n8UiOnCso4XKXFVDVh47b2ehoETjt8i2gygVZmDI=; b=W6X/4n4posFEAM6QrbQoD3B8hPJHmUCkMqD28w5EMUSCDokfRwdAiRinj2QjRHAugJ NEn+cQJTrbMnXELnJaHCxG18xZBHsaeAo9kZ0yJixC5gVswqlDDLdpjqDH6vdjmL3Gvw 8Sj/qQOs4e7Ie5I2arHjtVh8AWmN+3KwCu1QMLiPfP/xL5nDcHRxVHuL3TLI9kbzDYSf dBGN72l4t2r7LdLL3iX7f4QXu4dGaDDbdsE4D0a7eW1wM9idR1I9pAAX31MW4mQejweE 1KfLiPaNI6SfJ3BwhwhTUrPSQAdLV0h7YXi91jEBnxIhS3fmdswTTxUbTH1vdwG4D/47 GXCg== X-Gm-Message-State: AMke39lBVKHF4WIpwUAA3J9FPKuZyhix1mRgjriZFKR1XVwmirqK1yOxHA5oP6uqkNzzmA== X-Received: by 10.25.25.14 with SMTP id 14mr3163256lfz.153.1489061550810; Thu, 09 Mar 2017 04:12:30 -0800 (PST) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id o91sm1247952lfg.1.2017.03.09.04.12.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Mar 2017 04:12:30 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/14] platform/x86: hp-wmi: remove sparse_keymap_free() calls Date: Thu, 9 Mar 2017 13:11:43 +0100 Message-Id: <20170309121150.10553-8-kernel@kempniu.pl> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170309121150.10553-1-kernel@kempniu.pl> References: <20170309121150.10553-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As sparse_keymap_setup() now uses a managed memory allocation for the keymap copy it creates, the latter is freed automatically. Remove all calls to sparse_keymap_free(). Signed-off-by: Michał Kępień --- drivers/platform/x86/hp-wmi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index 96ffda493266..7abf92d0ba81 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c @@ -673,7 +673,7 @@ static int __init hp_wmi_input_setup(void) status = wmi_install_notify_handler(HPWMI_EVENT_GUID, hp_wmi_notify, NULL); if (ACPI_FAILURE(status)) { err = -EIO; - goto err_free_keymap; + goto err_free_dev; } err = input_register_device(hp_wmi_input_dev); @@ -684,8 +684,6 @@ static int __init hp_wmi_input_setup(void) err_uninstall_notifier: wmi_remove_notify_handler(HPWMI_EVENT_GUID); - err_free_keymap: - sparse_keymap_free(hp_wmi_input_dev); err_free_dev: input_free_device(hp_wmi_input_dev); return err; @@ -694,7 +692,6 @@ static int __init hp_wmi_input_setup(void) static void hp_wmi_input_destroy(void) { wmi_remove_notify_handler(HPWMI_EVENT_GUID); - sparse_keymap_free(hp_wmi_input_dev); input_unregister_device(hp_wmi_input_dev); }