| Message ID | 20170701101522.13646-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Darren Hart |
| Headers | show |
On Sat, Jul 01, 2017 at 12:15:22PM +0200, Hans de Goede wrote: > Add touchscreen info for I.T.Works TW891 2-in-1. > ... > + /* I.T.Works TW891 */ > + .driver_data = (void *)&itworks_tw891_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), *groan* you're trolling me now right? ;-) > + DMI_MATCH(DMI_PRODUCT_NAME, "TW891"), I presume there are no other identifying strings? Pushed to testing.
Hi, On 07-07-17 00:39, Darren Hart wrote: > On Sat, Jul 01, 2017 at 12:15:22PM +0200, Hans de Goede wrote: >> Add touchscreen info for I.T.Works TW891 2-in-1. >> > > ... > >> + /* I.T.Works TW891 */ >> + .driver_data = (void *)&itworks_tw891_data, >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), > > *groan* you're trolling me now right? ;-) Nope, sorry, this seemed better then matching on a single string. FWIW I did an internet search for TW891 and there are no other devices named TW891. >> + DMI_MATCH(DMI_PRODUCT_NAME, "TW891"), > > I presume there are no other identifying strings? Correct if there was something better I would have used it. > Pushed to testing. Thank you. Regards, Hans
diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c index 25cbea307a5e..6218deb22319 100644 --- a/drivers/platform/x86/silead_dmi.c +++ b/drivers/platform/x86/silead_dmi.c @@ -122,6 +122,20 @@ static const struct silead_ts_dmi_data pipo_w2s_data = { .properties = pipo_w2s_props, }; +static const struct property_entry itworks_tw891_props[] = { + PROPERTY_ENTRY_U32("touchscreen-size-x", 1600), + PROPERTY_ENTRY_U32("touchscreen-size-y", 890), + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"), + PROPERTY_ENTRY_STRING("firmware-name", "gsl3670-itworks-tw891.fw"), + { } +}; + +static const struct silead_ts_dmi_data itworks_tw891_data = { + .acpi_name = "MSSL1680:00", + .properties = itworks_tw891_props, +}; + static const struct dmi_system_id silead_ts_dmi_table[] = { { /* CUBE iwork8 Air */ @@ -187,6 +201,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "W2S"), }, }, + { + /* I.T.Works TW891 */ + .driver_data = (void *)&itworks_tw891_data, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), + DMI_MATCH(DMI_PRODUCT_NAME, "TW891"), + }, + }, { }, };
Add touchscreen info for I.T.Works TW891 2-in-1. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/platform/x86/silead_dmi.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)