Message ID | 20171005104211.30440-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Darren Hart |
Headers | show |
On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The structures mlxplat_dev and mlxplat_hotplug are local to the source > and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'mlxplat_dev' was not declared. Should it be static? > symbol 'mlxplat_hotplug' was not declared. Should it be static? Thanks for the patch. Since Vadim did some rather big driver changes I would like to hear from him how to proceed with this one: either I apply it now, or after we get Vadim's series in.
On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote: > On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The structures mlxplat_dev and mlxplat_hotplug are local to the source > > and do not need to be in global scope, so make them static. > > > > Cleans up sparse warnings: > > symbol 'mlxplat_dev' was not declared. Should it be static? > > symbol 'mlxplat_hotplug' was not declared. Should it be static? > > Thanks for the patch. > Since Vadim did some rather big driver changes I would like to hear > from him how to proceed with this one: either I apply it now, or after > we get Vadim's series in. I'll be working with Vadim's series shortly and would like to take this after that is settled.
On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote: > On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The structures mlxplat_dev and mlxplat_hotplug are local to the source > > and do not need to be in global scope, so make them static. > > > > Cleans up sparse warnings: > > symbol 'mlxplat_dev' was not declared. Should it be static? > > symbol 'mlxplat_hotplug' was not declared. Should it be static? > > Thanks for the patch. > Since Vadim did some rather big driver changes I would like to hear > from him how to proceed with this one: either I apply it now, or after > we get Vadim's series in. > I've asked Vadim to rework some of the mlx platform and hotplug patches, so I'll be taking this now as it is a minimal patch - this way it doesn't get lost. Thanks Colin.
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c index 4f3de2a8c4df..504256c3660d 100644 --- a/drivers/platform/x86/mlx-platform.c +++ b/drivers/platform/x86/mlx-platform.c @@ -216,8 +216,8 @@ static struct resource mlxplat_mlxcpld_resources[] = { [0] = DEFINE_RES_IRQ_NAMED(17, "mlxcpld-hotplug"), }; -struct platform_device *mlxplat_dev; -struct mlxcpld_hotplug_platform_data *mlxplat_hotplug; +static struct platform_device *mlxplat_dev; +static struct mlxcpld_hotplug_platform_data *mlxplat_hotplug; static int __init mlxplat_dmi_default_matched(const struct dmi_system_id *dmi) {