diff mbox

[v6,01/11] intel_sgx: updated MAINTAINERS

Message ID 20171125193132.24321-2-jarkko.sakkinen@linux.intel.com (mailing list archive)
State Superseded, archived
Delegated to: Darren Hart
Headers show

Commit Message

Jarkko Sakkinen Nov. 25, 2017, 7:29 p.m. UTC
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Joe Perches Nov. 25, 2017, 8:19 p.m. UTC | #1
On Sat, 2017-11-25 at 21:29 +0200, Jarkko Sakkinen wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -14932,6 +14932,11 @@ L:	linux-mm@kvack.org
>  S:	Maintained
>  F:	mm/zswap.c
>  
> +INTEL SGX
> +M:	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> +L:	intel-sgx-kernel-dev@lists.01.org
> +Q:	https://patchwork.kernel.org/project/intel-sgx/list/

Alphabetical order please and this should
have at least an "F:" pattern like:

F:	drivers/platform/x86/intel_sgx/

and maybe a "K: pattern like:

K:	\bSGX_

The lower case version matches too many other subsystems

$ git grep -i -P --name-only "\b_?sgx_"
arch/arm/boot/dts/omap36xx-am35xx-omap3430es2plus-clocks.dtsi
arch/arm/boot/dts/omap44xx-clocks.dtsi
arch/arm/mach-omap2/clockdomains3xxx_data.c
arch/arm/mach-omap2/clockdomains81xx_data.c
arch/arm/mach-omap2/cm3xxx.c
arch/arm/mach-omap2/omap_hwmod_44xx_data.c
arch/arm/mach-omap2/powerdomains3xxx_data.c
drivers/clk/ti/clk-3xxx-legacy.c
drivers/clk/ti/clk-3xxx.c
drivers/clk/ti/clk-44xx.c
drivers/gpu/drm/gma500/cdv_device.c
drivers/gpu/drm/gma500/mdfld_device.c
drivers/gpu/drm/gma500/oaktrail_device.c
drivers/gpu/drm/gma500/psb_device.c
drivers/gpu/drm/gma500/psb_drv.c
drivers/gpu/drm/gma500/psb_drv.h
drivers/gpu/drm/gma500/psb_irq.c

> +
>  THE REST
>  M:	Linus Torvalds <torvalds@linux-foundation.org>
>  L:	linux-kernel@vger.kernel.org
Bjørn Mork Nov. 26, 2017, 10:41 a.m. UTC | #2
Joe Perches <joe@perches.com> writes:
> On Sat, 2017-11-25 at 21:29 +0200, Jarkko Sakkinen wrote:
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -14932,6 +14932,11 @@ L:	linux-mm@kvack.org
>>  S:	Maintained
>>  F:	mm/zswap.c
>>  
>> +INTEL SGX
>> +M:	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>> +L:	intel-sgx-kernel-dev@lists.01.org
>> +Q:	https://patchwork.kernel.org/project/intel-sgx/list/
>
> Alphabetical order please and this should
> have at least an "F:" pattern like:
>
> F:	drivers/platform/x86/intel_sgx/

FYI: Darren already requested that when reviewing v5:
https://www.spinics.net/lists/kernel/msg2651743.html



Bjørn
Jarkko Sakkinen Nov. 26, 2017, 3:33 p.m. UTC | #3
On Sun, Nov 26, 2017 at 11:41:42AM +0100, Bjørn Mork wrote:
> Joe Perches <joe@perches.com> writes:
> > On Sat, 2017-11-25 at 21:29 +0200, Jarkko Sakkinen wrote:
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> >> @@ -14932,6 +14932,11 @@ L:	linux-mm@kvack.org
> >>  S:	Maintained
> >>  F:	mm/zswap.c
> >>  
> >> +INTEL SGX
> >> +M:	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >> +L:	intel-sgx-kernel-dev@lists.01.org
> >> +Q:	https://patchwork.kernel.org/project/intel-sgx/list/
> >
> > Alphabetical order please and this should
> > have at least an "F:" pattern like:
> >
> > F:	drivers/platform/x86/intel_sgx/
> 
> FYI: Darren already requested that when reviewing v5:
> https://www.spinics.net/lists/kernel/msg2651743.html

Joe, Bjørn, thank you for your feedback. I kind of left the MAINTAINERS
update open because I wanted to get feedback who to add as reviewers and
forgot to add "F:". I'll definitely fix this for v7. I'm sorry for
ingoring it for v6.

You might have noticed that v6 was not CC'd to mailing list defined in
"M:". The reason for this is that I've lost the admin password for the
ML so I could not reconfigure it (see tglx's complains for v5). I'll get
this fixed early next week.

/Jarkko
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 2d3d750b19c0..30a4b7f97a93 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14932,6 +14932,11 @@  L:	linux-mm@kvack.org
 S:	Maintained
 F:	mm/zswap.c
 
+INTEL SGX
+M:	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
+L:	intel-sgx-kernel-dev@lists.01.org
+Q:	https://patchwork.kernel.org/project/intel-sgx/list/
+
 THE REST
 M:	Linus Torvalds <torvalds@linux-foundation.org>
 L:	linux-kernel@vger.kernel.org