From patchwork Wed Dec 13 08:13:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhaval Shah X-Patchwork-Id: 10109463 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 97C2F602C2 for ; Wed, 13 Dec 2017 08:15:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A94B288A6 for ; Wed, 13 Dec 2017 08:15:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E88B28B11; Wed, 13 Dec 2017 08:15:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00077288A6 for ; Wed, 13 Dec 2017 08:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbdLMIPC (ORCPT ); Wed, 13 Dec 2017 03:15:02 -0500 Received: from mail-ma1ind01on0119.outbound.protection.outlook.com ([104.47.100.119]:59014 "EHLO IND01-MA1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750880AbdLMIOe (ORCPT ); Wed, 13 Dec 2017 03:14:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=softnautics.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZveK/9JdlBVcCnMzJhuSAAy1eDkn8aVzcFw/pUhghtE=; b=vxZz8uzBCAecVFOdXr+Zfs1w057JOAvZ6lHGzP/2F98Zx9rPd/QHhu4CEIr/sjD5qJgI9kFP/FVEIGmR61YRkNruR514UGiZYKFK0UwAWjtDJNXMeSV6lZ12j8YZmx5QhXN7rw7Uq5wZ1cMTAFveFfxZ/mLlmHwDTe3MGUs0N+Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dhaval.shah@softnautics.com; Received: from piyush.sibshivalik.com (219.65.63.222) by BM1PR0101MB1441.INDPRD01.PROD.OUTLOOK.COM (52.133.128.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Wed, 13 Dec 2017 08:14:32 +0000 From: Dhaval Shah To: mjg59@srcf.ucam.org, pali.rohar@gmail.com, andy@infradead.org Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dhaval Shah Subject: [PATCH 2/3] platform/x86: dell-laptop: Missing a blank line after declarations Date: Wed, 13 Dec 2017 13:43:08 +0530 Message-Id: <20171213081309.22851-3-dhaval.shah@softnautics.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171213081309.22851-1-dhaval.shah@softnautics.com> References: <20171213081309.22851-1-dhaval.shah@softnautics.com> MIME-Version: 1.0 X-Originating-IP: [219.65.63.222] X-ClientProxiedBy: BM1PR0101CA0058.INDPRD01.PROD.OUTLOOK.COM (10.174.220.148) To BM1PR0101MB1441.INDPRD01.PROD.OUTLOOK.COM (52.133.128.8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f4fa737-41e9-4dfc-6e2e-08d542018a1b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4603075)(4627115)(201702281549075)(2017052603307); SRVR:BM1PR0101MB1441; X-Microsoft-Exchange-Diagnostics: 1; BM1PR0101MB1441; 3:9wjfYcwNtOndD4axjvbw9K1bz5Sgu/6kj/CXkAHuUpzVAhacMsEgJfimcmV3gX7W22tttnxj7oEBvDpP+TlRfUS15DYO3qX/rU2JA+8gisGdi+VgwIb1+lGo0It7Bli9oEWoWf0+QOWh9HuOaMjv7VwnNJ/9PAxm+CN63f+qfWFTKl+0GmWwYERccwkDOI9XCxPYZNm/zWZSjIGsK3zg42O0yAPuaxEsnJv6b0Y0MVsb5L11iZ4N2DrISXX5MTFY; 25:lbJWCUMQ4ZPNuC/oIL6Bu2sbAMs4EsCJJRh2PD1ZDxATCjQilYNPcrHvdahZxeDY9Qz0qt6+XtdMA/p83xqTCXNj5BBjlTE+1j0GBP8LRhey5lhSmHxgUl+iK+bW+DBWoo/IA/rOH5dhNBT2wPo8uSfTQkTFb/Mq6JjheNL3HfnYoityYFRVqlQsKVGXxo/G+LoW5o7vSAF5OC+K/TzW6peqLNbE95wJxu5XkeZh/1C8FsEkv6ausMAdO8WL+PLydjZYuCATlHnr1dNXOaUjOCkaWHvTJ387YpmoEObSu/tK8cZKMA7P6wINXuM+CcumSObgRFdxWhH9VytXbrHkvw==; 31:NbVD8ya4rEpCy3CmJ2PoDsXe51xhahsUVV2+K+a5MdmkpF2SZ8OHl1FX8srV2nR4DYF6Qzu3Nlqk8azX0fl/iDx6SX8vCShu9n5ta0g5H9tRwCSDmTprjhJ7EnYk+xL3WcfLDWJ351YZQ0vQ8esswNTSrO91Ojau6vJ8CsnM9P/pERvaNcmzDycsrZqPYH7wvRAlnDeiOeJXLi8ripck8EwWZtKWxQbJubnFTFF/xMg= X-MS-TrafficTypeDiagnostic: BM1PR0101MB1441: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(2016111802025)(6072148)(6043046)(201708071742011); SRVR:BM1PR0101MB1441; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BM1PR0101MB1441; X-Microsoft-Exchange-Diagnostics: 1; BM1PR0101MB1441; 4:if7ZB24Qz7jYuWdtmj/Jy2xUUOc/i68OR2U/0RTZy4JT/khViMpujulaxc85odYuzdlPR8G2XZUHU5GOX8WAXA1KlkOLfAvNnPjkP1utfXSfV4kFHCkxu+QQLEP/68xX2XJ0q+9c/77i1Cm0xeFNbaC7XX/eeMVa5D7f4oC2B8YkVI2pQ80+f7lnLpRlLSbWiF01wKgCpnH8TTGfbh7awTt7pGQN7P6rL2Kde6zAbqA38aFfu5GK50jaK7tuNwxYYC+AVT1/PFDgvY+vBghuLQ== X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(346002)(366004)(39830400002)(199004)(189003)(8676002)(76176011)(66066001)(81166006)(50466002)(107886003)(36756003)(81156014)(59450400001)(305945005)(386003)(69596002)(6506007)(52116002)(478600001)(97736004)(6486002)(48376002)(25786009)(47776003)(50226002)(53936002)(39060400002)(8936002)(2906002)(4326008)(68736007)(86362001)(16526018)(6116002)(6512007)(51416003)(316002)(16586007)(53416004)(105586002)(5660300001)(7736002)(2950100002)(6666003)(3846002)(1076002)(106356001); DIR:OUT; SFP:1102; SCL:1; SRVR:BM1PR0101MB1441; H:piyush.sibshivalik.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: softnautics.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BM1PR0101MB1441; 23:p77RtzNUFSEXjuIIP0tOfsRR9vH0XecdPE2eyp1?= =?us-ascii?Q?or/QVVKr07hjPinhbq7g8ecU2K2EzigsGQfgF8zaPQ8DemuLsa+ddKPIVDts?= =?us-ascii?Q?kvitjiG4XnuiDI3s4A4tZEgUWewwPOEI/SDVi0iymFA60tfvN3/I+at+YYYb?= =?us-ascii?Q?UlesmPLfcgiMOc3IkbPJhlgaR+w5lxer1dGWz9S03M9kAK+IZjvz/UaxDr3d?= =?us-ascii?Q?XiMLRQMfKZMcG2aeObvQ34sL3palrZTO4Wc2KZZ2B9P8YXabB8aMuSdexpjD?= =?us-ascii?Q?26CajUk1bFFlwsbBOyLCMW1BtsulUKSjXKJL7CV3pxhp8jEb7uA83BxVeEk+?= =?us-ascii?Q?YcwGtFl1EWvQJn9rUn8y8gty8kKxjYOgCjO2z/bnoSaF4/J0mDIReejnC3HJ?= =?us-ascii?Q?eqxRXq6GuWvC1X134LPpcM8mSVVsPXh9FlIOwfQ6j8fU35q0kXSRHVL30avN?= =?us-ascii?Q?8yMjU2Bye9H0oQkfO1QB0VyuSQGd7M3566cyXfN/AJOtWigLHWQnTK1VcCCr?= =?us-ascii?Q?mLz0iXG9mYOMXkmlPLmEyhfSBZqs7ZLfeBx8sTXX24RG8GfqTv61e6o51rAn?= =?us-ascii?Q?ysdDqyyK6KDSPY7jbAqAzxIGU9uUBYETuRFl43YNPEXwf4LHELFR1ao+3dbG?= =?us-ascii?Q?jVDkWbIX3Hn2dqi+r9v3g/UT3MN88EHGF0Oag/HppbvdV0rzBxl0Jqwc3B/3?= =?us-ascii?Q?kiZmfhZzzvIWsjYqvomSqqCzBZiQDaz/WWnQIvv8D8JAU5C4WMEaQDyejqyP?= =?us-ascii?Q?NLbsfn9fHg4hiKSk9NRNOqFvsbv4vqADNdGE+QkAl4CtMVimJrJ3tYD+JYop?= =?us-ascii?Q?j+W9AfnTMsWz+VwlC/u7SUbjhXqHE7UOcYwsT5gjse739m/Vu0p2ry0Lsg9e?= =?us-ascii?Q?TyKR6SazmIW9e1zBJWkrARWxeOG1Unj2RYZlXQBLcT8KGkSQJSM7JNfip+AC?= =?us-ascii?Q?EZIxuOa5GnI2CAOwx5SxReqOqlZtCdeJ8CMhWRDo4fQFxMn8xntPIWg4UG98?= =?us-ascii?Q?pGZJmubaL67LNqPmsgjdZZkdA/h3d5M/Ouig23SP8FoWgVJci4hGeqXF6Nck?= =?us-ascii?Q?4F1c8dsZ5AiC6hLK6Oi5iiiEm9Mx//ZMDbhFFLdMVMFoiO4nedZWS5r5O4a4?= =?us-ascii?Q?ZE/DiP/ei/W6HdaBbMZ608eFtzbkSUAIA?= X-Microsoft-Exchange-Diagnostics: 1; BM1PR0101MB1441; 6:tFNhsydA596jToNtO7EoUaZCsviTeCVluwH1iz+3+8gg3MyUrFTaCdAgudzw9X1MHp+VjYrPrckuVVGmymdfMEcrdFXOON6t7y7Sv9G4/86HBNwadP2I7JEE6947rTrCsvgCXIddkh2bSC4WQZtyIMsdzYvL914KdLLyfo4ZnfLoTZU5VlP2Ki6wFD+K0RUkXINV253pF87S1mgUZzZohLlQidNsvumk24hu5Aoz9qHZPpc0vVeBjR5pNtpOnoTZ5lVdZ/TEnOsJJLL7ILhpaZ0gYWOzQ8EiZUoktQSk/T3/iNRZbp9+wYyO+qbm3vBTezxsBd24ruKTcgrDPx6xiqgROxg4FEFmbrN/4s9jHMY=; 5:l3US46on3LYHchHSX5kK7v9o6GHwilQLq+DppHVJTWA/W9Oo2+3RMmaVQKewjkT2QXbSp6XCHMlufSgxB6NsUZ4Nxoer4i15pjTSkHwkT4jTtMw/sNWPzikzdxBXOQNS8WKI2zNGQASdvj1P0ie1/gmfi20EKSL1wGNWMPo15tQ=; 24:lASz4gd2PUht4CwI2MU6r+Vw3bVuWpClXI4BmFq3Lmhf06rqPOiQXAF6bzRm3phVDZ7R0IjwTYBWPWaJBsiZ0EFYFQ5wMyDQGVL3P2Cjhxo=; 7:WNzKmwAtOsqGhygvrlSJHzqPgCevWOoZ50nVagzrYNuq8pU8P79uOF1fSecdxMuopkxQxNo1X2inzqvnTxBXJ9EU67k+BqMdmiZrOf68TI4JbuczInxbkLXyeXJeTlOpVJuklX4veOOIjBVD12CzqY4a66Xuc957CaAYT4N9J3xo5Fg/+Pn2360PkBq1SxO6B1UlNN/N0hAzThOL4EnKLcGYutdptlPaTrBw/ZMRUWRyqPMKqaeeZYwAqkfSPGAV SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: softnautics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 08:14:32.1309 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f4fa737-41e9-4dfc-6e2e-08d542018a1b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1441 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Resolved Missing a blank line after declarations checkpatch warnings. Issue found by checkpatch. Signed-off-by: Dhaval Shah --- drivers/platform/x86/dell-laptop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 9b0855236e3d..bf4e73a02b39 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -466,6 +466,7 @@ static void dell_rfkill_update_sw_state(struct rfkill *rfkill, int radio, if (status & BIT(0)) { /* Has hw-switch, sync sw_state to BIOS */ int block = rfkill_blocked(rfkill); + dell_set_arguments(1 | (radio << 8) | (block << 16), 0, 0, 0); dell_send_request(CLASS_INFO, SELECT_RFKILL); } else { @@ -899,6 +900,7 @@ static void touchpad_led_on(void) { int command = 0x97; char data = 1; + i8042_command(&data, command | 1 << 12); } @@ -906,6 +908,7 @@ static void touchpad_led_off(void) { int command = 0x97; char data = 2; + i8042_command(&data, command | 1 << 12); } @@ -2130,6 +2133,7 @@ static int __init dell_init(void) if (max_intensity) { struct backlight_properties props; + memset(&props, 0, sizeof(struct backlight_properties)); props.type = BACKLIGHT_PLATFORM; props.max_brightness = max_intensity;