| Message ID | 20180308091023.9061-1-kai.heng.feng@canonical.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Darren Hart |
| Headers | show |
On Thu, Mar 08, 2018 at 05:10:21PM +0800, Kai-Heng Feng wrote: > This header will be used for more than just led. Change it to a more > generic name. > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > v2: Mario suggested to squash the HDA part into the same series. Apologies for the silence on my end. I've reviewed all the comments, and my understanding is we are awaiting a v3 from Kai-Heng. Is that correct? Mario and Pali, thank you for working through the heuristics of platform identification. I appreciate taking the time to look at the big picture, or the scale impacts ("what if everyone did this?") - that leads to better solutions. Of course, this is the platform driver subsystem, and part of why we exist is to cover the quirks of today's systems, so we can't spend too much time on what-ifs. I think your conclusions were reasonable. So I'm waiting for v3 from Kai-Heng - unless I've misunderstood the conclusion of this thread.
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index c52c6723374b..8ba820e6c3d0 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -29,7 +29,7 @@ #include <linux/mm.h> #include <linux/i8042.h> #include <linux/debugfs.h> -#include <linux/dell-led.h> +#include <linux/dell-common.h> #include <linux/seq_file.h> #include <acpi/video.h> #include "dell-rbtn.h" diff --git a/include/linux/dell-led.h b/include/linux/dell-common.h similarity index 61% rename from include/linux/dell-led.h rename to include/linux/dell-common.h index 92521471517f..37e4b614dd74 100644 --- a/include/linux/dell-led.h +++ b/include/linux/dell-common.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ -#ifndef __DELL_LED_H__ -#define __DELL_LED_H__ +#ifndef __DELL_COMMON_H__ +#define __DELL_COMMON_H__ int dell_micmute_led_set(int on); diff --git a/sound/pci/hda/dell_wmi_helper.c b/sound/pci/hda/dell_wmi_helper.c index 1b48a8c19d28..56050cc3c0ee 100644 --- a/sound/pci/hda/dell_wmi_helper.c +++ b/sound/pci/hda/dell_wmi_helper.c @@ -4,7 +4,7 @@ */ #if IS_ENABLED(CONFIG_DELL_LAPTOP) -#include <linux/dell-led.h> +#include <linux/dell-common.h> enum { MICMUTE_LED_ON,
This header will be used for more than just led. Change it to a more generic name. Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- v2: Mario suggested to squash the HDA part into the same series. drivers/platform/x86/dell-laptop.c | 2 +- include/linux/{dell-led.h => dell-common.h} | 4 ++-- sound/pci/hda/dell_wmi_helper.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) rename include/linux/{dell-led.h => dell-common.h} (61%)