From patchwork Thu May 24 18:07:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Timur_Krist=C3=B3f?= X-Patchwork-Id: 10425301 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 450C36019D for ; Thu, 24 May 2018 18:08:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9C1328E0C for ; Thu, 24 May 2018 18:08:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ADA5428FEB; Thu, 24 May 2018 18:08:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11F2028E0C for ; Thu, 24 May 2018 18:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032275AbeEXSIN (ORCPT ); Thu, 24 May 2018 14:08:13 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33725 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032266AbeEXSIM (ORCPT ); Thu, 24 May 2018 14:08:12 -0400 Received: by mail-wr0-f193.google.com with SMTP id a15-v6so4753025wrm.0 for ; Thu, 24 May 2018 11:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HDiGEqde12lNUvFefYjGsuSCI8+0sAn7JMVzvXoNqvE=; b=KmpYQUhc+q8MHN6gnyQ92UbI1fKMzBPEBRYC0NOOaDOgIavwj33YjUnwEZ2rzG78hT WVVJZKwh6jtyFgTNI0gR0xKwvbQdF3NGwtQPjCI+FuM3KThKtNTn191JD32GLP7z/My0 X93sfeRYthtYKvrKk4af7DeGVKaTA6f1YuBs7odvsF5vXoSxlBCaaQMYwMBCsy8KaCgu hLAcku+xH4wJv+05oeD6LmIGIT/sWi6rE11qyGcVGw8tp4NKOxHauL/d36NyeiuMQd1u vJetG4jru3cSYhj5jMxrcKuQq5WrQkaHv6ogpPRBmGzBWZ66dxeHmIpSQD3Tq9Ch8Ns9 GwRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HDiGEqde12lNUvFefYjGsuSCI8+0sAn7JMVzvXoNqvE=; b=VmieEuabU+vdCqVBzVXlXO8kfqjuUF3aizNsYcMq5IlmUiK946DHBHkesOY+VmpzGC b0iKIJ/JpfgnjOeeqN+XIDE2SbF8I/sXHRHQhczGfTkWoPG8BaQGuS+HzuuMQsZLXZcm 3Lqt7ILXZ4wywxKsKwGCfDd5JkOkcsXZbOFcUj1wVAa5EoKox0AzITf4gCxnD9UyQhZx C5Ax4dqZu6o8s2OCJbrElXfKmj4wxU6dtGS0K0Pu4hBGr1z1oBbhqGGZkIP5h5kdj1zU +SQ4169F7SQ1Lrp2weD+9Br8rWzTbJaZ1yabG16pugeiU78KjoqNe1DLvRQwQ34U6SI1 uy5g== X-Gm-Message-State: ALKqPwfn3CEHXmQRxoJKGwymuHkaW1lsKb6IrI59TR4MTSK1GYupyLSO /m/ZTdtMmxkdmaiVv3hxROA= X-Google-Smtp-Source: AB8JxZrzzlOz040hdtV31LiP3R79xeirJwkuDRkd/cVbrkwAr0hw3OF2cvW/9XSzSdeNpUUbaHzC2g== X-Received: by 2002:adf:b782:: with SMTP id s2-v6mr5475466wre.247.1527185291811; Thu, 24 May 2018 11:08:11 -0700 (PDT) Received: from localhost.localdomain ([152.66.80.213]) by smtp.gmail.com with ESMTPSA id 38-v6sm52228485wry.61.2018.05.24.11.08.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 May 2018 11:08:10 -0700 (PDT) From: "=?UTF-8?q?Timur=20Krist=C3=B3f?=" X-Google-Original-From: =?UTF-8?q?Timur=20Krist=C3=B3f?= To: timur.kristof@gmail.com, platform-driver-x86@vger.kernel.org Cc: =?UTF-8?q?Timur=20Krist=C3=B3f?= , mjg59@srcf.ucam.org, pali.rohar@gmail.com, dvhart@infradead.org, andy@infradead.org Subject: [PATCH] Fix AC keyboard backlight timeout on Dell XPS 13 9370. Date: Thu, 24 May 2018 20:07:40 +0200 Message-Id: <20180524180740.25084-1-venemo@msn.com> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Timur Kristóf The 9370 doesn't expose the necessary KBD_LED_AC_TOKEN in the BIOS, so the driver thinks it cannot adjust the AC keyboard backlight timeout. This patch adds a quirk to fix this until Dell adds the missing token to their BIOS. For further discussion, see: https://github.com/dell/libsmbios/issues/48 Signed-off-by: Timur Kristóf --- drivers/platform/x86/dell-laptop.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index c52c6723374b..058944258161 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -38,6 +38,7 @@ struct quirk_entry { bool touchpad_led; bool kbd_led_levels_off_1; + bool support_kbd_timeout_ac_missing_tag; bool needs_kbd_timeouts; /* @@ -68,6 +69,10 @@ static struct quirk_entry quirk_dell_xps13_9333 = { .kbd_timeouts = { 0, 5, 15, 60, 5 * 60, 15 * 60, -1 }, }; +static struct quirk_entry quirk_dell_xps13_9370 = { + .support_kbd_timeout_ac_missing_tag = true, +}; + static struct quirk_entry quirk_dell_latitude_e6410 = { .kbd_led_levels_off_1 = true, }; @@ -291,6 +296,15 @@ static const struct dmi_system_id dell_quirks[] __initconst = { }, .driver_data = &quirk_dell_xps13_9333, }, + { + .callback = dmi_matched, + .ident = "Dell XPS 13 9370", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"), + }, + .driver_data = &quirk_dell_xps13_9370, + }, { .callback = dmi_matched, .ident = "Dell Latitude E6410", @@ -1401,7 +1415,7 @@ static inline int kbd_init_info(void) * timeout value which is shared for both battery and AC power * settings. So do not try to set AC values on old models. */ - if (dell_smbios_find_token(KBD_LED_AC_TOKEN)) + if (dell_smbios_find_token(KBD_LED_AC_TOKEN) || (quirks && quirks->support_kbd_timeout_ac_missing_tag)) kbd_timeout_ac_supported = true; kbd_get_state(&state);