| Message ID | 20180530054259.1550-1-yukx00@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
Hi, Adding the platform/x86 maintainers to the Cc. On 30-05-18 07:42, yuk7 wrote: > From: Haruka Kawajiri <yukx00@gmail.com> Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > > --- > drivers/platform/x86/silead_dmi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c > index 452aacab..c47b5860 100644 > --- a/drivers/platform/x86/silead_dmi.c > +++ b/drivers/platform/x86/silead_dmi.c > @@ -412,6 +412,15 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "S806"), > }, > }, > + { > + /* Chuwi Hi8 (H1D_S806_206) */ > + .driver_data = (void *)&chuwi_hi8_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), > + DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"), > + DMI_MATCH(DMI_BIOS_VERSION, "H1D_S806_206"), > + }, > + }, > { > /* Chuwi Vi8 (CWI506) */ > .driver_data = (void *)&chuwi_vi8_data, >
On Wed, May 30, 2018 at 11:15 AM, Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > Adding the platform/x86 maintainers to the Cc. > > On 30-05-18 07:42, yuk7 wrote: >> >> From: Haruka Kawajiri <yukx00@gmail.com> > This and your three are pushed to my review and testing queue, thanks! P.S. I would probably add commit message. > > Acked-by: Hans de Goede <hdegoede@redhat.com> > > Regards, > > Hans > > > >> >> --- >> drivers/platform/x86/silead_dmi.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/platform/x86/silead_dmi.c >> b/drivers/platform/x86/silead_dmi.c >> index 452aacab..c47b5860 100644 >> --- a/drivers/platform/x86/silead_dmi.c >> +++ b/drivers/platform/x86/silead_dmi.c >> @@ -412,6 +412,15 @@ static const struct dmi_system_id >> silead_ts_dmi_table[] = { >> DMI_MATCH(DMI_PRODUCT_NAME, "S806"), >> }, >> }, >> + { >> + /* Chuwi Hi8 (H1D_S806_206) */ >> + .driver_data = (void *)&chuwi_hi8_data, >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), >> + DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"), >> + DMI_MATCH(DMI_BIOS_VERSION, "H1D_S806_206"), >> + }, >> + }, >> { >> /* Chuwi Vi8 (CWI506) */ >> .driver_data = (void *)&chuwi_vi8_data, >> >
Hi, On 31-05-18 14:07, Andy Shevchenko wrote: > On Wed, May 30, 2018 at 11:15 AM, Hans de Goede <hdegoede@redhat.com> wrote: >> Hi, >> >> Adding the platform/x86 maintainers to the Cc. >> >> On 30-05-18 07:42, yuk7 wrote: >>> >>> From: Haruka Kawajiri <yukx00@gmail.com> >> > > This and your three are pushed to my review and testing queue, thanks! Thank you, but I'm not seeing these here; http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/shortlog/refs/heads/review-andy Did you perhaps forget to push them? Regards, Hans > > P.S. I would probably add commit message. > >> >> Acked-by: Hans de Goede <hdegoede@redhat.com> >> >> Regards, >> >> Hans >> >> >> >>> >>> --- >>> drivers/platform/x86/silead_dmi.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/drivers/platform/x86/silead_dmi.c >>> b/drivers/platform/x86/silead_dmi.c >>> index 452aacab..c47b5860 100644 >>> --- a/drivers/platform/x86/silead_dmi.c >>> +++ b/drivers/platform/x86/silead_dmi.c >>> @@ -412,6 +412,15 @@ static const struct dmi_system_id >>> silead_ts_dmi_table[] = { >>> DMI_MATCH(DMI_PRODUCT_NAME, "S806"), >>> }, >>> }, >>> + { >>> + /* Chuwi Hi8 (H1D_S806_206) */ >>> + .driver_data = (void *)&chuwi_hi8_data, >>> + .matches = { >>> + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), >>> + DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"), >>> + DMI_MATCH(DMI_BIOS_VERSION, "H1D_S806_206"), >>> + }, >>> + }, >>> { >>> /* Chuwi Vi8 (CWI506) */ >>> .driver_data = (void *)&chuwi_vi8_data, >>> >> > > >
On Fri, Jun 1, 2018 at 12:09 AM, Hans de Goede <hdegoede@redhat.com> wrote: > On 31-05-18 14:07, Andy Shevchenko wrote: >> On Wed, May 30, 2018 at 11:15 AM, Hans de Goede <hdegoede@redhat.com> >> wrote: >> This and your three are pushed to my review and testing queue, thanks! > Thank you, but I'm not seeing these here; > > http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/shortlog/refs/heads/review-andy > > Did you perhaps forget to push them? Locally it has been pushed before this message, just took a while to propagate to external repository. Now it is there (already for 10+ hours).
On Wed, May 30, 2018 at 11:15 AM, Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > Adding the platform/x86 maintainers to the Cc. > > On 30-05-18 07:42, yuk7 wrote: >> >> From: Haruka Kawajiri <yukx00@gmail.com> > > > Acked-by: Hans de Goede <hdegoede@redhat.com> Dropped from queue b/c no author's SoB found. Sorry, was my mistake to take it in this form. Please, submit a new version with author's SoB and given tags. P.S. We will work with Darren to improve our process to avoid such in the future.
diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c index 452aacab..c47b5860 100644 --- a/drivers/platform/x86/silead_dmi.c +++ b/drivers/platform/x86/silead_dmi.c @@ -412,6 +412,15 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "S806"), }, }, + { + /* Chuwi Hi8 (H1D_S806_206) */ + .driver_data = (void *)&chuwi_hi8_data, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), + DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"), + DMI_MATCH(DMI_BIOS_VERSION, "H1D_S806_206"), + }, + }, { /* Chuwi Vi8 (CWI506) */ .driver_data = (void *)&chuwi_vi8_data,
From: Haruka Kawajiri <yukx00@gmail.com> --- drivers/platform/x86/silead_dmi.c | 9 +++++++++ 1 file changed, 9 insertions(+)