| Message ID | 20180605011602.148-1-yukx00@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
On Tue, Jun 5, 2018 at 4:16 AM, Haruka Kawajiri <yukx00@gmail.com> wrote: There are three things missed now: - versioning of the patch (v2) - Ack you got from Hans - commit message I can add this myself this time, but please pay attention to this necessary properties of submitted material. Thanks! > Signed-off-by: Haruka Kawajiri <yukx00@gmail.com> > --- > drivers/platform/x86/silead_dmi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c > index 452aacab..c47b5860 100644 > --- a/drivers/platform/x86/silead_dmi.c > +++ b/drivers/platform/x86/silead_dmi.c > @@ -412,6 +412,15 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "S806"), > }, > }, > + { > + /* Chuwi Hi8 (H1D_S806_206) */ > + .driver_data = (void *)&chuwi_hi8_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), > + DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"), > + DMI_MATCH(DMI_BIOS_VERSION, "H1D_S806_206"), > + }, > + }, > { > /* Chuwi Vi8 (CWI506) */ > .driver_data = (void *)&chuwi_vi8_data, > -- > 2.17.0 >
Andy, On 05-06-18 10:53, Andy Shevchenko wrote: > On Tue, Jun 5, 2018 at 4:16 AM, Haruka Kawajiri <yukx00@gmail.com> wrote: > > There are three things missed now: > - versioning of the patch (v2) > - Ack you got from Hans > - commit message > > I can add this myself this time, but please pay attention to this > necessary properties of submitted material. > Thanks! So to be clear you plan to take this as is this time and Haruka does not need to send a new version? (I'm asking because I still see the old version without the S-o-b in review-andy). Regards, Hans > >> Signed-off-by: Haruka Kawajiri <yukx00@gmail.com> >> --- >> drivers/platform/x86/silead_dmi.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c >> index 452aacab..c47b5860 100644 >> --- a/drivers/platform/x86/silead_dmi.c >> +++ b/drivers/platform/x86/silead_dmi.c >> @@ -412,6 +412,15 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { >> DMI_MATCH(DMI_PRODUCT_NAME, "S806"), >> }, >> }, >> + { >> + /* Chuwi Hi8 (H1D_S806_206) */ >> + .driver_data = (void *)&chuwi_hi8_data, >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), >> + DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"), >> + DMI_MATCH(DMI_BIOS_VERSION, "H1D_S806_206"), >> + }, >> + }, >> { >> /* Chuwi Vi8 (CWI506) */ >> .driver_data = (void *)&chuwi_vi8_data, >> -- >> 2.17.0 >> > > >
On Thu, Jun 7, 2018 at 1:30 PM, Hans de Goede <hdegoede@redhat.com> wrote: > Andy, > > On 05-06-18 10:53, Andy Shevchenko wrote: >> >> On Tue, Jun 5, 2018 at 4:16 AM, Haruka Kawajiri <yukx00@gmail.com> wrote: >> >> There are three things missed now: >> - versioning of the patch (v2) >> - Ack you got from Hans >> - commit message >> >> I can add this myself this time, but please pay attention to this >> necessary properties of submitted material. >> Thanks! > > > So to be clear you plan to take this as is this time > and Haruka does not need to send a new version? Correct. > > (I'm asking because I still see the old version > without the S-o-b in review-andy). Pushed newer one to my review and testing queue, thanks! > > Regards, > > Hans > > > > > >> >>> Signed-off-by: Haruka Kawajiri <yukx00@gmail.com> >>> --- >>> drivers/platform/x86/silead_dmi.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/drivers/platform/x86/silead_dmi.c >>> b/drivers/platform/x86/silead_dmi.c >>> index 452aacab..c47b5860 100644 >>> --- a/drivers/platform/x86/silead_dmi.c >>> +++ b/drivers/platform/x86/silead_dmi.c >>> @@ -412,6 +412,15 @@ static const struct dmi_system_id >>> silead_ts_dmi_table[] = { >>> DMI_MATCH(DMI_PRODUCT_NAME, "S806"), >>> }, >>> }, >>> + { >>> + /* Chuwi Hi8 (H1D_S806_206) */ >>> + .driver_data = (void *)&chuwi_hi8_data, >>> + .matches = { >>> + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), >>> + DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"), >>> + DMI_MATCH(DMI_BIOS_VERSION, "H1D_S806_206"), >>> + }, >>> + }, >>> { >>> /* Chuwi Vi8 (CWI506) */ >>> .driver_data = (void *)&chuwi_vi8_data, >>> -- >>> 2.17.0 >>> >> >> >> >
diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c index 452aacab..c47b5860 100644 --- a/drivers/platform/x86/silead_dmi.c +++ b/drivers/platform/x86/silead_dmi.c @@ -412,6 +412,15 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "S806"), }, }, + { + /* Chuwi Hi8 (H1D_S806_206) */ + .driver_data = (void *)&chuwi_hi8_data, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), + DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"), + DMI_MATCH(DMI_BIOS_VERSION, "H1D_S806_206"), + }, + }, { /* Chuwi Vi8 (CWI506) */ .driver_data = (void *)&chuwi_vi8_data,
Signed-off-by: Haruka Kawajiri <yukx00@gmail.com> --- drivers/platform/x86/silead_dmi.c | 9 +++++++++ 1 file changed, 9 insertions(+)