| Message ID | 20181129174445.2885-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
| Series | [1/2] platform/x86: Add the VLV ISP PCI ID to atomisp2_pm | expand |
Hi Ville, On 29-11-18 18:44, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > If the ISP is exposed as a PCI device VLV machines need the > same treatment as CHV machines to power gate the ISP. Otherwise > s0ix will not work. > > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Alan Cox <alan@linux.intel.com> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Darren Hart <dvhart@infradead.org> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Thank you for the patches, both look good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> I've added both patches and the "drm/i915: Assert that VED and ISP are power gated" patch to me personal tree, which I regularly test on various BYT/CHT devices. If I notice anything wrt these patches I will let you know. Regards, Hans > --- > drivers/platform/x86/intel_atomisp2_pm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel_atomisp2_pm.c b/drivers/platform/x86/intel_atomisp2_pm.c > index 9371603a0ac9..4a2ec5eeb6d8 100644 > --- a/drivers/platform/x86/intel_atomisp2_pm.c > +++ b/drivers/platform/x86/intel_atomisp2_pm.c > @@ -99,6 +99,7 @@ static UNIVERSAL_DEV_PM_OPS(isp_pm_ops, isp_pci_suspend, > isp_pci_resume, NULL); > > static const struct pci_device_id isp_id_table[] = { > + { PCI_VDEVICE(INTEL, 0x0f38), }, > { PCI_VDEVICE(INTEL, 0x22b8), }, > { 0, } > }; >
On Sun, Dec 02, 2018 at 02:36:24PM +0100, Hans de Goede wrote: > On 29-11-18 18:44, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > If the ISP is exposed as a PCI device VLV machines need the > > same treatment as CHV machines to power gate the ISP. Otherwise > > s0ix will not work. > Thank you for the patches, both look good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > I've added both patches and the "drm/i915: Assert that VED > and ISP are power gated" patch to me personal tree, which I > regularly test on various BYT/CHT devices. If I notice > anything wrt these patches I will let you know. I have pushed them to my review and testing queue, thanks! P.S. We have some time to hear from Hans if something wrong with them.
Hi, On 03-12-18 20:04, Andy Shevchenko wrote: > On Sun, Dec 02, 2018 at 02:36:24PM +0100, Hans de Goede wrote: >> On 29-11-18 18:44, Ville Syrjala wrote: >>> From: Ville Syrjälä <ville.syrjala@linux.intel.com> >>> >>> If the ISP is exposed as a PCI device VLV machines need the >>> same treatment as CHV machines to power gate the ISP. Otherwise >>> s0ix will not work. > >> Thank you for the patches, both look good to me: >> >> Reviewed-by: Hans de Goede <hdegoede@redhat.com> >> >> I've added both patches and the "drm/i915: Assert that VED >> and ISP are power gated" patch to me personal tree, which I >> regularly test on various BYT/CHT devices. If I notice >> anything wrt these patches I will let you know. > > I have pushed them to my review and testing queue, thanks! > > P.S. We have some time to hear from Hans if something wrong with them. Sofar I've seen no adverse side-effects from these, but I've only tested on 2 different BYT models sofar. p.s. Did I respond to the remark in the commit msg about there still being an error with lspci ? I think I may have forgotten to respond to that bit. So let me reply here, I think that living with the error message showing up in dmesg on a lspci is fine, much better then the mess which it will be to fix it. Regards, Hans
On Mon, Dec 3, 2018 at 10:20 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 03-12-18 20:04, Andy Shevchenko wrote: > > On Sun, Dec 02, 2018 at 02:36:24PM +0100, Hans de Goede wrote: > >> On 29-11-18 18:44, Ville Syrjala wrote: > >>> From: Ville Syrjälä <ville.syrjala@linux.intel.com> > >>> > >>> If the ISP is exposed as a PCI device VLV machines need the > >>> same treatment as CHV machines to power gate the ISP. Otherwise > >>> s0ix will not work. > > > >> Thank you for the patches, both look good to me: > >> > >> Reviewed-by: Hans de Goede <hdegoede@redhat.com> > >> > >> I've added both patches and the "drm/i915: Assert that VED > >> and ISP are power gated" patch to me personal tree, which I > >> regularly test on various BYT/CHT devices. If I notice > >> anything wrt these patches I will let you know. > > > > I have pushed them to my review and testing queue, thanks! > > > > P.S. We have some time to hear from Hans if something wrong with them. > > Sofar I've seen no adverse side-effects from these, but I've only > tested on 2 different BYT models sofar. Both patches had been pushed, thanks!
diff --git a/drivers/platform/x86/intel_atomisp2_pm.c b/drivers/platform/x86/intel_atomisp2_pm.c index 9371603a0ac9..4a2ec5eeb6d8 100644 --- a/drivers/platform/x86/intel_atomisp2_pm.c +++ b/drivers/platform/x86/intel_atomisp2_pm.c @@ -99,6 +99,7 @@ static UNIVERSAL_DEV_PM_OPS(isp_pm_ops, isp_pci_suspend, isp_pci_resume, NULL); static const struct pci_device_id isp_id_table[] = { + { PCI_VDEVICE(INTEL, 0x0f38), }, { PCI_VDEVICE(INTEL, 0x22b8), }, { 0, } };