diff mbox series

[2/4] platform/x86: asus-nb-wmi: Add Asus FX705GE support

Message ID 20190703154102.20002-2-Nemcev_Aleksey@inbox.ru (mailing list archive)
State Changes Requested, archived
Headers show
Series [1/4] platform/x86: asus-wmi: Add wmi_needs_3_args quirk | expand

Commit Message

Nemcev Aleksey July 3, 2019, 3:41 p.m. UTC 
From: Aleksey Nemcev <Nemcev_Aleksey@inbox.ru>

This model has an AURA RGB backlight,
so wmi_needs_3_args quirk is required

Signed-off-by: Aleksey Nemcev <Nemcev_Aleksey@inbox.ru>
---
 drivers/platform/x86/asus-nb-wmi.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Andy Shevchenko July 4, 2019, 1:47 p.m. UTC | #1 
On Wed, Jul 3, 2019 at 6:41 PM <Nemcev_Aleksey@inbox.ru> wrote:
>
> From: Aleksey Nemcev <Nemcev_Aleksey@inbox.ru>
>
> This model has an AURA RGB backlight,
> so wmi_needs_3_args quirk is required

Thanks for the patch.
Though it does two logical things, i.e. new module support and new key bindings.
Please, split it to two changes and justify key bindings.

P.S. To all your patches, please use punctuation, like period at the
end of sentences and so on.

>
> Signed-off-by: Aleksey Nemcev <Nemcev_Aleksey@inbox.ru>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 4bed95357a32..bf937321f42e 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -406,6 +406,16 @@ static const struct dmi_system_id asus_quirks[] = {
>                 },
>                 .driver_data = &quirk_asus_forceals,
>         },
> +       {
> +               .callback = dmi_matched,
> +               .ident = "ASUSTeK COMPUTER INC. FX705GE",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME,
> +                                 "TUF Gaming FX705GE_FX705GE"),
> +               },
> +               .driver_data = &quirk_asus_wmi_needs_3_args,
> +       },
>         {},
>  };
>
> @@ -441,6 +451,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>         { KE_KEY, 0x30, { KEY_VOLUMEUP } },
>         { KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
>         { KE_KEY, 0x32, { KEY_MUTE } },
> +       { KE_KEY, 0x33, { KEY_BRIGHTNESS_MIN } },
>         { KE_KEY, 0x35, { KEY_SCREENLOCK } },
>         { KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
>         { KE_KEY, 0x41, { KEY_NEXTSONG } },
> @@ -467,6 +478,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>         { KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } },
>         { KE_IGNORE, 0x6E, },  /* Low Battery notification */
>         { KE_KEY, 0x7a, { KEY_ALS_TOGGLE } }, /* Ambient Light Sensor Toggle */
> +       { KE_KEY, 0x7C, { KEY_MICMUTE } },
>         { KE_KEY, 0x7D, { KEY_BLUETOOTH } }, /* Bluetooth Enable */
>         { KE_KEY, 0x7E, { KEY_BLUETOOTH } }, /* Bluetooth Disable */
>         { KE_KEY, 0x82, { KEY_CAMERA } },
> --
> 2.20.1
>
Nemcev Aleksey July 4, 2019, 2:09 p.m. UTC | #2 
Thank You for reply, I will split this patch.
Should I then resend whole patch set, or only resulting two patches?
I'm not very familiar with this process yet.

04.07.2019 16:47, Andy Shevchenko wrote:
> On Wed, Jul 3, 2019 at 6:41 PM <Nemcev_Aleksey@inbox.ru> wrote:
>> From: Aleksey Nemcev <Nemcev_Aleksey@inbox.ru>
>>
>> This model has an AURA RGB backlight,
>> so wmi_needs_3_args quirk is required
> Thanks for the patch.
> Though it does two logical things, i.e. new module support and new key bindings.
> Please, split it to two changes and justify key bindings.
>
> P.S. To all your patches, please use punctuation, like period at the
> end of sentences and so on.
>
>> Signed-off-by: Aleksey Nemcev <Nemcev_Aleksey@inbox.ru>
>> ---
>>   drivers/platform/x86/asus-nb-wmi.c | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
>> index 4bed95357a32..bf937321f42e 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -406,6 +406,16 @@ static const struct dmi_system_id asus_quirks[] = {
>>                  },
>>                  .driver_data = &quirk_asus_forceals,
>>          },
>> +       {
>> +               .callback = dmi_matched,
>> +               .ident = "ASUSTeK COMPUTER INC. FX705GE",
>> +               .matches = {
>> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> +                       DMI_MATCH(DMI_PRODUCT_NAME,
>> +                                 "TUF Gaming FX705GE_FX705GE"),
>> +               },
>> +               .driver_data = &quirk_asus_wmi_needs_3_args,
>> +       },
>>          {},
>>   };
>>
>> @@ -441,6 +451,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>>          { KE_KEY, 0x30, { KEY_VOLUMEUP } },
>>          { KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
>>          { KE_KEY, 0x32, { KEY_MUTE } },
>> +       { KE_KEY, 0x33, { KEY_BRIGHTNESS_MIN } },
>>          { KE_KEY, 0x35, { KEY_SCREENLOCK } },
>>          { KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
>>          { KE_KEY, 0x41, { KEY_NEXTSONG } },
>> @@ -467,6 +478,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>>          { KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } },
>>          { KE_IGNORE, 0x6E, },  /* Low Battery notification */
>>          { KE_KEY, 0x7a, { KEY_ALS_TOGGLE } }, /* Ambient Light Sensor Toggle */
>> +       { KE_KEY, 0x7C, { KEY_MICMUTE } },
>>          { KE_KEY, 0x7D, { KEY_BLUETOOTH } }, /* Bluetooth Enable */
>>          { KE_KEY, 0x7E, { KEY_BLUETOOTH } }, /* Bluetooth Disable */
>>          { KE_KEY, 0x82, { KEY_CAMERA } },
>> --
>> 2.20.1
>>
>
Andy Shevchenko July 4, 2019, 2:23 p.m. UTC | #3 
On Thu, Jul 4, 2019 at 5:09 PM Nemcev Aleksey <Nemcev_Aleksey@inbox.ru> wrote:
>
> Thank You for reply, I will split this patch.
> Should I then resend whole patch set, or only resulting two patches?
> I'm not very familiar with this process yet.

Please, do not top post.

You need to re-send entire series with increased version number (v2 here).
Also, you have to Cc to all subsystem maintainers, supporters and
designated reviewers (see get_maintainer.pl script).

Besides that, for patch series, especially such one like this, it's
always good to provide a cover letter:
`git format-patch -v2 --cover-letter ...`

> 04.07.2019 16:47, Andy Shevchenko wrote:
> > On Wed, Jul 3, 2019 at 6:41 PM <Nemcev_Aleksey@inbox.ru> wrote:
> >> From: Aleksey Nemcev <Nemcev_Aleksey@inbox.ru>
> >>
> >> This model has an AURA RGB backlight,
> >> so wmi_needs_3_args quirk is required
> > Thanks for the patch.
> > Though it does two logical things, i.e. new module support and new key bindings.
> > Please, split it to two changes and justify key bindings.
> >
> > P.S. To all your patches, please use punctuation, like period at the
> > end of sentences and so on.
> >
> >> Signed-off-by: Aleksey Nemcev <Nemcev_Aleksey@inbox.ru>
> >> ---
> >>   drivers/platform/x86/asus-nb-wmi.c | 12 ++++++++++++
> >>   1 file changed, 12 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> >> index 4bed95357a32..bf937321f42e 100644
> >> --- a/drivers/platform/x86/asus-nb-wmi.c
> >> +++ b/drivers/platform/x86/asus-nb-wmi.c
> >> @@ -406,6 +406,16 @@ static const struct dmi_system_id asus_quirks[] = {
> >>                  },
> >>                  .driver_data = &quirk_asus_forceals,
> >>          },
> >> +       {
> >> +               .callback = dmi_matched,
> >> +               .ident = "ASUSTeK COMPUTER INC. FX705GE",
> >> +               .matches = {
> >> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >> +                       DMI_MATCH(DMI_PRODUCT_NAME,
> >> +                                 "TUF Gaming FX705GE_FX705GE"),
> >> +               },
> >> +               .driver_data = &quirk_asus_wmi_needs_3_args,
> >> +       },
> >>          {},
> >>   };
> >>
> >> @@ -441,6 +451,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> >>          { KE_KEY, 0x30, { KEY_VOLUMEUP } },
> >>          { KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
> >>          { KE_KEY, 0x32, { KEY_MUTE } },
> >> +       { KE_KEY, 0x33, { KEY_BRIGHTNESS_MIN } },
> >>          { KE_KEY, 0x35, { KEY_SCREENLOCK } },
> >>          { KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
> >>          { KE_KEY, 0x41, { KEY_NEXTSONG } },
> >> @@ -467,6 +478,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> >>          { KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } },
> >>          { KE_IGNORE, 0x6E, },  /* Low Battery notification */
> >>          { KE_KEY, 0x7a, { KEY_ALS_TOGGLE } }, /* Ambient Light Sensor Toggle */
> >> +       { KE_KEY, 0x7C, { KEY_MICMUTE } },
> >>          { KE_KEY, 0x7D, { KEY_BLUETOOTH } }, /* Bluetooth Enable */
> >>          { KE_KEY, 0x7E, { KEY_BLUETOOTH } }, /* Bluetooth Disable */
> >>          { KE_KEY, 0x82, { KEY_CAMERA } },
> >> --
> >> 2.20.1
> >>
> >
>
diff mbox series

Patch

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 4bed95357a32..bf937321f42e 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -406,6 +406,16 @@  static const struct dmi_system_id asus_quirks[] = {
 		},
 		.driver_data = &quirk_asus_forceals,
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. FX705GE",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME,
+				  "TUF Gaming FX705GE_FX705GE"),
+		},
+		.driver_data = &quirk_asus_wmi_needs_3_args,
+	},
 	{},
 };
 
@@ -441,6 +451,7 @@  static const struct key_entry asus_nb_wmi_keymap[] = {
 	{ KE_KEY, 0x30, { KEY_VOLUMEUP } },
 	{ KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
 	{ KE_KEY, 0x32, { KEY_MUTE } },
+	{ KE_KEY, 0x33, { KEY_BRIGHTNESS_MIN } },
 	{ KE_KEY, 0x35, { KEY_SCREENLOCK } },
 	{ KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
 	{ KE_KEY, 0x41, { KEY_NEXTSONG } },
@@ -467,6 +478,7 @@  static const struct key_entry asus_nb_wmi_keymap[] = {
 	{ KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } },
 	{ KE_IGNORE, 0x6E, },  /* Low Battery notification */
 	{ KE_KEY, 0x7a, { KEY_ALS_TOGGLE } }, /* Ambient Light Sensor Toggle */
+	{ KE_KEY, 0x7C, { KEY_MICMUTE } },
 	{ KE_KEY, 0x7D, { KEY_BLUETOOTH } }, /* Bluetooth Enable */
 	{ KE_KEY, 0x7E, { KEY_BLUETOOTH } }, /* Bluetooth Disable */
 	{ KE_KEY, 0x82, { KEY_CAMERA } },