| Message ID | 20200420141054.26173-1-prarit@redhat.com (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
| Series | intel-speed-select: Fix speed-select-base-freq-properties output on CLX-N | expand |
On Mon, Apr 20, 2020 at 6:11 PM Prarit Bhargava <prarit@redhat.com> wrote: > > On CLX-N, the perf-profile-level's output is terminated before the > speed-select-base-freq-properties are output which results in a corrupt > json file. > > Adjust the output of speed-select-base-freq-properties by one on CLX-N. > Thanks for the patch, it will be pulled from Srinivas' tree whenever he sends a PR to PDx86 mailing list. > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: platform-driver-x86@vger.kernel.org > --- > tools/power/x86/intel-speed-select/isst-display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c > index 51dbaa5f02ec..f6e2ce181123 100644 > --- a/tools/power/x86/intel-speed-select/isst-display.c > +++ b/tools/power/x86/intel-speed-select/isst-display.c > @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level, > _isst_pbf_display_information(cpu, outf, > tdp_level, > &ctdp_level->pbf_info, > - level + 1); > + level + 2); > continue; > } > > -- > 2.18.2 >
On 4/20/20 11:43 AM, Andy Shevchenko wrote: > On Mon, Apr 20, 2020 at 6:11 PM Prarit Bhargava <prarit@redhat.com> wrote: >> >> On CLX-N, the perf-profile-level's output is terminated before the >> speed-select-base-freq-properties are output which results in a corrupt >> json file. >> >> Adjust the output of speed-select-base-freq-properties by one on CLX-N. >> > > Thanks for the patch, it will be pulled from Srinivas' tree whenever > he sends a PR to PDx86 mailing list. Srinivas, OOC do you want these patches to be sent somewhere else? FWIW, I'm running get_maintainers.pl to get the mailing list and cc. P. > > >> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> >> Cc: platform-driver-x86@vger.kernel.org >> --- >> tools/power/x86/intel-speed-select/isst-display.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c >> index 51dbaa5f02ec..f6e2ce181123 100644 >> --- a/tools/power/x86/intel-speed-select/isst-display.c >> +++ b/tools/power/x86/intel-speed-select/isst-display.c >> @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level, >> _isst_pbf_display_information(cpu, outf, >> tdp_level, >> &ctdp_level->pbf_info, >> - level + 1); >> + level + 2); >> continue; >> } >> >> -- >> 2.18.2 >> > >
On Mon, 2020-04-20 at 11:46 -0400, Prarit Bhargava wrote: > > On 4/20/20 11:43 AM, Andy Shevchenko wrote: > > On Mon, Apr 20, 2020 at 6:11 PM Prarit Bhargava <prarit@redhat.com> > > wrote: > > > On CLX-N, the perf-profile-level's output is terminated before > > > the > > > speed-select-base-freq-properties are output which results in a > > > corrupt > > > json file. > > > > > > Adjust the output of speed-select-base-freq-properties by one on > > > CLX-N. > > > > > > > Thanks for the patch, it will be pulled from Srinivas' tree > > whenever > > he sends a PR to PDx86 mailing list. > > Srinivas, OOC do you want these patches to be sent somewhere > else? FWIW, I'm > running get_maintainers.pl to get the mailing list and cc. This mailing list is fine. I will take care of it once I test it out an apply to my tree. Thanks, Srinivas > > P. > > > > > > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > > > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > > > Cc: platform-driver-x86@vger.kernel.org > > > --- > > > tools/power/x86/intel-speed-select/isst-display.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tools/power/x86/intel-speed-select/isst-display.c > > > b/tools/power/x86/intel-speed-select/isst-display.c > > > index 51dbaa5f02ec..f6e2ce181123 100644 > > > --- a/tools/power/x86/intel-speed-select/isst-display.c > > > +++ b/tools/power/x86/intel-speed-select/isst-display.c > > > @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, > > > FILE *outf, int tdp_level, > > > _isst_pbf_display_information(cpu > > > , outf, > > > tdp > > > _level, > > > &ctdp_l > > > evel->pbf_info, > > > - lev > > > el + 1); > > > + lev > > > el + 2); > > > continue; > > > } > > > > > > -- > > > 2.18.2 > > >
On Mon, 2020-04-20 at 10:10 -0400, Prarit Bhargava wrote: > On CLX-N, the perf-profile-level's output is terminated before the > speed-select-base-freq-properties are output which results in a > corrupt > json file. > > Adjust the output of speed-select-base-freq-properties by one on CLX- > N. Applied. Thanks, Srinivas > > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: platform-driver-x86@vger.kernel.org > --- > tools/power/x86/intel-speed-select/isst-display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/power/x86/intel-speed-select/isst-display.c > b/tools/power/x86/intel-speed-select/isst-display.c > index 51dbaa5f02ec..f6e2ce181123 100644 > --- a/tools/power/x86/intel-speed-select/isst-display.c > +++ b/tools/power/x86/intel-speed-select/isst-display.c > @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE > *outf, int tdp_level, > _isst_pbf_display_information(cpu, > outf, > tdp_level > , > &ctdp_level- > >pbf_info, > - level + > 1); > + level + > 2); > continue; > } >
diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c index 51dbaa5f02ec..f6e2ce181123 100644 --- a/tools/power/x86/intel-speed-select/isst-display.c +++ b/tools/power/x86/intel-speed-select/isst-display.c @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level, _isst_pbf_display_information(cpu, outf, tdp_level, &ctdp_level->pbf_info, - level + 1); + level + 2); continue; }
On CLX-N, the perf-profile-level's output is terminated before the speed-select-base-freq-properties are output which results in a corrupt json file. Adjust the output of speed-select-base-freq-properties by one on CLX-N. Signed-off-by: Prarit Bhargava <prarit@redhat.com> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: platform-driver-x86@vger.kernel.org --- tools/power/x86/intel-speed-select/isst-display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)