| Message ID | 20200702085520.16901-1-aaron.ma@canonical.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid | expand |
On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma <aaron.ma@canonical.com> wrote: > > When _BCL invalid, disable thinkpad_acpi backlight brightness control. > > brightness_enable is already checked at the beginning, > Always print notice when enabled brightness control. Why? ... > + pr_notice("thinkpad_acpi native brightness control enabled\n"); 'notice' level is quite high, why do we spam users with this?
On 7/2/20 5:30 PM, Andy Shevchenko wrote: > On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma <aaron.ma@canonical.com> wrote: >> >> When _BCL invalid, disable thinkpad_acpi backlight brightness control. >> >> brightness_enable is already checked at the beginning, > >> Always print notice when enabled brightness control. > > Why? > Default brightness_enable = 2, so this message will always be printed as before Actually no change here. > ... > >> + pr_notice("thinkpad_acpi native brightness control enabled\n"); > > 'notice' level is quite high, why do we spam users with this? > Like above. Another reason is most thinkpads are using native gpu driver to control brightness, notice when thinkpad_acpi brightness is enabled. Aaron
On Thu, Jul 2, 2020 at 1:51 PM Aaron Ma <aaron.ma@canonical.com> wrote: > On 7/2/20 5:30 PM, Andy Shevchenko wrote: > > On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma <aaron.ma@canonical.com> wrote: > >> > >> When _BCL invalid, disable thinkpad_acpi backlight brightness control. > >> > >> brightness_enable is already checked at the beginning, > > > >> Always print notice when enabled brightness control. > > > > Why? > > > > Default brightness_enable = 2, so this message will always be printed as before > Actually no change here. > > > ... > > > >> + pr_notice("thinkpad_acpi native brightness control enabled\n"); > > > > 'notice' level is quite high, why do we spam users with this? > > > > Like above. > > Another reason is most thinkpads are using native gpu driver to control > brightness, notice when thinkpad_acpi brightness is enabled. So, based on the above, please elaborate and explain all this in the commit message of new version, thanks!
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index ff7f0a4f2475..a52d6d457d6c 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -6955,10 +6955,13 @@ static int __init brightness_init(struct ibm_init_struct *iibm) pr_warn("Cannot enable backlight brightness support, ACPI is already handling it. Refer to the acpi_backlight kernel parameter.\n"); return 1; } - } else if (tp_features.bright_acpimode && brightness_enable > 1) { - pr_notice("Standard ACPI backlight interface not available, thinkpad_acpi native brightness control enabled\n"); + } else if (!tp_features.bright_acpimode) { + pr_notice("thinkpad_acpi backlight interface not available\n"); + return 1; } + pr_notice("thinkpad_acpi native brightness control enabled\n"); + /* * Check for module parameter bogosity, note that we * init brightness_mode to TPACPI_BRGHT_MODE_MAX in order to be
When _BCL invalid, disable thinkpad_acpi backlight brightness control. brightness_enable is already checked at the beginning, Always print notice when enabled brightness control. Signed-off-by: Aaron Ma <aaron.ma@canonical.com> --- drivers/platform/x86/thinkpad_acpi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)