| Message ID | 20200702110740.19880-1-aaron.ma@canonical.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid | expand |
On Thu, Jul 2, 2020 at 2:07 PM Aaron Ma <aaron.ma@canonical.com> wrote: > > When _BCL invalid, disable thinkpad_acpi backlight brightness control. > > brightness_enable is already checked at the beginning. > Most new thinkpads are using GPU driver to control brightness now, > print notice when enabled brightness control even when brightness_enable = 1. > + } else if (!tp_features.bright_acpimode) { > + pr_notice("thinkpad_acpi backlight interface not available\n"); > + return 1; > } > > + pr_notice("thinkpad_acpi native brightness control enabled\n"); In both cases don't you see the duplication of module name in the messages?
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index ff7f0a4f2475..a52d6d457d6c 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -6955,10 +6955,13 @@ static int __init brightness_init(struct ibm_init_struct *iibm) pr_warn("Cannot enable backlight brightness support, ACPI is already handling it. Refer to the acpi_backlight kernel parameter.\n"); return 1; } - } else if (tp_features.bright_acpimode && brightness_enable > 1) { - pr_notice("Standard ACPI backlight interface not available, thinkpad_acpi native brightness control enabled\n"); + } else if (!tp_features.bright_acpimode) { + pr_notice("thinkpad_acpi backlight interface not available\n"); + return 1; } + pr_notice("thinkpad_acpi native brightness control enabled\n"); + /* * Check for module parameter bogosity, note that we * init brightness_mode to TPACPI_BRGHT_MODE_MAX in order to be
When _BCL invalid, disable thinkpad_acpi backlight brightness control. brightness_enable is already checked at the beginning. Most new thinkpads are using GPU driver to control brightness now, print notice when enabled brightness control even when brightness_enable = 1. Signed-off-by: Aaron Ma <aaron.ma@canonical.com> --- drivers/platform/x86/thinkpad_acpi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)