| Message ID | 20200802041705.79870-1-zappel@retarded.farm (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | [v5] asus-nb-wmi: add support for ASUS ROG Zephyrus G14 (GA401) and G15 (GA502) | expand |
On Sun, Aug 2, 2020 at 7:17 AM Armas Spann <zappel@retarded.farm> wrote: > > Drop extra blank line(s) here. > This patch adds the ASUS ROG Zephyrus G14/15 notebook series detection to Read the Submitting Patches section about "This patch" and fix text accordingly. > asus-nb-wmi. The detection itself is accomplished by adding two new quirk_entry > structs (one for each series), as well as all current available G401/G502 > DMI_PRODUCT_NAMES to match the corresponding devices. > patch-changelog: > v1: initial G401 patches > v2: -- > v3: re-initial GA401 and GA502 and setting description > v4: corrected typo(s) added GA502DU series > v5: corrected signed-off position in patch - sorry This must go after the cutter '---' line below. > Signed-off-by: Armas Spann <zappel@retarded.farm> > --- ... > +static struct quirk_entry quirk_asus_ga401 = { > + .wmi_backlight_power = true, > + .wmi_backlight_set_devstate = true, > +}; > + > +static struct quirk_entry quirk_asus_ga502 = { > + .wmi_backlight_power = true, > + .wmi_backlight_set_devstate = true, > +}; These are identical. What is the point? P.S. Have you based your stuff on our for-next branch [1]? [1]: http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/for-next
Yeah sorry.. just recognized that I totally messed it up. (first issue, I was on the wrong branch/repo, second you're totally right with the two structs, one is way better - like it's implemented now.) I just recognized that it is fixed in the "for-next" branch with slightly adjusted fixes you applied. Many thanks. So, please just ignore the last requests from me. I'll take care the next time when doing a submit, to crosscheck everything more then once. (I've now a checklist for that purpose ^^) Best regards, Armas Am Sonntag, den 02.08.2020, 13:59 +0300 schrieb Andy Shevchenko: > On Sun, Aug 2, 2020 at 7:17 AM Armas Spann < > zappel@retarded.farm > > wrote: > > > > Drop extra blank line(s) here. > > > This patch adds the ASUS ROG Zephyrus G14/15 notebook series detection to > > Read the Submitting Patches section about "This patch" and fix text > accordingly. > > > asus-nb-wmi. The detection itself is accomplished by adding two new > > quirk_entry > > structs (one for each series), as well as all current available G401/G502 > > DMI_PRODUCT_NAMES to match the corresponding devices. > > patch-changelog: > > v1: initial G401 patches > > v2: -- > > v3: re-initial GA401 and GA502 and setting description > > v4: corrected typo(s) added GA502DU series > > v5: corrected signed-off position in patch - sorry > > This must go after the cutter '---' line below. > > > Signed-off-by: Armas Spann < > > zappel@retarded.farm > > > > > --- > > ... > > > +static struct quirk_entry quirk_asus_ga401 = { > > + .wmi_backlight_power = true, > > + .wmi_backlight_set_devstate = true, > > +}; > > + > > +static struct quirk_entry quirk_asus_ga502 = { > > + .wmi_backlight_power = true, > > + .wmi_backlight_set_devstate = true, > > +}; > > These are identical. What is the point? > > > P.S. Have you based your stuff on our for-next branch [1]? > > [1]: > http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/for-next > > >
On Mon, Aug 3, 2020 at 2:55 PM Armas Spann <zappel@retarded.farm> wrote: > Yeah sorry.. NP. > > just recognized that I totally messed it up. (first issue, I was on the wrong > branch/repo, second you're totally right with the two structs, one is way better > - like it's implemented now.) > > I just recognized that it is fixed in the "for-next" branch with slightly > adjusted fixes you applied. Many thanks. > > So, please just ignore the last requests from me. I'll take care the next time > when doing a submit, to crosscheck everything more then once. (I've now a > checklist for that purpose ^^) Do you think we need to expand / update checklist [1] in kernel documentation? [1]: https://www.kernel.org/doc/html/latest/process/submit-checklist.html
Hi, I think I missed that checklist.. But what I was looking for was some kind of a "quick"-list, like that one you send me some weeks ago. (howto use git to send those emails, for example) For a newcomer like me in this process, it's hard to sort out the right information and where to put description/changelog/etc. in the (git)patch itself. It might be helpful to have an example for a full git-driven patch (IMHO) - Yes of course I looked in to other submitted patches to get a clou. Because after reading all the kernel howtos to submit and participate, I felt more lost then before due to the informational overflow. And of course, that I screwed up the branch/repo in my last patches was totally my fault because I did not recognized that I need to checkout another repo and branch to get ontop of my/your previously applied patch in this case. Im very thankful for all the support you gave me, but I think I should have asked first, before submitting patches. ;) Best regards and thanks for your feedback, Armas Am Montag, den 03.08.2020, 16:00 +0300 schrieb Andy Shevchenko: > On Mon, Aug 3, 2020 at 2:55 PM Armas Spann < > zappel@retarded.farm > > wrote: > > Yeah sorry.. > > NP. > > > just recognized that I totally messed it up. (first issue, I was on the > > wrong > > branch/repo, second you're totally right with the two structs, one is way > > better > > - like it's implemented now.) > > > > I just recognized that it is fixed in the "for-next" branch with slightly > > adjusted fixes you applied. Many thanks. > > > > So, please just ignore the last requests from me. I'll take care the next > > time > > when doing a submit, to crosscheck everything more then once. (I've now a > > checklist for that purpose ^^) > > Do you think we need to expand / update checklist [1] in kernel documentation? > > [1]: > https://www.kernel.org/doc/html/latest/process/submit-checklist.html > > >
+Cc: Jonathan. (newbie's adventures below) On Mon, Aug 3, 2020 at 7:39 PM Armas Spann <zappel@retarded.farm> wrote: > I think I missed that checklist.. But what I was looking for was some kind of a > "quick"-list, like that one you send me some weeks ago. (howto use git to send > those emails, for example) > > For a newcomer like me in this process, it's hard to sort out the right > information and where to put description/changelog/etc. in the (git)patch > itself. It might be helpful to have an example for a full git-driven patch > (IMHO) - Yes of course I looked in to other submitted patches to get a clou. > Because after reading all the kernel howtos to submit and participate, I felt > more lost then before due to the informational overflow. > > And of course, that I screwed up the branch/repo in my last patches was totally > my fault because I did not recognized that I need to checkout another repo and > branch to get ontop of my/your previously applied patch in this case. > > > Im very thankful for all the support you gave me, but I think I should have > asked first, before submitting patches. ;) But your evaluation of [1] will be quite helpful exactly b/c you are a newbie! Maybe you can read it again and propose changes that will help people like you now (I believe you will learn things fast) to be not lost on the first steps? > Best regards and thanks for your feedback, > Armas Please, avoid top postings in the future. It's not welcome by the community. ... > > Do you think we need to expand / update checklist [1] in kernel documentation? > > > > [1]: > > https://www.kernel.org/doc/html/latest/process/submit-checklist.html
Am Montag, den 03.08.2020, 19:47 +0300 schrieb Andy Shevchenko: > +Cc: Jonathan. > (newbie's adventures below) > > On Mon, Aug 3, 2020 at 7:39 PM Armas Spann < > zappel@retarded.farm > > wrote: > > > I think I missed that checklist.. But what I was looking for was some kind > > of a > > "quick"-list, like that one you send me some weeks ago. (howto use git to > > send > > those emails, for example) > > > > For a newcomer like me in this process, it's hard to sort out the right > > information and where to put description/changelog/etc. in the (git)patch > > itself. It might be helpful to have an example for a full git-driven patch > > (IMHO) - Yes of course I looked in to other submitted patches to get a clou. > > Because after reading all the kernel howtos to submit and participate, I > > felt > > more lost then before due to the informational overflow. > > > > And of course, that I screwed up the branch/repo in my last patches was > > totally > > my fault because I did not recognized that I need to checkout another repo > > and > > branch to get ontop of my/your previously applied patch in this case. > > > > > > Im very thankful for all the support you gave me, but I think I should have > > asked first, before submitting patches. ;) > > But your evaluation of [1] will be quite helpful exactly b/c you are a newbie! > Maybe you can read it again and propose changes that will help people > like you now (I believe you will learn things fast) to be not lost on > the first steps? > > > Best regards and thanks for your feedback, > > Armas > > Please, avoid top postings in the future. It's not welcome by the community. > > ... > > > > Do you think we need to expand / update checklist [1] in kernel > > > documentation? > > > > > > [1]: > > > https://www.kernel.org/doc/html/latest/process/submit-checklist.html > > > > > Got it. (Today I'm learning howto write an email - really feeling like a noob now) - just changed my mailer settings to answer below. To answer your question about [1]: That checklist is pretty streight forward and understandable, my problem was more the linked https://www.kernel.org/doc/html/latest/process/submitting-patches.html#submittingpatches documentation. Which especially confuses me reading the "changlog" sections. It's not clear (to me at least) where to put which changelog. I know the default changelog is what a patch changes and that should go directly under the subject. But the internal (patch related) changelog was totally unclear. As well as this documentation is missing the git send-email thingy you pointed me to (its only mentioned once within '#explicit-in-reply-to-headers'). Best regards, Armas
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 8c4d00482ef0..1b85cd8433aa 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform/x86/asus-nb-wmi.c @@ -110,6 +110,16 @@ static struct quirk_entry quirk_asus_forceals = { .wmi_force_als_set = true, }; +static struct quirk_entry quirk_asus_ga401 = { + .wmi_backlight_power = true, + .wmi_backlight_set_devstate = true, +}; + +static struct quirk_entry quirk_asus_ga502 = { + .wmi_backlight_power = true, + .wmi_backlight_set_devstate = true, +}; + static int dmi_matched(const struct dmi_system_id *dmi) { pr_info("Identified laptop model '%s'\n", dmi->ident); @@ -411,6 +421,87 @@ static const struct dmi_system_id asus_quirks[] = { }, .driver_data = &quirk_asus_forceals, }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA401IH", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IH"), + }, + .driver_data = &quirk_asus_ga401, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA401II", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401II"), + }, + .driver_data = &quirk_asus_ga401, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA401IU", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IU"), + }, + .driver_data = &quirk_asus_ga401, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA401IV", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IV"), + }, + .driver_data = &quirk_asus_ga401, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA401IVC", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IVC"), + }, + .driver_data = &quirk_asus_ga401, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA502II", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA502II"), + }, + .driver_data = &quirk_asus_ga502, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA502IU", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA502IU"), + }, + .driver_data = &quirk_asus_ga502, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA502IV", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA502IV"), + }, + .driver_data = &quirk_asus_ga502, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. GA502DU", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA502DU"), + }, + .driver_data = &quirk_asus_ga502, + }, {}, };
This patch adds the ASUS ROG Zephyrus G14/15 notebook series detection to asus-nb-wmi. The detection itself is accomplished by adding two new quirk_entry structs (one for each series), as well as all current available G401/G502 DMI_PRODUCT_NAMES to match the corresponding devices. patch-changelog: v1: initial G401 patches v2: -- v3: re-initial GA401 and GA502 and setting description v4: corrected typo(s) added GA502DU series v5: corrected signed-off position in patch - sorry Signed-off-by: Armas Spann <zappel@retarded.farm> --- drivers/platform/x86/asus-nb-wmi.c | 91 ++++++++++++++++++++++++++++++ 1 file changed, 91 insertions(+)