diff mbox series

[platform-next,4/5] platform_data/mlxreg: Extend core platform structure

Message ID 20200923172053.26296-5-vadimp@nvidia.com (mailing list archive)
State Accepted, archived
Headers show
Series platform/x86: mlx-platform: Topology fixes and configuration updates | expand

Commit Message

Vadim Pasternak Sept. 23, 2020, 5:20 p.m. UTC
Add 'capability' field to structure 'mlxreg_core_platform_data'.
The purpose of this filed to indicate  the actual number of the
components within the particular group. Such components could be,
for example the number of the FAN drawers. Some systems are equipped
with FAN drawers with one tachometer inside, others with FAN drawers
with several tachometers inside.

Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
 include/linux/platform_data/mlxreg.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Hans de Goede Sept. 24, 2020, 8:36 a.m. UTC | #1
Hi,

On 9/23/20 7:20 PM, Vadim Pasternak wrote:
> Add 'capability' field to structure 'mlxreg_core_platform_data'.
> The purpose of this filed to indicate  the actual number of the
> components within the particular group. Such components could be,
> for example the number of the FAN drawers. Some systems are equipped
> with FAN drawers with one tachometer inside, others with FAN drawers
> with several tachometers inside.
> 
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>   include/linux/platform_data/mlxreg.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/platform_data/mlxreg.h b/include/linux/platform_data/mlxreg.h
> index 0a727d405a7a..101333fe2b8d 100644
> --- a/include/linux/platform_data/mlxreg.h
> +++ b/include/linux/platform_data/mlxreg.h
> @@ -109,6 +109,7 @@ struct mlxreg_core_item {
>    * @features: supported features of device;
>    * @version: implementation version;
>    * @identity: device identity name;
> + * @capability: device capability register;
>    */
>   struct mlxreg_core_platform_data {
>   	struct mlxreg_core_data *data;
> @@ -117,6 +118,7 @@ struct mlxreg_core_platform_data {
>   	u32 features;
>   	u32 version;
>   	char identity[MLXREG_CORE_LABEL_MAX_SIZE];
> +	u32 capability;
>   };
>   
>   /**
>
diff mbox series

Patch

diff --git a/include/linux/platform_data/mlxreg.h b/include/linux/platform_data/mlxreg.h
index 0a727d405a7a..101333fe2b8d 100644
--- a/include/linux/platform_data/mlxreg.h
+++ b/include/linux/platform_data/mlxreg.h
@@ -109,6 +109,7 @@  struct mlxreg_core_item {
  * @features: supported features of device;
  * @version: implementation version;
  * @identity: device identity name;
+ * @capability: device capability register;
  */
 struct mlxreg_core_platform_data {
 	struct mlxreg_core_data *data;
@@ -117,6 +118,7 @@  struct mlxreg_core_platform_data {
 	u32 features;
 	u32 version;
 	char identity[MLXREG_CORE_LABEL_MAX_SIZE];
+	u32 capability;
 };
 
 /**