diff mbox series

[platform-next,5/5] platform/x86: mlx-platform: Add capability field to platform FAN description

Message ID 20200923172053.26296-6-vadimp@nvidia.com (mailing list archive)
State Accepted, archived
Headers show
Series platform/x86: mlx-platform: Topology fixes and configuration updates | expand

Commit Message

Vadim Pasternak Sept. 23, 2020, 5:20 p.m. UTC
Set 'capability' field to FAN core platform data..
The content of 'capability' register allows to set the mapping between
the drawers and tachometers.
The motivation is to avoid adding a new code in the future in order to
distinct between the systems types supporting a different kinds of the
FAN drawers.

Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
 drivers/platform/x86/mlx-platform.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Hans de Goede Sept. 24, 2020, 8:36 a.m. UTC | #1
Hi,

On 9/23/20 7:20 PM, Vadim Pasternak wrote:
> Set 'capability' field to FAN core platform data..
> The content of 'capability' register allows to set the mapping between
> the drawers and tachometers.
> The motivation is to avoid adding a new code in the future in order to
> distinct between the systems types supporting a different kinds of the
> FAN drawers.
> 
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans




> ---
>   drivers/platform/x86/mlx-platform.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
> index 04a745095c37..986ad3dda1c1 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -1939,6 +1939,7 @@ static struct mlxreg_core_data mlxplat_mlxcpld_default_fan_data[] = {
>   static struct mlxreg_core_platform_data mlxplat_default_fan_data = {
>   		.data = mlxplat_mlxcpld_default_fan_data,
>   		.counter = ARRAY_SIZE(mlxplat_mlxcpld_default_fan_data),
> +		.capability = MLXPLAT_CPLD_LPC_REG_FAN_DRW_CAP_OFFSET,
>   };
>   
>   /* Watchdog type1: hardware implementation version1
>
diff mbox series

Patch

diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 04a745095c37..986ad3dda1c1 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -1939,6 +1939,7 @@  static struct mlxreg_core_data mlxplat_mlxcpld_default_fan_data[] = {
 static struct mlxreg_core_platform_data mlxplat_default_fan_data = {
 		.data = mlxplat_mlxcpld_default_fan_data,
 		.counter = ARRAY_SIZE(mlxplat_mlxcpld_default_fan_data),
+		.capability = MLXPLAT_CPLD_LPC_REG_FAN_DRW_CAP_OFFSET,
 };
 
 /* Watchdog type1: hardware implementation version1