From patchwork Tue Oct 20 00:15:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Pearson X-Patchwork-Id: 11845513 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 93EAE14B2 for ; Tue, 20 Oct 2020 00:16:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F35522400 for ; Tue, 20 Oct 2020 00:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389314AbgJTAQg (ORCPT ); Mon, 19 Oct 2020 20:16:36 -0400 Received: from mail1.bemta24.messagelabs.com ([67.219.250.3]:13188 "EHLO mail1.bemta24.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727220AbgJTAQf (ORCPT ); Mon, 19 Oct 2020 20:16:35 -0400 Received: from [100.112.128.224] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-3.bemta.az-a.us-west-2.aws.symcld.net id 3A/2A-11747-16C2E8F5; Tue, 20 Oct 2020 00:16:33 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRWlGSWpSXmKPExsWSLveKTTdRpy/ eYN4+YYtD5w4wWxxe9ILR4uu32+wWb45PZ7I4c3shk8XNT99YLVbvecHswO4xq6GXzWPnrLvs Hr+2rWHxWH5wGpPH+31X2Tw+b5ILYItizcxLyq9IYM04Of0be8EuhYr7938zNjD+ku5i5OIQE vjPKDHvzlZmCOcNo8SsWUuBHE4ONgFtiS1bfrF1MXJwiAjISHxY6wlSwyxwm1Hi+a4GNpAaYY FwiYbHW1lBbBYBVYkZC1rZQWxeARuJxZ3/mEBsCQF5iae9y5lB5nAK2Ep8WOwNEhYSCJM4fuQ +VLmgxMmZT1hAbGag8uats5khbAmJgy9eMEOMUZB4O/c+G4SdILHs5R3mCYwCs5C0z0LSPgtJ +wJG5lWM5klFmekZJbmJmTm6hgYGuoaGRrqGxga6JkZ6iVW6iXqlxbrlqcUlukBuebFecWVuc k6KXl5qySZGYKSkFDRp7WB89fqD3iFGSQ4mJVHeLep98UJ8SfkplRmJxRnxRaU5qcWHGGU4OJ QkeKW1gXKCRanpqRVpmTnAqIVJS3DwKInw5mgBpXmLCxJzizPTIVKnGBWlxHn9QfoEQBIZpXl wbbBEcYlRVkqYl5GBgUGIpyC1KDezBFX+FaM4B6OSMO9xkPE8mXklcNNfAS1mAlps298Dsrgk ESEl1cDk19i/P+TVnvSJqw8z53kevMDxIdV31nwz56pHErGfnmZWW7x7MOmEyDNb6/6bV6aE7 +G0OBvRc+P82WNXOWdZFrht+pWgv69ee8eCJe/PGm5/c+2k/1ODLyut76ks9dKJ7Ux91BNqee jEieyAmOjUCMs7d/0kH7+ds9XsrlS/ScC/dqd13bNLRQW/RC8uKzE5LiYwWX3tQk2P2x/cw85 cPvQjuqinKdo/6WheT71QZliD2pV5H5rlYg0LPF/pvX5RdLzwQijfhaaImLvT98hNDph7SZz5 jrnzug/F50uWbr513M1hfY/ykQP/tafGz7QL2sH78oS3wo6oVWtucW6v7nF5ZPPd7/TiSJ+95 04sVGIpzkg01GIuKk4EAAzacTOPAwAA X-Env-Sender: markpearson@lenovo.com X-Msg-Ref: server-15.tower-326.messagelabs.com!1603152991!35623!1 X-Originating-IP: [103.30.234.6] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.60.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 9420 invoked from network); 20 Oct 2020 00:16:33 -0000 Received: from unknown (HELO lenovo.com) (103.30.234.6) by server-15.tower-326.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 20 Oct 2020 00:16:33 -0000 Received: from reswpmail04.lenovo.com (unknown [10.62.32.23]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by Forcepoint Email with ESMTPS id 4ACE72EBD72DE1C2A7D1; Tue, 20 Oct 2020 08:16:29 +0800 (CST) Received: from localhost.localdomain.com (10.64.93.219) by reswpmail04.lenovo.com (10.62.32.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2044.4; Mon, 19 Oct 2020 17:16:25 -0700 From: Mark Pearson To: CC: , , , , , , , Subject: [PATCH v2 2/3] platform/x86: thinkpad_acpi: Add support for Lenovo palm sensor Date: Mon, 19 Oct 2020 20:15:55 -0400 Message-ID: <20201020001556.388099-2-markpearson@lenovo.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201020001556.388099-1-markpearson@lenovo.com> References: <20201020001556.388099-1-markpearson@lenovo.com> MIME-Version: 1.0 X-Originating-IP: [10.64.93.219] X-ClientProxiedBy: reswpmail04.lenovo.com (10.62.32.23) To reswpmail04.lenovo.com (10.62.32.23) Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Use input device event support for notifying userspace of palm sensor state changes Signed-off-by: Mark Pearson --- drivers/platform/x86/thinkpad_acpi.c | 99 +++++++++++++++++++++++++++- 1 file changed, 97 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index eae3579f106f..5ddf2775fb06 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -4013,6 +4013,7 @@ static bool hotkey_notify_usrevent(const u32 hkey, } static void thermal_dump_all_sensors(void); +static void proxsensor_refresh(void); static bool hotkey_notify_6xxx(const u32 hkey, bool *send_acpi_ev, @@ -4079,8 +4080,8 @@ static bool hotkey_notify_6xxx(const u32 hkey, case TP_HKEY_EV_PALM_DETECTED: case TP_HKEY_EV_PALM_UNDETECTED: - /* palm detected hovering the keyboard, forward to user-space - * via netlink for consumption */ + /* palm detected - pass on to event handler */ + proxsensor_refresh(); return true; default: @@ -9918,6 +9919,96 @@ static struct ibm_struct dytc_driver_data = { .exit = dytc_exit, }; +/************************************************************************* + * Proximity sensor subdriver + */ + +#define PALMSENSOR_PRESENT_BIT 0 /* Determine if psensor present */ +#define PALMSENSOR_ON_BIT 1 /* psensor status */ + +struct input_dev *tpacpi_sw_dev; +bool has_palmsensor; +bool palmsensor_state; + +static int palmsensor_get(bool *present, bool *state) +{ + acpi_handle psensor_handle; + int output; + + if (ACPI_FAILURE(acpi_get_handle(hkey_handle, "GPSS", &psensor_handle))) + return -ENODEV; + if (!acpi_evalf(psensor_handle, &output, NULL, "d")) + return -EIO; + + *present = output & BIT(PALMSENSOR_PRESENT_BIT) ? true : false; + *state = output & BIT(PALMSENSOR_ON_BIT) ? true : false; + return 0; +} + +static void proxsensor_refresh(void) +{ + bool new_state; + int err; + + if (has_palmsensor) { + err = palmsensor_get(&has_palmsensor, &new_state); + if (err) + return; + if (new_state != palmsensor_state) { + input_report_switch(tpacpi_sw_dev, SW_PALMREST_PROXIMITY, new_state); + input_sync(tpacpi_sw_dev); + palmsensor_state = new_state; + } + } +} + +static int tpacpi_proxsensor_init(struct ibm_init_struct *iibm) +{ + int palm_err; + + palm_err = palmsensor_get(&has_palmsensor, &palmsensor_state); + /* If support isn't available (ENODEV) then don't return an error */ + if (palm_err == -ENODEV) + return 0; + /* For all other errors we can flag the failure */ + if (palm_err) + return palm_err; + + if (has_palmsensor) { + tpacpi_sw_dev = input_allocate_device(); + if (!tpacpi_sw_dev) + return -ENOMEM; + tpacpi_sw_dev->name = "Thinkpad proximity switches"; + tpacpi_sw_dev->phys = TPACPI_DRVR_NAME "/input1"; + tpacpi_sw_dev->id.bustype = BUS_HOST; + tpacpi_sw_dev->id.vendor = thinkpad_id.vendor; + tpacpi_sw_dev->id.product = TPACPI_HKEY_INPUT_PRODUCT; + tpacpi_sw_dev->id.version = TPACPI_HKEY_INPUT_VERSION; + tpacpi_sw_dev->dev.parent = &tpacpi_pdev->dev; + + if (has_palmsensor) { + input_set_capability(tpacpi_sw_dev, EV_SW, SW_PALMREST_PROXIMITY); + input_report_switch(tpacpi_sw_dev, SW_PALMREST_PROXIMITY, palmsensor_state); + } + palm_err = input_register_device(tpacpi_sw_dev); + if (palm_err) { + input_free_device(tpacpi_sw_dev); + return palm_err; + } + } + return 0; +} + +static void proxsensor_exit(void) +{ + input_unregister_device(tpacpi_sw_dev); + input_free_device(tpacpi_sw_dev); +} + +static struct ibm_struct proxsensor_driver_data = { + .name = "proximity-sensor", + .exit = proxsensor_exit, +}; /**************************************************************************** **************************************************************************** * @@ -10411,6 +10502,10 @@ static struct ibm_init_struct ibms_init[] __initdata = { .init = tpacpi_dytc_init, .data = &dytc_driver_data, }, + { + .init = tpacpi_proxsensor_init, + .data = &proxsensor_driver_data, + }, }; static int __init set_ibm_param(const char *val, const struct kernel_param *kp)