From patchwork Tue Nov 24 08:53:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 11927451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9583FC2D0E4 for ; Tue, 24 Nov 2020 08:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B9E82076B for ; Tue, 24 Nov 2020 08:53:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rOzJh8nP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730850AbgKXIxt (ORCPT ); Tue, 24 Nov 2020 03:53:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730822AbgKXIxt (ORCPT ); Tue, 24 Nov 2020 03:53:49 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6CEEC0613D6 for ; Tue, 24 Nov 2020 00:53:48 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id d20so11868323lfe.11 for ; Tue, 24 Nov 2020 00:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I2EmMJdusVtGBiOPmuBxSa/yxYa7w9wcih2XFbyqoVY=; b=rOzJh8nPd2bJlYYIp0tDoZzNyjPr5hO/eDo/Gh+AvBKrZrzR+183SDLWaAk0dJ7hFo 1XXVL6v2oqETnYO5PN08RGGTgBuO62/uhT5dul1SzQyaLnhG5AsbPr39C0BFzdtZVjZU 9BlFgQnPDjog6o3bsOyDz1jCv7tVFXBo6rH1r8DCcQpJ/U3C21DApr5nFtb5b4M8Gc2b dpgkzBgud5+0VcsQGQet0gxaydahKPy8LaKi+2Xe8yagBokZZGv3RCBdHInvPxvF2z1b 62aWqiOofiyEpQ/mjm6RKZ4gjDe7KzVNLYKPOUAmSVp/v89TFY3z1M90E0s3+4Gymvyw SvUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I2EmMJdusVtGBiOPmuBxSa/yxYa7w9wcih2XFbyqoVY=; b=NtrhA9bVLmzzEYmZiBIUV6FvCzgEbPgGOjdM/mzuhltxj3HnHEV6r0uAebGcklgjM2 yPRoSpj1RHZ20/fZLu5Mb8+w091pxt+pmWCSKOgAcbqjaSVPiMFnaPY54IDT1F42LUu2 MOlyMRGzSCBazINsdbnBO6e+vEFbb5Dow0KgJP2BCjRWG97iwuOMBW3PnmSVOTPeaHvs Md4YPpglkFZC5i27nxlO4/Gmfq4SANC9lSOSDt/vIKU4P9pkctTGxzOZxBm70UoBpvjp sl1VwE2wJFs6pl4lS/+6dp33qjkAHuFPdBRfMzw1dMHuUTlK/BIkGgGo9E17UgSBjVsU M5gA== X-Gm-Message-State: AOAM530iwfl+EFHKEs3zyVfjx6GvkymX65ci2igsz5+SmW+Ib0HedV9n nBIAS3d2IQGCywWSpVoUiFlWR3SFULYeLQMH X-Google-Smtp-Source: ABdhPJxN36mZJwr2I4WhAVdmjPjYGdiZL3k+HSgPk49TyYEn2UM6QXQuYjWmX1ZrN+G7vHLl2JGrrQ== X-Received: by 2002:a19:6914:: with SMTP id e20mr1171533lfc.506.1606208027340; Tue, 24 Nov 2020 00:53:47 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id u18sm746602lfq.145.2020.11.24.00.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 00:53:46 -0800 (PST) From: Linus Walleij To: Hans de Goede , Mark Gross Cc: platform-driver-x86@vger.kernel.org, Linus Walleij , linux-gpio@vger.kernel.org, Andres Salomon , linux-geode@lists.infradead.org, Darren Hart , x86@kernel.org, Andy Shevchenko Subject: [PATCH 1/3 v4] x86/platform/geode: Convert net5501 LED to GPIO machine descriptor Date: Tue, 24 Nov 2020 09:53:37 +0100 Message-Id: <20201124085339.6181-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org This makes the machine look up the LED from a GPIO machine descriptor table. The Geode LEDs should be on the CS5535 companion chip. Cc: linux-gpio@vger.kernel.org Cc: Andres Salomon Cc: linux-geode@lists.infradead.org Cc: Darren Hart Cc: platform-driver-x86@vger.kernel.org Cc: x86@kernel.org Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Signed-off-by: Linus Walleij --- ChangeLog v3->v4: - Cc x86@kernel.org - Collect Hans' Review tag. ChangeLog v2->v3: - Rebase on v5.10-rc1 - Resend ChangeLog v1->v2: - Drop excess comma after terminator { } - Collect Andy's Reviewed-by --- arch/x86/platform/geode/net5501.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c index 163e1b545517..558384acd777 100644 --- a/arch/x86/platform/geode/net5501.c +++ b/arch/x86/platform/geode/net5501.c @@ -20,6 +20,7 @@ #include #include #include +#include #include @@ -55,9 +56,7 @@ static struct platform_device net5501_buttons_dev = { static struct gpio_led net5501_leds[] = { { .name = "net5501:1", - .gpio = 6, .default_trigger = "default-on", - .active_low = 0, }, }; @@ -66,6 +65,15 @@ static struct gpio_led_platform_data net5501_leds_data = { .leds = net5501_leds, }; +static struct gpiod_lookup_table net5501_leds_gpio_table = { + .dev_id = "leds-gpio", + .table = { + /* The Geode GPIOs should be on the CS5535 companion chip */ + GPIO_LOOKUP_IDX("cs5535-gpio", 6, NULL, 0, GPIO_ACTIVE_HIGH), + { } + }, +}; + static struct platform_device net5501_leds_dev = { .name = "leds-gpio", .id = -1, @@ -80,6 +88,7 @@ static struct platform_device *net5501_devs[] __initdata = { static void __init register_net5501(void) { /* Setup LED control through leds-gpio driver */ + gpiod_add_lookup_table(&net5501_leds_gpio_table); platform_add_devices(net5501_devs, ARRAY_SIZE(net5501_devs)); }