| Message ID | 20201216133752.1321978-1-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/surface: SURFACE_PLATFORMS should depend on ACPI | expand |
Hi, On 12/16/20 2:37 PM, Geert Uytterhoeven wrote: > All Microsoft Surface platform-specific device drivers depend on ACPI, > but the gatekeeper symbol SURFACE_PLATFORMS does not. Hence when the > user is configuring a kernel without ACPI support, he is still asked > about Microsoft Surface drivers, even though this question is > irrelevant. > > Fix this by moving the dependency on ACPI from the individual driver > symbols to SURFACE_PLATFORMS. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Maximilian, can I have your ack or reviewed-by for this (assuming you agree with this change) ? Regards, Hans > --- > drivers/platform/surface/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/surface/Kconfig b/drivers/platform/surface/Kconfig > index 33040b0b3b799c2d..2c941cdac9eedc6f 100644 > --- a/drivers/platform/surface/Kconfig > +++ b/drivers/platform/surface/Kconfig > @@ -5,6 +5,7 @@ > > menuconfig SURFACE_PLATFORMS > bool "Microsoft Surface Platform-Specific Device Drivers" > + depends on ACPI > default y > help > Say Y here to get to see options for platform-specific device drivers > @@ -29,20 +30,19 @@ config SURFACE3_WMI > > config SURFACE_3_BUTTON > tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet" > - depends on ACPI && KEYBOARD_GPIO && I2C > + depends on KEYBOARD_GPIO && I2C > help > This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet. > > config SURFACE_3_POWER_OPREGION > tristate "Surface 3 battery platform operation region support" > - depends on ACPI && I2C > + depends on I2C > help > This driver provides support for ACPI operation > region of the Surface 3 battery platform driver. > > config SURFACE_GPE > tristate "Surface GPE/Lid Support Driver" > - depends on ACPI > depends on DMI > help > This driver marks the GPEs related to the ACPI lid device found on > @@ -52,7 +52,7 @@ config SURFACE_GPE > > config SURFACE_PRO3_BUTTON > tristate "Power/home/volume buttons driver for Microsoft Surface Pro 3/4 tablet" > - depends on ACPI && INPUT > + depends on INPUT > help > This driver handles the power/home/volume buttons on the Microsoft Surface Pro 3/4 tablet. > >
On 12/16/20 3:01 PM, Hans de Goede wrote: > Hi, > > On 12/16/20 2:37 PM, Geert Uytterhoeven wrote: >> All Microsoft Surface platform-specific device drivers depend on ACPI, >> but the gatekeeper symbol SURFACE_PLATFORMS does not. Hence when the >> user is configuring a kernel without ACPI support, he is still asked >> about Microsoft Surface drivers, even though this question is >> irrelevant. >> >> Fix this by moving the dependency on ACPI from the individual driver >> symbols to SURFACE_PLATFORMS. >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Thanks, patch looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > Maximilian, can I have your ack or reviewed-by for this > (assuming you agree with this change) ? Sure, looks good to me. Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> Regards, Max > > Regards, > > Hans > >> --- > > >> drivers/platform/surface/Kconfig | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/platform/surface/Kconfig b/drivers/platform/surface/Kconfig >> index 33040b0b3b799c2d..2c941cdac9eedc6f 100644 >> --- a/drivers/platform/surface/Kconfig >> +++ b/drivers/platform/surface/Kconfig >> @@ -5,6 +5,7 @@ >> >> menuconfig SURFACE_PLATFORMS >> bool "Microsoft Surface Platform-Specific Device Drivers" >> + depends on ACPI >> default y >> help >> Say Y here to get to see options for platform-specific device drivers >> @@ -29,20 +30,19 @@ config SURFACE3_WMI >> >> config SURFACE_3_BUTTON >> tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet" >> - depends on ACPI && KEYBOARD_GPIO && I2C >> + depends on KEYBOARD_GPIO && I2C >> help >> This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet. >> >> config SURFACE_3_POWER_OPREGION >> tristate "Surface 3 battery platform operation region support" >> - depends on ACPI && I2C >> + depends on I2C >> help >> This driver provides support for ACPI operation >> region of the Surface 3 battery platform driver. >> >> config SURFACE_GPE >> tristate "Surface GPE/Lid Support Driver" >> - depends on ACPI >> depends on DMI >> help >> This driver marks the GPEs related to the ACPI lid device found on >> @@ -52,7 +52,7 @@ config SURFACE_GPE >> >> config SURFACE_PRO3_BUTTON >> tristate "Power/home/volume buttons driver for Microsoft Surface Pro 3/4 tablet" >> - depends on ACPI && INPUT >> + depends on INPUT >> help >> This driver handles the power/home/volume buttons on the Microsoft Surface Pro 3/4 tablet. >> >> >
Hi, On 12/16/20 2:37 PM, Geert Uytterhoeven wrote: > All Microsoft Surface platform-specific device drivers depend on ACPI, > but the gatekeeper symbol SURFACE_PLATFORMS does not. Hence when the > user is configuring a kernel without ACPI support, he is still asked > about Microsoft Surface drivers, even though this question is > irrelevant. > > Fix this by moving the dependency on ACPI from the individual driver > symbols to SURFACE_PLATFORMS. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/surface/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/surface/Kconfig b/drivers/platform/surface/Kconfig > index 33040b0b3b799c2d..2c941cdac9eedc6f 100644 > --- a/drivers/platform/surface/Kconfig > +++ b/drivers/platform/surface/Kconfig > @@ -5,6 +5,7 @@ > > menuconfig SURFACE_PLATFORMS > bool "Microsoft Surface Platform-Specific Device Drivers" > + depends on ACPI > default y > help > Say Y here to get to see options for platform-specific device drivers > @@ -29,20 +30,19 @@ config SURFACE3_WMI > > config SURFACE_3_BUTTON > tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet" > - depends on ACPI && KEYBOARD_GPIO && I2C > + depends on KEYBOARD_GPIO && I2C > help > This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet. > > config SURFACE_3_POWER_OPREGION > tristate "Surface 3 battery platform operation region support" > - depends on ACPI && I2C > + depends on I2C > help > This driver provides support for ACPI operation > region of the Surface 3 battery platform driver. > > config SURFACE_GPE > tristate "Surface GPE/Lid Support Driver" > - depends on ACPI > depends on DMI > help > This driver marks the GPEs related to the ACPI lid device found on > @@ -52,7 +52,7 @@ config SURFACE_GPE > > config SURFACE_PRO3_BUTTON > tristate "Power/home/volume buttons driver for Microsoft Surface Pro 3/4 tablet" > - depends on ACPI && INPUT > + depends on INPUT > help > This driver handles the power/home/volume buttons on the Microsoft Surface Pro 3/4 tablet. > >
diff --git a/drivers/platform/surface/Kconfig b/drivers/platform/surface/Kconfig index 33040b0b3b799c2d..2c941cdac9eedc6f 100644 --- a/drivers/platform/surface/Kconfig +++ b/drivers/platform/surface/Kconfig @@ -5,6 +5,7 @@ menuconfig SURFACE_PLATFORMS bool "Microsoft Surface Platform-Specific Device Drivers" + depends on ACPI default y help Say Y here to get to see options for platform-specific device drivers @@ -29,20 +30,19 @@ config SURFACE3_WMI config SURFACE_3_BUTTON tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet" - depends on ACPI && KEYBOARD_GPIO && I2C + depends on KEYBOARD_GPIO && I2C help This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet. config SURFACE_3_POWER_OPREGION tristate "Surface 3 battery platform operation region support" - depends on ACPI && I2C + depends on I2C help This driver provides support for ACPI operation region of the Surface 3 battery platform driver. config SURFACE_GPE tristate "Surface GPE/Lid Support Driver" - depends on ACPI depends on DMI help This driver marks the GPEs related to the ACPI lid device found on @@ -52,7 +52,7 @@ config SURFACE_GPE config SURFACE_PRO3_BUTTON tristate "Power/home/volume buttons driver for Microsoft Surface Pro 3/4 tablet" - depends on ACPI && INPUT + depends on INPUT help This driver handles the power/home/volume buttons on the Microsoft Surface Pro 3/4 tablet.
All Microsoft Surface platform-specific device drivers depend on ACPI, but the gatekeeper symbol SURFACE_PLATFORMS does not. Hence when the user is configuring a kernel without ACPI support, he is still asked about Microsoft Surface drivers, even though this question is irrelevant. Fix this by moving the dependency on ACPI from the individual driver symbols to SURFACE_PLATFORMS. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/platform/surface/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)