| Message ID | 20210113182016.166049-24-pobrn@protonmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | platform/x86: ideapad-laptop: cleanup, keyboard backlight and "always on USB charging" control support, reenable touchpad control | expand |
On Wed, Jan 13, 2021 at 8:25 PM Barnabás Pőcze <pobrn@protonmail.com> wrote: > > The documentation referred to non-existent device attributes under a non-existent > platform device. Update it with the current location of the attributes. Fixes tag, please?
Hi Thanks for the review. 2021. január 16., szombat 21:10 keltezéssel, Andy Shevchenko írta: > On Wed, Jan 13, 2021 at 8:25 PM Barnabás Pőcze wrote: > > > > The documentation referred to non-existent device attributes under a non-existent > > platform device. Update it with the current location of the attributes. > > Fixes tag, please? > I'm not sure which commit (if any) should be referenced. Do you think the patch that removed the platform device - hence making the documented paths incorrect - would be OK to reference here? Thanks, Barnabás Pőcze
On Sun, Jan 17, 2021 at 12:58 AM Barnabás Pőcze <pobrn@protonmail.com> wrote: > 2021. január 16., szombat 21:10 keltezéssel, Andy Shevchenko írta: > > On Wed, Jan 13, 2021 at 8:25 PM Barnabás Pőcze wrote: > > > The documentation referred to non-existent device attributes under a non-existent > > > platform device. Update it with the current location of the attributes. > > > > Fixes tag, please? > > > > I'm not sure which commit (if any) should be referenced. Do you think > the patch that removed the platform device - hence making the documented paths > incorrect - would be OK to reference here? From your description it looks like the right one, the general rule is to find a change after which this becomes broken / invalid.
diff --git a/Documentation/ABI/testing/sysfs-platform-ideapad-laptop b/Documentation/ABI/testing/sysfs-platform-ideapad-laptop index fd2ac02bc5bd..e024678947c8 100644 --- a/Documentation/ABI/testing/sysfs-platform-ideapad-laptop +++ b/Documentation/ABI/testing/sysfs-platform-ideapad-laptop @@ -1,11 +1,11 @@ -What: /sys/devices/platform/ideapad/camera_power +What: /sys/bus/platform/devices/VPC2004:*/camera_power Date: Dec 2010 KernelVersion: 2.6.37 Contact: "Ike Panhc <ike.pan@canonical.com>" Description: Control the power of camera module. 1 means on, 0 means off. -What: /sys/devices/platform/ideapad/fan_mode +What: /sys/bus/platform/devices/VPC2004:*/fan_mode Date: June 2012 KernelVersion: 3.6 Contact: "Maxim Mikityanskiy <maxtram95@gmail.com>" @@ -18,7 +18,7 @@ Description: * 2 -> Dust Cleaning * 4 -> Efficient Thermal Dissipation Mode -What: /sys/devices/platform/ideapad/touchpad +What: /sys/bus/platform/devices/VPC2004:*/touchpad Date: May 2017 KernelVersion: 4.13 Contact: "Ritesh Raj Sarraf <rrs@debian.org>" @@ -27,7 +27,7 @@ Description: * 1 -> Switched On * 0 -> Switched Off -What: /sys/bus/pci/devices/<bdf>/<device>/VPC2004:00/fn_lock +What: /sys/bus/platform/devices/VPC2004:*/fn_lock Date: May 2018 KernelVersion: 4.18 Contact: "Oleg Keri <ezhi99@gmail.com>"