| Message ID | 20210317024455.3071477-1-david.e.box@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] platform/x86: intel_pmt_class: Initial resource to 0 | expand |
On Tue, 2021-03-16 at 19:44 -0700, David E. Box wrote: > Initialize the struct resource in intel_pmt_dev_register to zero to > avoid a > fault should the char *name field be non-zero. Hi Hans. Can these 2 patches be pulled as fixes for 5.12? Thanks. David > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- > > Base commit is v5.12-rc3. > > drivers/platform/x86/intel_pmt_class.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_pmt_class.c > b/drivers/platform/x86/intel_pmt_class.c > index c8939fba4509..ee2b3bbeb83d 100644 > --- a/drivers/platform/x86/intel_pmt_class.c > +++ b/drivers/platform/x86/intel_pmt_class.c > @@ -173,7 +173,7 @@ static int intel_pmt_dev_register(struct > intel_pmt_entry *entry, > struct intel_pmt_namespace *ns, > struct device *parent) > { > - struct resource res; > + struct resource res = {0}; > struct device *dev; > int ret; > > > base-commit: 1e28eed17697bcf343c6743f0028cc3b5dd88bf0
Hi, On 3/17/21 3:44 AM, David E. Box wrote: > Initialize the struct resource in intel_pmt_dev_register to zero to avoid a > fault should the char *name field be non-zero. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > > Base commit is v5.12-rc3. > > drivers/platform/x86/intel_pmt_class.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_pmt_class.c b/drivers/platform/x86/intel_pmt_class.c > index c8939fba4509..ee2b3bbeb83d 100644 > --- a/drivers/platform/x86/intel_pmt_class.c > +++ b/drivers/platform/x86/intel_pmt_class.c > @@ -173,7 +173,7 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry, > struct intel_pmt_namespace *ns, > struct device *parent) > { > - struct resource res; > + struct resource res = {0}; > struct device *dev; > int ret; > > > base-commit: 1e28eed17697bcf343c6743f0028cc3b5dd88bf0 >
Hi, On 3/23/21 6:29 PM, David E. Box wrote: > On Tue, 2021-03-16 at 19:44 -0700, David E. Box wrote: >> Initialize the struct resource in intel_pmt_dev_register to zero to >> avoid a >> fault should the char *name field be non-zero. > > Hi Hans. Can these 2 patches be pulled as fixes for 5.12? Thanks. I've merged this into my review-hans branch now. I'll also them to my fixes branch and add them to my next pull-req to Linus for 5.12. Regards, Hans > David > >> >> Signed-off-by: David E. Box <david.e.box@linux.intel.com> >> --- >> >> Base commit is v5.12-rc3. >> >> drivers/platform/x86/intel_pmt_class.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/intel_pmt_class.c >> b/drivers/platform/x86/intel_pmt_class.c >> index c8939fba4509..ee2b3bbeb83d 100644 >> --- a/drivers/platform/x86/intel_pmt_class.c >> +++ b/drivers/platform/x86/intel_pmt_class.c >> @@ -173,7 +173,7 @@ static int intel_pmt_dev_register(struct >> intel_pmt_entry *entry, >> struct intel_pmt_namespace *ns, >> struct device *parent) >> { >> - struct resource res; >> + struct resource res = {0}; >> struct device *dev; >> int ret; >> >> >> base-commit: 1e28eed17697bcf343c6743f0028cc3b5dd88bf0 > >
diff --git a/drivers/platform/x86/intel_pmt_class.c b/drivers/platform/x86/intel_pmt_class.c index c8939fba4509..ee2b3bbeb83d 100644 --- a/drivers/platform/x86/intel_pmt_class.c +++ b/drivers/platform/x86/intel_pmt_class.c @@ -173,7 +173,7 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry, struct intel_pmt_namespace *ns, struct device *parent) { - struct resource res; + struct resource res = {0}; struct device *dev; int ret;
Initialize the struct resource in intel_pmt_dev_register to zero to avoid a fault should the char *name field be non-zero. Signed-off-by: David E. Box <david.e.box@linux.intel.com> --- Base commit is v5.12-rc3. drivers/platform/x86/intel_pmt_class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 1e28eed17697bcf343c6743f0028cc3b5dd88bf0