| Message ID | 20210325123255.73103-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: intel-vbtn: Remove unused KEYMAP_LEN define | expand |
On Thu, Mar 25, 2021 at 2:34 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Now that we have 2 separate input_dev-s for the buttons and thw switches, > this is no longer used, remove it. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/platform/x86/intel-vbtn.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c > index 3fdf4cbec9ad..888a764efad1 100644 > --- a/drivers/platform/x86/intel-vbtn.c > +++ b/drivers/platform/x86/intel-vbtn.c > @@ -63,9 +63,6 @@ static const struct key_entry intel_vbtn_switchmap[] = { > { KE_END } > }; > > -#define KEYMAP_LEN \ > - (ARRAY_SIZE(intel_vbtn_keymap) + ARRAY_SIZE(intel_vbtn_switchmap) + 1) > - > struct intel_vbtn_priv { > struct input_dev *buttons_dev; > struct input_dev *switches_dev; > -- > 2.30.2 >
Hi, On 3/25/21 1:32 PM, Hans de Goede wrote: > Now that we have 2 separate input_dev-s for the buttons and thw switches, > this is no longer used, remove it. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Applied to my review-hans branch. Andy, thank you for the review. Regards, Hans > --- > drivers/platform/x86/intel-vbtn.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c > index 3fdf4cbec9ad..888a764efad1 100644 > --- a/drivers/platform/x86/intel-vbtn.c > +++ b/drivers/platform/x86/intel-vbtn.c > @@ -63,9 +63,6 @@ static const struct key_entry intel_vbtn_switchmap[] = { > { KE_END } > }; > > -#define KEYMAP_LEN \ > - (ARRAY_SIZE(intel_vbtn_keymap) + ARRAY_SIZE(intel_vbtn_switchmap) + 1) > - > struct intel_vbtn_priv { > struct input_dev *buttons_dev; > struct input_dev *switches_dev; >
diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c index 3fdf4cbec9ad..888a764efad1 100644 --- a/drivers/platform/x86/intel-vbtn.c +++ b/drivers/platform/x86/intel-vbtn.c @@ -63,9 +63,6 @@ static const struct key_entry intel_vbtn_switchmap[] = { { KE_END } }; -#define KEYMAP_LEN \ - (ARRAY_SIZE(intel_vbtn_keymap) + ARRAY_SIZE(intel_vbtn_switchmap) + 1) - struct intel_vbtn_priv { struct input_dev *buttons_dev; struct input_dev *switches_dev;
Now that we have 2 separate input_dev-s for the buttons and thw switches, this is no longer used, remove it. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/platform/x86/intel-vbtn.c | 3 --- 1 file changed, 3 deletions(-)