From patchwork Mon May 31 06:07:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiheng Lin X-Patchwork-Id: 12288717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2004FC4708F for ; Mon, 31 May 2021 06:08:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC5AB611CA for ; Mon, 31 May 2021 06:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230013AbhEaGJv (ORCPT ); Mon, 31 May 2021 02:09:51 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3476 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229752AbhEaGJt (ORCPT ); Mon, 31 May 2021 02:09:49 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FtlBs3k98zYsKF; Mon, 31 May 2021 14:05:25 +0800 (CST) Received: from dggpemm500012.china.huawei.com (7.185.36.89) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 31 May 2021 14:08:01 +0800 Received: from DESKTOP-EFRLNPK.china.huawei.com (10.174.176.189) by dggpemm500012.china.huawei.com (7.185.36.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 31 May 2021 14:08:00 +0800 From: Qiheng Lin To: , , , , , , , , , CC: , , , Qiheng Lin Subject: [PATCH -next] x86/platform/uv: functions should not be declared extern Date: Mon, 31 May 2021 14:07:47 +0800 Message-ID: <20210531060747.21934-1-linqiheng@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Originating-IP: [10.174.176.189] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500012.china.huawei.com (7.185.36.89) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org These function declarations in 'bios.h' are already marked extern, thus their definition should not have the keyword. This quiets the following sparse warnings: function 'uv_bios_get_master_nasid' with external linkage has definition function 'uv_bios_get_heapsize' with external linkage has definition function 'uv_bios_install_heap' with external linkage has definition function 'uv_bios_obj_count' with external linkage has definition function 'uv_bios_enum_objs' with external linkage has definition function 'uv_bios_enum_ports' with external linkage has definition function 'uv_bios_get_geoinfo' with external linkage has definition function 'uv_bios_get_pci_topology' with external linkage has definition Signed-off-by: Qiheng Lin --- arch/x86/platform/uv/bios_uv.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/x86/platform/uv/bios_uv.c b/arch/x86/platform/uv/bios_uv.c index bf31af3d32d6..7e7634c8be62 100644 --- a/arch/x86/platform/uv/bios_uv.c +++ b/arch/x86/platform/uv/bios_uv.c @@ -172,55 +172,55 @@ int uv_bios_set_legacy_vga_target(bool decode, int domain, int bus) (u64)decode, (u64)domain, (u64)bus, 0, 0); } -extern s64 uv_bios_get_master_nasid(u64 size, u64 *master_nasid) +s64 uv_bios_get_master_nasid(u64 size, u64 *master_nasid) { return uv_bios_call(UV_BIOS_EXTRA, 0, UV_BIOS_EXTRA_MASTER_NASID, 0, size, (u64)master_nasid); } EXPORT_SYMBOL_GPL(uv_bios_get_master_nasid); -extern s64 uv_bios_get_heapsize(u64 nasid, u64 size, u64 *heap_size) +s64 uv_bios_get_heapsize(u64 nasid, u64 size, u64 *heap_size) { return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_GET_HEAPSIZE, 0, size, (u64)heap_size); } EXPORT_SYMBOL_GPL(uv_bios_get_heapsize); -extern s64 uv_bios_install_heap(u64 nasid, u64 heap_size, u64 *bios_heap) +s64 uv_bios_install_heap(u64 nasid, u64 heap_size, u64 *bios_heap) { return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_INSTALL_HEAP, 0, heap_size, (u64)bios_heap); } EXPORT_SYMBOL_GPL(uv_bios_install_heap); -extern s64 uv_bios_obj_count(u64 nasid, u64 size, u64 *objcnt) +s64 uv_bios_obj_count(u64 nasid, u64 size, u64 *objcnt) { return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_OBJECT_COUNT, 0, size, (u64)objcnt); } EXPORT_SYMBOL_GPL(uv_bios_obj_count); -extern s64 uv_bios_enum_objs(u64 nasid, u64 size, u64 *objbuf) +s64 uv_bios_enum_objs(u64 nasid, u64 size, u64 *objbuf) { return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_ENUM_OBJECTS, 0, size, (u64)objbuf); } EXPORT_SYMBOL_GPL(uv_bios_enum_objs); -extern s64 uv_bios_enum_ports(u64 nasid, u64 obj_id, u64 size, u64 *portbuf) +s64 uv_bios_enum_ports(u64 nasid, u64 obj_id, u64 size, u64 *portbuf) { return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_ENUM_PORTS, obj_id, size, (u64)portbuf); } EXPORT_SYMBOL_GPL(uv_bios_enum_ports); -extern s64 uv_bios_get_geoinfo(u64 nasid, u64 size, u64 *buf) +s64 uv_bios_get_geoinfo(u64 nasid, u64 size, u64 *buf) { return uv_bios_call(UV_BIOS_GET_GEOINFO, nasid, (u64)buf, size, 0, 0); } EXPORT_SYMBOL_GPL(uv_bios_get_geoinfo); -extern s64 uv_bios_get_pci_topology(u64 size, u64 *buf) +s64 uv_bios_get_pci_topology(u64 size, u64 *buf) { return uv_bios_call(UV_BIOS_GET_PCI_TOPOLOGY, (u64)buf, size, 0, 0, 0); }