| Message ID | 20210618125516.53510-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2,1/8] platform/x86: Remove "default n" entries | expand |
On Fri, Jun 18, 2021 at 4:09 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Linus already once did that for PDx86, don't repeat our mistakes. > TL;DR: 'n' *is* the default 'default'. Daniel, thanks for your testing! Hans, patches 2-6 were reviewed and tested, do you think we have a chance for the series to be applied?
Hi, On 6/22/21 11:02 AM, Andy Shevchenko wrote: > On Fri, Jun 18, 2021 at 4:09 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: >> >> Linus already once did that for PDx86, don't repeat our mistakes. >> TL;DR: 'n' *is* the default 'default'. > > Daniel, thanks for your testing! > > Hans, patches 2-6 were reviewed and tested, do you think we have a > chance for the series to be applied? Yes I was working on applying it right now :) Regards, Hans
Hi, On 6/18/21 2:55 PM, Andy Shevchenko wrote: > Linus already once did that for PDx86, don't repeat our mistakes. > TL;DR: 'n' *is* the default 'default'. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note I've squashed in the following fixup to patch 7/8: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9388,7 +9388,7 @@ F: drivers/platform/x86/intel_scu_* INTEL SKYLAKE INT3472 ACPI DEVICE DRIVER M: Daniel Scally <djrscally@gmail.com> S: Maintained -F: drivers/platform/x86/intel-int3472/ +F: drivers/platform/x86/intel/int3472/ INTEL SPEED SELECT TECHNOLOGY M: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> (checkpatch complained about MAINTAINERS not being updated) Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > v2: no changes > drivers/platform/x86/Kconfig | 1 - > drivers/platform/x86/dell/Kconfig | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 4fd792f2a10a..ccb827b57f1f 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1092,7 +1092,6 @@ config TOUCHSCREEN_DMI > > config FW_ATTR_CLASS > tristate > - default n > > config INTEL_IMR > bool "Intel Isolated Memory Region support" > diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig > index 9b0a4d080f43..9e7314d90bea 100644 > --- a/drivers/platform/x86/dell/Kconfig > +++ b/drivers/platform/x86/dell/Kconfig > @@ -5,7 +5,6 @@ > > menuconfig X86_PLATFORM_DRIVERS_DELL > bool "Dell X86 Platform Specific Device Drivers" > - default n > depends on X86_PLATFORM_DEVICES > help > Say Y here to get to see options for device drivers for various >
On Tue, Jun 22, 2021 at 12:42 PM Hans de Goede <hdegoede@redhat.com> wrote: > On 6/18/21 2:55 PM, Andy Shevchenko wrote: > > Linus already once did that for PDx86, don't repeat our mistakes. > > TL;DR: 'n' *is* the default 'default'. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Thank you for your patch-series, I've applied the series to my > review-hans branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > Note I've squashed in the following fixup to patch 7/8: > > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9388,7 +9388,7 @@ F: drivers/platform/x86/intel_scu_* > INTEL SKYLAKE INT3472 ACPI DEVICE DRIVER > M: Daniel Scally <djrscally@gmail.com> > S: Maintained > -F: drivers/platform/x86/intel-int3472/ > +F: drivers/platform/x86/intel/int3472/ > (checkpatch complained about MAINTAINERS not being updated) Thank you, Hans!
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 4fd792f2a10a..ccb827b57f1f 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1092,7 +1092,6 @@ config TOUCHSCREEN_DMI config FW_ATTR_CLASS tristate - default n config INTEL_IMR bool "Intel Isolated Memory Region support" diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig index 9b0a4d080f43..9e7314d90bea 100644 --- a/drivers/platform/x86/dell/Kconfig +++ b/drivers/platform/x86/dell/Kconfig @@ -5,7 +5,6 @@ menuconfig X86_PLATFORM_DRIVERS_DELL bool "Dell X86 Platform Specific Device Drivers" - default n depends on X86_PLATFORM_DEVICES help Say Y here to get to see options for device drivers for various
Linus already once did that for PDx86, don't repeat our mistakes. TL;DR: 'n' *is* the default 'default'. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: no changes drivers/platform/x86/Kconfig | 1 - drivers/platform/x86/dell/Kconfig | 1 - 2 files changed, 2 deletions(-)