From patchwork Mon Jun 28 08:49:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prasanth KSR X-Patchwork-Id: 12347431 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F116C2B9F4 for ; Mon, 28 Jun 2021 08:49:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 083D260232 for ; Mon, 28 Jun 2021 08:49:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232445AbhF1IwN (ORCPT ); Mon, 28 Jun 2021 04:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231698AbhF1IwM (ORCPT ); Mon, 28 Jun 2021 04:52:12 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1315C061574; Mon, 28 Jun 2021 01:49:46 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id c7-20020a17090ad907b029016faeeab0ccso12360273pjv.4; Mon, 28 Jun 2021 01:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eZ1Rz1gXRWLyBZZfCueyrqEMIScQMf1t2w1D89bLOgo=; b=rfTw8XaKSHWcqHJxkheAzQ21uJzBLsplbqxEKwnI9qgIgVpYnSZGcYf1B3OYHGQID5 DEi/AweUbYvOcuf6umV17HOIbgBqL1cUL0tKxcJQemqhB6FElk1IocDYd/ErG6BV6Wlr cZG6XSVtS3hmOMGusyRcufUgp7TD7113ElJ3C7mjMw96gmsYsR/ElwcHpEqFiIJvgVzd GFcAD+QAEyebHIoXodTC0JEwex282LGKpxIBDozDp0dwrbz6w26CuIR+EVRjuUMXCnfP sP35bKT3KL7iwCMuAWY+2VQnPMcbDU7akffhilqSkVjUw2aRnc0+M1jFtuN55iBe/Y2f hOiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eZ1Rz1gXRWLyBZZfCueyrqEMIScQMf1t2w1D89bLOgo=; b=qrGzkEYPBdBZSztQyR7rBoc6+VDZvH/KuFqiIG8BK+3yZLNfmle2mVdle6AvKF+Qak PTKgYQmFSTdvekDuNdwwcbxwGHRHnMV8iMUmvfNfg79o/WKhMCoP2Hbn5bgsq8H+LGAG pJK7X8MMW9wXfIvDCwp7tA0WB1v8zydBtO7kaUEsKQdPxwT4p6nthbDb6Ge17dJIxAXy nu0ofUTrm9fFI0luO63U5N08oI4QbG8ZKsrbB5uBvhB2moASHZC9b4wRJE+eOeTp+nno KEv0dLJJU1yIyJF2Of+EzquM4yI4ImaaXaHWO5bYUMBLnMTZC17kqYbOh27LqAiFWhP3 ZTrQ== X-Gm-Message-State: AOAM531bUXYJVHub0BQdokGi+Z3VTaVuK6Vg2eE6CwGjBOFo74W+vx7k GQ9utPzlJuYn5/pGgRCuAMg= X-Google-Smtp-Source: ABdhPJzf+FJ+FM3ZjovOUDgK4fBx+vzkYpOfwxL7vC868dap89boW8lhRJKU51/MZ4vk5xge9NrzVw== X-Received: by 2002:a17:90a:ee95:: with SMTP id i21mr6081359pjz.231.1624870186501; Mon, 28 Jun 2021 01:49:46 -0700 (PDT) Received: from localhost.localdomain ([49.207.213.78]) by smtp.gmail.com with ESMTPSA id u14sm13429397pfk.10.2021.06.28.01.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 01:49:46 -0700 (PDT) From: Prasanth KSR X-Google-Original-From: Prasanth KSR To: Hans de Goede , dvhart@infradead.org Cc: LKML , platform-driver-x86@vger.kernel.org, Prasanth KSR , Divya Bharathi Subject: [PATCH] platform/x86: dell-wmi-sysman: Change user experience when Admin/System Password is modified Date: Mon, 28 Jun 2021 14:19:06 +0530 Message-Id: <20210628084906.4233-1-prasanth.ksr@dell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Whenever user has changed an Admin/System Password using the sysfs, then we are automatically copying the new password to existing password field. Co-developed-by: Divya Bharathi Signed-off-by: Divya Bharathi Signed-off-by: Prasanth KSR --- .../x86/dell/dell-wmi-sysman/passwordattr-interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c b/drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c index 339a082d6c18..86ec962aace9 100644 --- a/drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c @@ -95,9 +95,9 @@ int set_new_password(const char *password_type, const char *new) print_hex_dump_bytes("set new password data: ", DUMP_PREFIX_NONE, buffer, buffer_size); ret = call_password_interface(wmi_priv.password_attr_wdev, buffer, buffer_size); - /* clear current_password here and use user input from wmi_priv.current_password */ + /* on success copy the new password to current password */ if (!ret) - memset(current_password, 0, MAX_BUFF); + strscpy(current_password, new, MAX_BUFF); /* explain to user the detailed failure reason */ else if (ret == -EOPNOTSUPP) dev_err(&wmi_priv.password_attr_wdev->dev, "admin password must be configured\n");