| Message ID | 20210629084803.248498-3-Shyam-sundar.S-k@amd.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | updates to amd-pmc driver | expand |
Hi, On 6/29/21 10:47 AM, Shyam Sundar S K wrote: > It was lately understood that the current mechanism available in the > driver to get SMU firmware info works only on internal SMU builds and > there is a separate way to get all the SMU logging counters (addressed > in the next patch). Hence remove all the smu info shown via debugfs as it > is no more useful. > > Fixes: 156ec4731cb2 ("platform/x86: amd-pmc: Add AMD platform support for S2Idle") > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > --- > v2: split into multiple patches as suggested by Hans > v3: No change > v4: No change > v5: NO change Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > > drivers/platform/x86/amd-pmc.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c > index 1b5f149932c1..b1d6175a13b2 100644 > --- a/drivers/platform/x86/amd-pmc.c > +++ b/drivers/platform/x86/amd-pmc.c > @@ -52,7 +52,6 @@ > #define AMD_CPU_ID_PCO AMD_CPU_ID_RV > #define AMD_CPU_ID_CZN AMD_CPU_ID_RN > > -#define AMD_SMU_FW_VERSION 0x0 > #define PMC_MSG_DELAY_MIN_US 100 > #define RESPONSE_REGISTER_LOOP_MAX 200 > > @@ -89,11 +88,6 @@ static inline void amd_pmc_reg_write(struct amd_pmc_dev *dev, int reg_offset, u3 > #ifdef CONFIG_DEBUG_FS > static int smu_fw_info_show(struct seq_file *s, void *unused) > { > - struct amd_pmc_dev *dev = s->private; > - u32 value; > - > - value = ioread32(dev->smu_base + AMD_SMU_FW_VERSION); > - seq_printf(s, "SMU FW Info: %x\n", value); > return 0; > } > DEFINE_SHOW_ATTRIBUTE(smu_fw_info); > @@ -280,10 +274,6 @@ static int amd_pmc_probe(struct platform_device *pdev) > pci_dev_put(rdev); > base_addr = ((u64)base_addr_hi << 32 | base_addr_lo); > > - dev->smu_base = devm_ioremap(dev->dev, base_addr, AMD_PMC_MAPPING_SIZE); > - if (!dev->smu_base) > - return -ENOMEM; > - > dev->regbase = devm_ioremap(dev->dev, base_addr + AMD_PMC_BASE_ADDR_OFFSET, > AMD_PMC_MAPPING_SIZE); > if (!dev->regbase) >
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c index 1b5f149932c1..b1d6175a13b2 100644 --- a/drivers/platform/x86/amd-pmc.c +++ b/drivers/platform/x86/amd-pmc.c @@ -52,7 +52,6 @@ #define AMD_CPU_ID_PCO AMD_CPU_ID_RV #define AMD_CPU_ID_CZN AMD_CPU_ID_RN -#define AMD_SMU_FW_VERSION 0x0 #define PMC_MSG_DELAY_MIN_US 100 #define RESPONSE_REGISTER_LOOP_MAX 200 @@ -89,11 +88,6 @@ static inline void amd_pmc_reg_write(struct amd_pmc_dev *dev, int reg_offset, u3 #ifdef CONFIG_DEBUG_FS static int smu_fw_info_show(struct seq_file *s, void *unused) { - struct amd_pmc_dev *dev = s->private; - u32 value; - - value = ioread32(dev->smu_base + AMD_SMU_FW_VERSION); - seq_printf(s, "SMU FW Info: %x\n", value); return 0; } DEFINE_SHOW_ATTRIBUTE(smu_fw_info); @@ -280,10 +274,6 @@ static int amd_pmc_probe(struct platform_device *pdev) pci_dev_put(rdev); base_addr = ((u64)base_addr_hi << 32 | base_addr_lo); - dev->smu_base = devm_ioremap(dev->dev, base_addr, AMD_PMC_MAPPING_SIZE); - if (!dev->smu_base) - return -ENOMEM; - dev->regbase = devm_ioremap(dev->dev, base_addr + AMD_PMC_BASE_ADDR_OFFSET, AMD_PMC_MAPPING_SIZE); if (!dev->regbase)
It was lately understood that the current mechanism available in the driver to get SMU firmware info works only on internal SMU builds and there is a separate way to get all the SMU logging counters (addressed in the next patch). Hence remove all the smu info shown via debugfs as it is no more useful. Fixes: 156ec4731cb2 ("platform/x86: amd-pmc: Add AMD platform support for S2Idle") Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> --- v2: split into multiple patches as suggested by Hans v3: No change v4: No change v5: NO change drivers/platform/x86/amd-pmc.c | 10 ---------- 1 file changed, 10 deletions(-)