Message ID | 20210704222148.880848-2-luke@ljones.dev (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | Support for ASUS egpu, dpgu disable, panel overdrive | expand |
Hi "Luke, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.13 next-20210701] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Luke-D-Jones/Support-for-ASUS-egpu-dpgu-disable-panel-overdrive/20210705-062341 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 28e92f990337b8b4c5fdec47667f8b96089c503e config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/b46e8ec7f42ce4b644c43f40218fe853d078f098 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Luke-D-Jones/Support-for-ASUS-egpu-dpgu-disable-panel-overdrive/20210705-062341 git checkout b46e8ec7f42ce4b644c43f40218fe853d078f098 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/platform/x86/asus-wmi.c: In function 'panel_od_check_present': >> drivers/platform/x86/asus-wmi.c:1242:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 1242 | if (result & ASUS_WMI_DSTS_PRESENCE_BIT) | ^~ drivers/platform/x86/asus-wmi.c:1244:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 1244 | asus->panel_overdrive = result & ASUS_WMI_DSTS_STATUS_BIT; | ^~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for PHY_SPARX5_SERDES Depends on (ARCH_SPARX5 || COMPILE_TEST && OF && HAS_IOMEM Selected by - SPARX5_SWITCH && NETDEVICES && ETHERNET && NET_VENDOR_MICROCHIP && NET_SWITCHDEV && HAS_IOMEM vim +/if +1242 drivers/platform/x86/asus-wmi.c 1226 1227 /* Panel Overdrive ************************************************************/ 1228 static int panel_od_check_present(struct asus_wmi *asus) 1229 { 1230 u32 result; 1231 int err; 1232 1233 asus->panel_overdrive_available = false; 1234 1235 err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_PANEL_OD, &result); 1236 if (err) { 1237 if (err == -ENODEV) 1238 return 0; 1239 return err; 1240 } 1241 > 1242 if (result & ASUS_WMI_DSTS_PRESENCE_BIT) 1243 asus->panel_overdrive_available = true; 1244 asus->panel_overdrive = result & ASUS_WMI_DSTS_STATUS_BIT; 1245 1246 return 0; 1247 } 1248 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi, Thank you for your patches, I've added several remarks inline (below); On 7/5/21 12:21 AM, Luke D. Jones wrote: > Some ASUS ROG laptops have the ability to drive the display panel > a a higher rate to eliminate or reduce ghosting. > > Signed-off-by: Luke D. Jones <luke@ljones.dev> > --- > drivers/platform/x86/asus-wmi.c | 92 ++++++++++++++++++++++ > include/linux/platform_data/x86/asus-wmi.h | 1 + > 2 files changed, 93 insertions(+) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index ebaeb7bb80f5..2468076d6cd8 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -216,6 +216,9 @@ struct asus_wmi { > // The RSOC controls the maximum charging percentage. > bool battery_rsoc_available; > > + bool panel_overdrive_available; > + u8 panel_overdrive; > + > struct hotplug_slot hotplug_slot; > struct mutex hotplug_lock; > struct mutex wmi_lock; > @@ -1221,6 +1224,87 @@ static int asus_wmi_rfkill_init(struct asus_wmi *asus) > return result; > } > > +/* Panel Overdrive ************************************************************/ > +static int panel_od_check_present(struct asus_wmi *asus) > +{ > + u32 result; > + int err; > + > + asus->panel_overdrive_available = false; > + > + err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_PANEL_OD, &result); > + if (err) { > + if (err == -ENODEV) > + return 0; > + return err; > + } > + > + if (result & ASUS_WMI_DSTS_PRESENCE_BIT) > + asus->panel_overdrive_available = true; > + asus->panel_overdrive = result & ASUS_WMI_DSTS_STATUS_BIT; As the kernel-test-robot pointed out this if is missing { } around the 2 statements which should only be executed if the condition is true. > + > + return 0; > +} > + > +static int panel_od_write(struct asus_wmi *asus) > +{ > + int err; > + u8 value; > + u32 retval; > + > + value = asus->panel_overdrive; > + > + err = asus_wmi_set_devstate(ASUS_WMI_DEVID_PANEL_OD, value, &retval); > + > + sysfs_notify(&asus->platform_device->dev.kobj, NULL, > + "panel_od"); Please make this a single line. > + > + if (err) { > + pr_warn("Failed to set panel overdrive: %d\n", err); > + return err; > + } > + > + if (retval > 1 || retval < 0) { > + pr_warn("Failed to set panel overdrive (retval): 0x%x\n", > + retval); Please make this a single line too. > + return -EIO; > + } > + > + return 0; > +} > + > +static ssize_t panel_od_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct asus_wmi *asus = dev_get_drvdata(dev); > + u8 mode = asus->panel_overdrive; > + > + return scnprintf(buf, PAGE_SIZE, "%d\n", mode); > +} > + > +static ssize_t panel_od_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + int result; > + u8 overdrive; > + struct asus_wmi *asus = dev_get_drvdata(dev); > + > + result = kstrtou8(buf, 10, &overdrive); > + if (result < 0) > + return result; > + > + if (overdrive > 1 || overdrive < 0) An u8 can never be < 0, so please drop that check (it will likely trigger compiler warnings in some cases). > + return -EINVAL; > + > + asus->panel_overdrive = overdrive; > + panel_od_write(asus); > + > + return count; > +} > + > +static DEVICE_ATTR_RW(panel_od); > + > /* Quirks *********************************************************************/ > > static void asus_wmi_set_xusb2pr(struct asus_wmi *asus) > @@ -2332,6 +2416,7 @@ static struct attribute *platform_attributes[] = { > &dev_attr_als_enable.attr, > &dev_attr_fan_boost_mode.attr, > &dev_attr_throttle_thermal_policy.attr, > + &dev_attr_panel_od.attr, > NULL > }; > > @@ -2357,6 +2442,8 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj, > ok = asus->fan_boost_mode_available; > else if (attr == &dev_attr_throttle_thermal_policy.attr) > ok = asus->throttle_thermal_policy_available; > + else if (attr == &dev_attr_panel_od.attr) > + ok = asus->panel_overdrive_available; > > if (devid != -1) > ok = !(asus_wmi_get_devstate_simple(asus, devid) < 0); > @@ -2622,6 +2709,10 @@ static int asus_wmi_add(struct platform_device *pdev) > else > throttle_thermal_policy_set_default(asus); > > + err = panel_od_check_present(asus); > + if (err) > + goto fail_panel_od; > + > err = asus_wmi_sysfs_init(asus->platform_device); > if (err) > goto fail_sysfs; > @@ -2709,6 +2800,7 @@ static int asus_wmi_add(struct platform_device *pdev) > fail_throttle_thermal_policy: > fail_fan_boost_mode: > fail_platform: > +fail_panel_od: > kfree(asus); > return err; > } > diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h > index 2f274cf52805..428aea701c7b 100644 > --- a/include/linux/platform_data/x86/asus-wmi.h > +++ b/include/linux/platform_data/x86/asus-wmi.h > @@ -61,6 +61,7 @@ > #define ASUS_WMI_DEVID_THROTTLE_THERMAL_POLICY 0x00120075 > > /* Misc */ > +#define ASUS_WMI_DEVID_PANEL_OD 0x00050019 > #define ASUS_WMI_DEVID_CAMERA 0x00060013 > #define ASUS_WMI_DEVID_LID_FLIP 0x00060062 > > Otherwise this looks good to me, Regards, Hans
Hi, One more remark inline: On 7/5/21 12:21 AM, Luke D. Jones wrote: > Some ASUS ROG laptops have the ability to drive the display panel > a a higher rate to eliminate or reduce ghosting. > > Signed-off-by: Luke D. Jones <luke@ljones.dev> > --- > drivers/platform/x86/asus-wmi.c | 92 ++++++++++++++++++++++ > include/linux/platform_data/x86/asus-wmi.h | 1 + > 2 files changed, 93 insertions(+) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index ebaeb7bb80f5..2468076d6cd8 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c <snip> > +static ssize_t panel_od_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct asus_wmi *asus = dev_get_drvdata(dev); > + u8 mode = asus->panel_overdrive; > + > + return scnprintf(buf, PAGE_SIZE, "%d\n", mode); As Barnabás pointed out in his review of patch 2/3, please use sysfs_emit here. Regards, Hans
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index ebaeb7bb80f5..2468076d6cd8 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -216,6 +216,9 @@ struct asus_wmi { // The RSOC controls the maximum charging percentage. bool battery_rsoc_available; + bool panel_overdrive_available; + u8 panel_overdrive; + struct hotplug_slot hotplug_slot; struct mutex hotplug_lock; struct mutex wmi_lock; @@ -1221,6 +1224,87 @@ static int asus_wmi_rfkill_init(struct asus_wmi *asus) return result; } +/* Panel Overdrive ************************************************************/ +static int panel_od_check_present(struct asus_wmi *asus) +{ + u32 result; + int err; + + asus->panel_overdrive_available = false; + + err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_PANEL_OD, &result); + if (err) { + if (err == -ENODEV) + return 0; + return err; + } + + if (result & ASUS_WMI_DSTS_PRESENCE_BIT) + asus->panel_overdrive_available = true; + asus->panel_overdrive = result & ASUS_WMI_DSTS_STATUS_BIT; + + return 0; +} + +static int panel_od_write(struct asus_wmi *asus) +{ + int err; + u8 value; + u32 retval; + + value = asus->panel_overdrive; + + err = asus_wmi_set_devstate(ASUS_WMI_DEVID_PANEL_OD, value, &retval); + + sysfs_notify(&asus->platform_device->dev.kobj, NULL, + "panel_od"); + + if (err) { + pr_warn("Failed to set panel overdrive: %d\n", err); + return err; + } + + if (retval > 1 || retval < 0) { + pr_warn("Failed to set panel overdrive (retval): 0x%x\n", + retval); + return -EIO; + } + + return 0; +} + +static ssize_t panel_od_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct asus_wmi *asus = dev_get_drvdata(dev); + u8 mode = asus->panel_overdrive; + + return scnprintf(buf, PAGE_SIZE, "%d\n", mode); +} + +static ssize_t panel_od_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + int result; + u8 overdrive; + struct asus_wmi *asus = dev_get_drvdata(dev); + + result = kstrtou8(buf, 10, &overdrive); + if (result < 0) + return result; + + if (overdrive > 1 || overdrive < 0) + return -EINVAL; + + asus->panel_overdrive = overdrive; + panel_od_write(asus); + + return count; +} + +static DEVICE_ATTR_RW(panel_od); + /* Quirks *********************************************************************/ static void asus_wmi_set_xusb2pr(struct asus_wmi *asus) @@ -2332,6 +2416,7 @@ static struct attribute *platform_attributes[] = { &dev_attr_als_enable.attr, &dev_attr_fan_boost_mode.attr, &dev_attr_throttle_thermal_policy.attr, + &dev_attr_panel_od.attr, NULL }; @@ -2357,6 +2442,8 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj, ok = asus->fan_boost_mode_available; else if (attr == &dev_attr_throttle_thermal_policy.attr) ok = asus->throttle_thermal_policy_available; + else if (attr == &dev_attr_panel_od.attr) + ok = asus->panel_overdrive_available; if (devid != -1) ok = !(asus_wmi_get_devstate_simple(asus, devid) < 0); @@ -2622,6 +2709,10 @@ static int asus_wmi_add(struct platform_device *pdev) else throttle_thermal_policy_set_default(asus); + err = panel_od_check_present(asus); + if (err) + goto fail_panel_od; + err = asus_wmi_sysfs_init(asus->platform_device); if (err) goto fail_sysfs; @@ -2709,6 +2800,7 @@ static int asus_wmi_add(struct platform_device *pdev) fail_throttle_thermal_policy: fail_fan_boost_mode: fail_platform: +fail_panel_od: kfree(asus); return err; } diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h index 2f274cf52805..428aea701c7b 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -61,6 +61,7 @@ #define ASUS_WMI_DEVID_THROTTLE_THERMAL_POLICY 0x00120075 /* Misc */ +#define ASUS_WMI_DEVID_PANEL_OD 0x00050019 #define ASUS_WMI_DEVID_CAMERA 0x00060013 #define ASUS_WMI_DEVID_LID_FLIP 0x00060062
Some ASUS ROG laptops have the ability to drive the display panel a a higher rate to eliminate or reduce ghosting. Signed-off-by: Luke D. Jones <luke@ljones.dev> --- drivers/platform/x86/asus-wmi.c | 92 ++++++++++++++++++++++ include/linux/platform_data/x86/asus-wmi.h | 1 + 2 files changed, 93 insertions(+)