| Message ID | 20210803175000.72880-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v1,1/1] platform/surface: aggregator: Ouse y instead of objs in Makefile | expand |
On 8/3/21 7:50 PM, Andy Shevchenko wrote: > The 'objs' is for user space tools, for the kernel modules > we should use 'y'. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thank you! I was previously not aware of that distinction. Two small notes: - There is a typo in the subject line. - With that change, the ifeq could be placed in-line (see note below). All in all looks good to me (assuming the typo gets fixed). Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> > --- > drivers/platform/surface/aggregator/Makefile | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/surface/aggregator/Makefile b/drivers/platform/surface/aggregator/Makefile > index c8498c41e758..ce548dba1d4b 100644 > --- a/drivers/platform/surface/aggregator/Makefile > +++ b/drivers/platform/surface/aggregator/Makefile > @@ -6,12 +6,12 @@ CFLAGS_core.o = -I$(src) > > obj-$(CONFIG_SURFACE_AGGREGATOR) += surface_aggregator.o > > -surface_aggregator-objs := core.o > -surface_aggregator-objs += ssh_parser.o > -surface_aggregator-objs += ssh_packet_layer.o > -surface_aggregator-objs += ssh_request_layer.o > -surface_aggregator-objs += controller.o > +surface_aggregator-y := core.o > +surface_aggregator-y += ssh_parser.o > +surface_aggregator-y += ssh_packet_layer.o > +surface_aggregator-y += ssh_request_layer.o > +surface_aggregator-y += controller.o > > ifeq ($(CONFIG_SURFACE_AGGREGATOR_BUS),y) > -surface_aggregator-objs += bus.o > +surface_aggregator-y += bus.o > endif I believe it should now be possible to write this as surface_aggregator-$(CONFIG_SURFACE_AGGREGATOR_BUS) += bus.o which might be a bit cleaner. Don't have much of a preference though so I'd also be fine with keeping the ifeq. Regards, Max
On Tue, Aug 03, 2021 at 08:40:10PM +0200, Maximilian Luz wrote: > On 8/3/21 7:50 PM, Andy Shevchenko wrote: > > The 'objs' is for user space tools, for the kernel modules > > we should use 'y'. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Thank you! I was previously not aware of that distinction. Two small > notes: > > - There is a typo in the subject line. > - With that change, the ifeq could be placed in-line (see note below). Will address both. > All in all looks good to me (assuming the typo gets fixed). > > Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> Thanks!
diff --git a/drivers/platform/surface/aggregator/Makefile b/drivers/platform/surface/aggregator/Makefile index c8498c41e758..ce548dba1d4b 100644 --- a/drivers/platform/surface/aggregator/Makefile +++ b/drivers/platform/surface/aggregator/Makefile @@ -6,12 +6,12 @@ CFLAGS_core.o = -I$(src) obj-$(CONFIG_SURFACE_AGGREGATOR) += surface_aggregator.o -surface_aggregator-objs := core.o -surface_aggregator-objs += ssh_parser.o -surface_aggregator-objs += ssh_packet_layer.o -surface_aggregator-objs += ssh_request_layer.o -surface_aggregator-objs += controller.o +surface_aggregator-y := core.o +surface_aggregator-y += ssh_parser.o +surface_aggregator-y += ssh_packet_layer.o +surface_aggregator-y += ssh_request_layer.o +surface_aggregator-y += controller.o ifeq ($(CONFIG_SURFACE_AGGREGATOR_BUS),y) -surface_aggregator-objs += bus.o +surface_aggregator-y += bus.o endif
The 'objs' is for user space tools, for the kernel modules we should use 'y'. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/platform/surface/aggregator/Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)