| Message ID | 20210803192524.67031-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2,1/1] platform/surface: aggregator: Use y instead of objs in Makefile | expand |
Hi, On 8/3/21 9:25 PM, Andy Shevchenko wrote: > The 'objs' is for user space tools, for the kernel modules > we should use 'y'. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > v2: fixed typo, annihilated ifeq, added Rb tag (Maximilian) > drivers/platform/surface/aggregator/Makefile | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/platform/surface/aggregator/Makefile b/drivers/platform/surface/aggregator/Makefile > index c8498c41e758..c0d550eda5cd 100644 > --- a/drivers/platform/surface/aggregator/Makefile > +++ b/drivers/platform/surface/aggregator/Makefile > @@ -6,12 +6,9 @@ CFLAGS_core.o = -I$(src) > > obj-$(CONFIG_SURFACE_AGGREGATOR) += surface_aggregator.o > > -surface_aggregator-objs := core.o > -surface_aggregator-objs += ssh_parser.o > -surface_aggregator-objs += ssh_packet_layer.o > -surface_aggregator-objs += ssh_request_layer.o > -surface_aggregator-objs += controller.o > - > -ifeq ($(CONFIG_SURFACE_AGGREGATOR_BUS),y) > -surface_aggregator-objs += bus.o > -endif > +surface_aggregator-y := core.o > +surface_aggregator-y += ssh_parser.o > +surface_aggregator-y += ssh_packet_layer.o > +surface_aggregator-y += ssh_request_layer.o > +surface_aggregator-$(CONFIG_SURFACE_AGGREGATOR_BUS) += bus.o > +surface_aggregator-y += controller.o >
diff --git a/drivers/platform/surface/aggregator/Makefile b/drivers/platform/surface/aggregator/Makefile index c8498c41e758..c0d550eda5cd 100644 --- a/drivers/platform/surface/aggregator/Makefile +++ b/drivers/platform/surface/aggregator/Makefile @@ -6,12 +6,9 @@ CFLAGS_core.o = -I$(src) obj-$(CONFIG_SURFACE_AGGREGATOR) += surface_aggregator.o -surface_aggregator-objs := core.o -surface_aggregator-objs += ssh_parser.o -surface_aggregator-objs += ssh_packet_layer.o -surface_aggregator-objs += ssh_request_layer.o -surface_aggregator-objs += controller.o - -ifeq ($(CONFIG_SURFACE_AGGREGATOR_BUS),y) -surface_aggregator-objs += bus.o -endif +surface_aggregator-y := core.o +surface_aggregator-y += ssh_parser.o +surface_aggregator-y += ssh_packet_layer.o +surface_aggregator-y += ssh_request_layer.o +surface_aggregator-$(CONFIG_SURFACE_AGGREGATOR_BUS) += bus.o +surface_aggregator-y += controller.o