From patchwork Sat Sep 4 17:55:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 12475739 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA334C433EF for ; Sat, 4 Sep 2021 17:55:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97669603E7 for ; Sat, 4 Sep 2021 17:55:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237267AbhIDR47 (ORCPT ); Sat, 4 Sep 2021 13:56:59 -0400 Received: from mail-0301.mail-europe.com ([188.165.51.139]:36581 "EHLO mail-0301.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231181AbhIDR47 (ORCPT ); Sat, 4 Sep 2021 13:56:59 -0400 Date: Sat, 04 Sep 2021 17:55:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1630778155; bh=DCt0KJ8hjPB8FkCriJLTZ89ABmv8kzwN5WHB+pIjrDw=; h=Date:To:From:Reply-To:Subject:From; b=sxjeQ+JNrk/6435tC09eyiJGRBwpDGncsLRHcpitj+7NszXm9XmhG3BjboBu5TPuh C/WWHIZK9Wea19g9J+GK6xpfVgqmpoiJnDe54N9JIWnSmvhRV83Gs3Shdw9bewQAUF On4Qp4EWLMH/clMG2fC2SFRC0g5yCAqz2b5auaCE= To: Hans de Goede , Mark Gross , platform-driver-x86@vger.kernel.org From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Reply-To: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [RFC PATCH v1 17/30] platform/x86: wmi: use sizeof() instead of hard-coding Message-ID: <20210904175450.156801-18-pobrn@protonmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Avoid hard-coding the buffer size in an `snprintf()` call by using `sizeof()` to retrieve the size. Signed-off-by: Barnabás Pőcze --- drivers/platform/x86/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.33.0 diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index f05c89fd1f79..979135a678e0 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -189,7 +189,7 @@ static acpi_status wmi_method_enable(struct wmi_block *wblock, bool enable) block = &wblock->gblock; handle = wblock->acpi_device->handle; - snprintf(method, 5, "WE%02X", block->notify_id); + snprintf(method, sizeof(method), "WE%02X", block->notify_id); status = acpi_execute_simple_method(handle, method, enable); if (status != AE_OK && status != AE_NOT_FOUND)