| Message ID | 20211210163009.19894-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v1,1/3] platform/x86: asus-wmi: Join string literals back | expand |
On Fri, Dec 10, 2021 at 06:30:07PM +0200, Andy Shevchenko wrote: > For easy grepping on debug purposes join string literals back in > the messages. > > No functional change. Hans, any comments on the series?
Hi, On 12/20/21 14:07, Andy Shevchenko wrote: > On Fri, Dec 10, 2021 at 06:30:07PM +0200, Andy Shevchenko wrote: >> For easy grepping on debug purposes join string literals back in >> the messages. >> >> No functional change. > > Hans, any comments on the series? No comments, the series looks good to me. I plan to another round of merging pdx86 patches tomorrow and then I plan to pick these up too. Regards, Hans
On Mon, Dec 20, 2021 at 02:30:20PM +0100, Hans de Goede wrote: > On 12/20/21 14:07, Andy Shevchenko wrote: > > On Fri, Dec 10, 2021 at 06:30:07PM +0200, Andy Shevchenko wrote: > >> For easy grepping on debug purposes join string literals back in > >> the messages. > >> > >> No functional change. > > > > Hans, any comments on the series? > > No comments, the series looks good to me. I plan to another round of > merging pdx86 patches tomorrow and then I plan to pick these up too. Thanks for good news!
Hi, On 12/10/21 17:30, Andy Shevchenko wrote: > For easy grepping on debug purposes join string literals back in > the messages. > > No functional change. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/asus-wmi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 6fa4b0be8e76..30e0de9e0d81 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -1154,12 +1154,10 @@ static void asus_rfkill_hotplug(struct asus_wmi *asus) > absent = (l == 0xffffffff); > > if (blocked != absent) { > - pr_warn("BIOS says wireless lan is %s, " > - "but the pci device is %s\n", > + pr_warn("BIOS says wireless lan is %s, but the pci device is %s\n", > blocked ? "blocked" : "unblocked", > absent ? "absent" : "present"); > - pr_warn("skipped wireless hotplug as probably " > - "inappropriate for this model\n"); > + pr_warn("skipped wireless hotplug as probably inappropriate for this model\n"); > goto out_unlock; > } > >
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 6fa4b0be8e76..30e0de9e0d81 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -1154,12 +1154,10 @@ static void asus_rfkill_hotplug(struct asus_wmi *asus) absent = (l == 0xffffffff); if (blocked != absent) { - pr_warn("BIOS says wireless lan is %s, " - "but the pci device is %s\n", + pr_warn("BIOS says wireless lan is %s, but the pci device is %s\n", blocked ? "blocked" : "unblocked", absent ? "absent" : "present"); - pr_warn("skipped wireless hotplug as probably " - "inappropriate for this model\n"); + pr_warn("skipped wireless hotplug as probably inappropriate for this model\n"); goto out_unlock; }
For easy grepping on debug purposes join string literals back in the messages. No functional change. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/platform/x86/asus-wmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)