| Message ID | 20220426120827.12363-1-gabriele.mzt@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: dell-laptop: Add quirk entry for Latitude 7520 | expand |
+ Dell.Client.Kernel@dell.com : please look at this issue below On Tuesday 26 April 2022 14:08:27 gabriele.mzt@gmail.com wrote: > From: Gabriele Mazzotta <gabriele.mzt@gmail.com> > > The Latitude 7520 supports AC timeouts, but it has no KBD_LED_AC_TOKEN > and so changes to stop_timeout appear to have no effect if the laptop > is plugged in. > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> > --- > As per the discussion here https://github.com/dell/libsmbios/issues/48, > this is really a BIOS bug. My Latitude 7520 has the latest BIOS > update installed, which was released just few months ago, but the > issue is still there. In that ticket is written that issue was already fixed and discussion closed. If it is not truth then please open and report a new ticket on github. And ideally report also this issue directly to Dell BIOS team per https://github.com/dell/libsmbios/issues/48#issuecomment-391328501 because as written that this is the right way for fixing the issue, rather than kernel patch. > --- > drivers/platform/x86/dell/dell-laptop.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c > index 8230e7a68a5e..1321687d923e 100644 > --- a/drivers/platform/x86/dell/dell-laptop.c > +++ b/drivers/platform/x86/dell/dell-laptop.c > @@ -80,6 +80,10 @@ static struct quirk_entry quirk_dell_inspiron_1012 = { > .kbd_led_not_present = true, > }; > > +static struct quirk_entry quirk_dell_latitude_7520 = { > + .kbd_missing_ac_tag = true, > +}; > + > static struct platform_driver platform_driver = { > .driver = { > .name = "dell-laptop", > @@ -336,6 +340,15 @@ static const struct dmi_system_id dell_quirks[] __initconst = { > }, > .driver_data = &quirk_dell_inspiron_1012, > }, > + { > + .callback = dmi_matched, > + .ident = "Dell Latitude 7520", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 7520"), > + }, > + .driver_data = &quirk_dell_latitude_7520, > + }, > { } > }; > > -- > 2.36.0 > In any case: Acked-by: Pali Rohár <pali@kernel.org> But I hope that Dell fixes this issue in their BIOS.
On Tue, 26 Apr 2022 at 18:33, Pali Rohár <pali@kernel.org> wrote: > > + Dell.Client.Kernel@dell.com : please look at this issue below > > On Tuesday 26 April 2022 14:08:27 gabriele.mzt@gmail.com wrote: > > From: Gabriele Mazzotta <gabriele.mzt@gmail.com> > > > > The Latitude 7520 supports AC timeouts, but it has no KBD_LED_AC_TOKEN > > and so changes to stop_timeout appear to have no effect if the laptop > > is plugged in. > > > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> > > --- > > As per the discussion here https://github.com/dell/libsmbios/issues/48, > > this is really a BIOS bug. My Latitude 7520 has the latest BIOS > > update installed, which was released just few months ago, but the > > issue is still there. > > In that ticket is written that issue was already fixed and discussion > closed. > > If it is not truth then please open and report a new ticket on github. > > And ideally report also this issue directly to Dell BIOS team per > https://github.com/dell/libsmbios/issues/48#issuecomment-391328501 > because as written that this is the right way for fixing the issue, > rather than kernel patch. Yes, I agree, I read the entire thread and it is the main reason why I updated the BIOS as soon as I noticed the issue (I've just got this laptop and I did not have the time to check everything yet). Anyway, I think that that repository is not monitored actively. I have also just noticed there is an open issue [1] about the same issue on a different laptop, so this is potentially a rather widespread issue. I will see if I find some other way to contact Dell. [1] - https://github.com/dell/libsmbios/issues/105
Hi, On 4/26/22 14:08, gabriele.mzt@gmail.com wrote: > From: Gabriele Mazzotta <gabriele.mzt@gmail.com> > > The Latitude 7520 supports AC timeouts, but it has no KBD_LED_AC_TOKEN > and so changes to stop_timeout appear to have no effect if the laptop > is plugged in. > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > As per the discussion here https://github.com/dell/libsmbios/issues/48, > this is really a BIOS bug. My Latitude 7520 has the latest BIOS > update installed, which was released just few months ago, but the > issue is still there. > --- > drivers/platform/x86/dell/dell-laptop.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c > index 8230e7a68a5e..1321687d923e 100644 > --- a/drivers/platform/x86/dell/dell-laptop.c > +++ b/drivers/platform/x86/dell/dell-laptop.c > @@ -80,6 +80,10 @@ static struct quirk_entry quirk_dell_inspiron_1012 = { > .kbd_led_not_present = true, > }; > > +static struct quirk_entry quirk_dell_latitude_7520 = { > + .kbd_missing_ac_tag = true, > +}; > + > static struct platform_driver platform_driver = { > .driver = { > .name = "dell-laptop", > @@ -336,6 +340,15 @@ static const struct dmi_system_id dell_quirks[] __initconst = { > }, > .driver_data = &quirk_dell_inspiron_1012, > }, > + { > + .callback = dmi_matched, > + .ident = "Dell Latitude 7520", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 7520"), > + }, > + .driver_data = &quirk_dell_latitude_7520, > + }, > { } > }; >
diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c index 8230e7a68a5e..1321687d923e 100644 --- a/drivers/platform/x86/dell/dell-laptop.c +++ b/drivers/platform/x86/dell/dell-laptop.c @@ -80,6 +80,10 @@ static struct quirk_entry quirk_dell_inspiron_1012 = { .kbd_led_not_present = true, }; +static struct quirk_entry quirk_dell_latitude_7520 = { + .kbd_missing_ac_tag = true, +}; + static struct platform_driver platform_driver = { .driver = { .name = "dell-laptop", @@ -336,6 +340,15 @@ static const struct dmi_system_id dell_quirks[] __initconst = { }, .driver_data = &quirk_dell_inspiron_1012, }, + { + .callback = dmi_matched, + .ident = "Dell Latitude 7520", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 7520"), + }, + .driver_data = &quirk_dell_latitude_7520, + }, { } };