| Message ID | 20220503183420.348-1-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: thinkpad_acpi: Add a few more models to s2idle quirk list | expand |
Hi, On 5/3/22 20:34, Mario Limonciello wrote: > Users have reported that there are a few other DMI strings that T14 can > go by, and so these models should also pick up the quirk to avoid the s2idle > firmware bug. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Thanks, since the original patch was still in my review-hans branch (and not yet in for-next) I've squashed this fix into the original patch. This squashing will hopefully make backporting these fixes easier. Regards, Hans > --- > drivers/platform/x86/thinkpad_acpi.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index 2833609fade7..f3554068dd1e 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -4463,6 +4463,22 @@ static const struct dmi_system_id fwbug_list[] __initconst = { > DMI_MATCH(DMI_PRODUCT_NAME, "20UD"), > } > }, > + { > + .ident = "T14 Gen1 AMD", > + .driver_data = &quirk_s2idle_bug, > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_NAME, "20UE"), > + } > + }, > + { > + .ident = "T14s Gen1 AMD", > + .driver_data = &quirk_s2idle_bug, > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_NAME, "20UH"), > + } > + }, > { > .ident = "P14s Gen1 AMD", > .driver_data = &quirk_s2idle_bug,
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 2833609fade7..f3554068dd1e 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -4463,6 +4463,22 @@ static const struct dmi_system_id fwbug_list[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "20UD"), } }, + { + .ident = "T14 Gen1 AMD", + .driver_data = &quirk_s2idle_bug, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "20UE"), + } + }, + { + .ident = "T14s Gen1 AMD", + .driver_data = &quirk_s2idle_bug, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "20UH"), + } + }, { .ident = "P14s Gen1 AMD", .driver_data = &quirk_s2idle_bug,
Users have reported that there are a few other DMI strings that T14 can go by, and so these models should also pick up the quirk to avoid the s2idle firmware bug. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/platform/x86/thinkpad_acpi.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)