| Message ID | 20220511171208.211319-1-srinivas.pandruvada@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | tools/power/x86/intel-speed-select: Fix warning for perf_cap.cpu | expand |
Hi, On 5/11/22 19:12, Srinivas Pandruvada wrote: > Initialize perf_cap struct to avoid warning: > > CC hfi-events.o > In function ‘process_hfi_event’, > inlined from ‘handle_event’ at hfi-events.c:220:5: > hfi-events.c:184:9: warning: ‘perf_cap.cpu’ may be used > uninitialized [-Wmaybe-uninitialized] > 184 | process_level_change(perf_cap->cpu); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > hfi-events.c: In function ‘handle_event’: > hfi-events.c:193:25: note: ‘perf_cap.cpu’ was declared here > 193 | struct perf_cap perf_cap; > | ^~~~~~~~ > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > tools/power/x86/intel-speed-select/hfi-events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/power/x86/intel-speed-select/hfi-events.c b/tools/power/x86/intel-speed-select/hfi-events.c > index e85676711372..761375062505 100644 > --- a/tools/power/x86/intel-speed-select/hfi-events.c > +++ b/tools/power/x86/intel-speed-select/hfi-events.c > @@ -190,7 +190,7 @@ static int handle_event(struct nl_msg *n, void *arg) > struct genlmsghdr *genlhdr = genlmsg_hdr(nlh); > struct nlattr *attrs[THERMAL_GENL_ATTR_MAX + 1]; > int ret; > - struct perf_cap perf_cap; > + struct perf_cap perf_cap = {0}; > > ret = genlmsg_parse(nlh, 0, attrs, THERMAL_GENL_ATTR_MAX, NULL); >
diff --git a/tools/power/x86/intel-speed-select/hfi-events.c b/tools/power/x86/intel-speed-select/hfi-events.c index e85676711372..761375062505 100644 --- a/tools/power/x86/intel-speed-select/hfi-events.c +++ b/tools/power/x86/intel-speed-select/hfi-events.c @@ -190,7 +190,7 @@ static int handle_event(struct nl_msg *n, void *arg) struct genlmsghdr *genlhdr = genlmsg_hdr(nlh); struct nlattr *attrs[THERMAL_GENL_ATTR_MAX + 1]; int ret; - struct perf_cap perf_cap; + struct perf_cap perf_cap = {0}; ret = genlmsg_parse(nlh, 0, attrs, THERMAL_GENL_ATTR_MAX, NULL);
Initialize perf_cap struct to avoid warning: CC hfi-events.o In function ‘process_hfi_event’, inlined from ‘handle_event’ at hfi-events.c:220:5: hfi-events.c:184:9: warning: ‘perf_cap.cpu’ may be used uninitialized [-Wmaybe-uninitialized] 184 | process_level_change(perf_cap->cpu); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hfi-events.c: In function ‘handle_event’: hfi-events.c:193:25: note: ‘perf_cap.cpu’ was declared here 193 | struct perf_cap perf_cap; | ^~~~~~~~ Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> --- tools/power/x86/intel-speed-select/hfi-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)