| Message ID | 20220607213654.5567-1-krnhotwings@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86/intel: hid: Add Surface Go to VGBS allow list | expand |
On Wed, Jun 8, 2022 at 7:48 AM Duke Lee <krnhotwings@gmail.com> wrote: > > The Surface Go reports Chassis Type 9 (Laptop,) so the device needs to be > added to dmi_vgbs_allow_list to enable tablet mode when an attached Type > Cover is folded back. > Relevant bug report and discussion: > https://github.com/linux-surface/linux-surface/issues/837 It can be a BugLink tag instead. > BugLink: https://github.com/linux-surface/linux-surface/issues/837 > Signed-off-by: Duke Lee <krnhotwings@gmail.com> I believe Hans can tweak this on the fly, so Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > --- > drivers/platform/x86/intel/hid.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c > index 216d31e3403d..79cff1fc675c 100644 > --- a/drivers/platform/x86/intel/hid.c > +++ b/drivers/platform/x86/intel/hid.c > @@ -122,6 +122,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x360 Convertible 15-df0xxx"), > }, > }, > + { > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go"), > + }, > + }, > { } > }; > > -- > 2.36.1 >
Hi, On 6/8/22 12:49, Andy Shevchenko wrote: > On Wed, Jun 8, 2022 at 7:48 AM Duke Lee <krnhotwings@gmail.com> wrote: >> >> The Surface Go reports Chassis Type 9 (Laptop,) so the device needs to be >> added to dmi_vgbs_allow_list to enable tablet mode when an attached Type >> Cover is folded back. > >> Relevant bug report and discussion: >> https://github.com/linux-surface/linux-surface/issues/837 > > It can be a BugLink tag instead. > >> > > BugLink: https://github.com/linux-surface/linux-surface/issues/837 >> Signed-off-by: Duke Lee <krnhotwings@gmail.com> > > I believe Hans can tweak this on the fly, so > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Right, I've just merged this into my review-hans branch, with the BugLink tag added. I'll also include this in my first fixes pull-req for the 5.19 cycle. Regards, Hans > >> --- >> drivers/platform/x86/intel/hid.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c >> index 216d31e3403d..79cff1fc675c 100644 >> --- a/drivers/platform/x86/intel/hid.c >> +++ b/drivers/platform/x86/intel/hid.c >> @@ -122,6 +122,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = { >> DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x360 Convertible 15-df0xxx"), >> }, >> }, >> + { >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), >> + DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go"), >> + }, >> + }, >> { } >> }; >> >> -- >> 2.36.1 >> > >
diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c index 216d31e3403d..79cff1fc675c 100644 --- a/drivers/platform/x86/intel/hid.c +++ b/drivers/platform/x86/intel/hid.c @@ -122,6 +122,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = { DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x360 Convertible 15-df0xxx"), }, }, + { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), + DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go"), + }, + }, { } };
The Surface Go reports Chassis Type 9 (Laptop,) so the device needs to be added to dmi_vgbs_allow_list to enable tablet mode when an attached Type Cover is folded back. Relevant bug report and discussion: https://github.com/linux-surface/linux-surface/issues/837 Signed-off-by: Duke Lee <krnhotwings@gmail.com> --- drivers/platform/x86/intel/hid.c | 6 ++++++ 1 file changed, 6 insertions(+)