| Message ID | 20220616224951.66660-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v1,1/2] platform/x86: thinkpad_acpi: Sort headers for better maintenance | expand |
Hi, On 6/17/22 00:49, Andy Shevchenko wrote: > It's quite hard to understand in that zillions of headers that are included > if any specific one is already listed. Sort headers for better maintenance. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/platform/x86/thinkpad_acpi.c | 58 +++++++++++++++------------- > 1 file changed, 31 insertions(+), 27 deletions(-) Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index e6cb4a14cdd4..eab50d47f567 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -34,46 +34,50 @@ > * thanks to Chris Wright <chrisw@osdl.org> > */ > > -#include <linux/kernel.h> > -#include <linux/module.h> > -#include <linux/init.h> > -#include <linux/types.h> > -#include <linux/string.h> > -#include <linux/list.h> > -#include <linux/mutex.h> > -#include <linux/sched.h> > -#include <linux/sched/signal.h> > -#include <linux/kthread.h> > -#include <linux/freezer.h> > -#include <linux/delay.h> > -#include <linux/slab.h> > -#include <linux/nvram.h> > -#include <linux/proc_fs.h> > -#include <linux/seq_file.h> > -#include <linux/sysfs.h> > +#include <linux/acpi.h> > #include <linux/backlight.h> > #include <linux/bitops.h> > +#include <linux/delay.h> > +#include <linux/dmi.h> > #include <linux/fb.h> > -#include <linux/platform_device.h> > +#include <linux/freezer.h> > #include <linux/hwmon.h> > #include <linux/hwmon-sysfs.h> > +#include <linux/init.h> > #include <linux/input.h> > -#include <linux/leds.h> > -#include <linux/rfkill.h> > -#include <linux/dmi.h> > #include <linux/jiffies.h> > -#include <linux/workqueue.h> > -#include <linux/acpi.h> > +#include <linux/kernel.h> > +#include <linux/kthread.h> > +#include <linux/leds.h> > +#include <linux/list.h> > +#include <linux/module.h> > +#include <linux/mutex.h> > +#include <linux/nvram.h> > #include <linux/pci.h> > -#include <linux/power_supply.h> > +#include <linux/platform_device.h> > #include <linux/platform_profile.h> > -#include <sound/core.h> > -#include <sound/control.h> > -#include <sound/initval.h> > +#include <linux/power_supply.h> > +#include <linux/proc_fs.h> > +#include <linux/rfkill.h> > +#include <linux/sched.h> > +#include <linux/sched/signal.h> > +#include <linux/seq_file.h> > +#include <linux/slab.h> > +#include <linux/string.h> > +#include <linux/sysfs.h> > +#include <linux/types.h> > #include <linux/uaccess.h> > +#include <linux/workqueue.h> > + > #include <acpi/battery.h> > #include <acpi/video.h> > + > #include <drm/drm_privacy_screen_driver.h> > + > +#include <sound/control.h> > +#include <sound/core.h> > +#include <sound/initval.h> > + > #include "dual_accel_detect.h" > > /* ThinkPad CMOS commands */
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index e6cb4a14cdd4..eab50d47f567 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -34,46 +34,50 @@ * thanks to Chris Wright <chrisw@osdl.org> */ -#include <linux/kernel.h> -#include <linux/module.h> -#include <linux/init.h> -#include <linux/types.h> -#include <linux/string.h> -#include <linux/list.h> -#include <linux/mutex.h> -#include <linux/sched.h> -#include <linux/sched/signal.h> -#include <linux/kthread.h> -#include <linux/freezer.h> -#include <linux/delay.h> -#include <linux/slab.h> -#include <linux/nvram.h> -#include <linux/proc_fs.h> -#include <linux/seq_file.h> -#include <linux/sysfs.h> +#include <linux/acpi.h> #include <linux/backlight.h> #include <linux/bitops.h> +#include <linux/delay.h> +#include <linux/dmi.h> #include <linux/fb.h> -#include <linux/platform_device.h> +#include <linux/freezer.h> #include <linux/hwmon.h> #include <linux/hwmon-sysfs.h> +#include <linux/init.h> #include <linux/input.h> -#include <linux/leds.h> -#include <linux/rfkill.h> -#include <linux/dmi.h> #include <linux/jiffies.h> -#include <linux/workqueue.h> -#include <linux/acpi.h> +#include <linux/kernel.h> +#include <linux/kthread.h> +#include <linux/leds.h> +#include <linux/list.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/nvram.h> #include <linux/pci.h> -#include <linux/power_supply.h> +#include <linux/platform_device.h> #include <linux/platform_profile.h> -#include <sound/core.h> -#include <sound/control.h> -#include <sound/initval.h> +#include <linux/power_supply.h> +#include <linux/proc_fs.h> +#include <linux/rfkill.h> +#include <linux/sched.h> +#include <linux/sched/signal.h> +#include <linux/seq_file.h> +#include <linux/slab.h> +#include <linux/string.h> +#include <linux/sysfs.h> +#include <linux/types.h> #include <linux/uaccess.h> +#include <linux/workqueue.h> + #include <acpi/battery.h> #include <acpi/video.h> + #include <drm/drm_privacy_screen_driver.h> + +#include <sound/control.h> +#include <sound/core.h> +#include <sound/initval.h> + #include "dual_accel_detect.h" /* ThinkPad CMOS commands */
It's quite hard to understand in that zillions of headers that are included if any specific one is already listed. Sort headers for better maintenance. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/platform/x86/thinkpad_acpi.c | 58 +++++++++++++++------------- 1 file changed, 31 insertions(+), 27 deletions(-)