| Message ID | 20220710173658.221528-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: intel_atomisp2_led: Also turn off the always-on camera LED on the Asus T100TAF | expand |
Hi, On 7/10/22 19:36, Hans de Goede wrote: > Like the Asus T100TA the Asus T100TAF has a camera LED which is always > on by default and both also use the same GPIO for the LED. > > Relax the DMI match for the Asus T100TA so that it also matches > the T100TAF. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> I've added this to my review-hans (soon to be for-next) branch now. Regards, Hans > --- > drivers/platform/x86/intel/atomisp2/led.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/atomisp2/led.c b/drivers/platform/x86/intel/atomisp2/led.c > index 5935dfca166f..10077a61d8c5 100644 > --- a/drivers/platform/x86/intel/atomisp2/led.c > +++ b/drivers/platform/x86/intel/atomisp2/led.c > @@ -50,7 +50,8 @@ static const struct dmi_system_id atomisp2_led_systems[] __initconst = { > { > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > - DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TA"), > + /* Non exact match to also match T100TAF */ > + DMI_MATCH(DMI_PRODUCT_NAME, "T100TA"), > }, > .driver_data = &asus_t100ta_lookup, > },
On Sun, Jul 10, 2022 at 07:36:58PM +0200, Hans de Goede wrote: > Like the Asus T100TA the Asus T100TAF has a camera LED which is always > on by default and both also use the same GPIO for the LED. > > Relax the DMI match for the Asus T100TA so that it also matches > the T100TAF. Shouldn't atomisp driver take care about this (presumable in the future)?
Hi, On 7/10/22 20:44, Andy Shevchenko wrote: > On Sun, Jul 10, 2022 at 07:36:58PM +0200, Hans de Goede wrote: >> Like the Asus T100TA the Asus T100TAF has a camera LED which is always >> on by default and both also use the same GPIO for the LED. >> >> Relax the DMI match for the Asus T100TA so that it also matches >> the T100TAF. > > Shouldn't atomisp driver take care about this (presumable in the future)? Eventually yes, for now we have a small driver to at least turn of the LED on devices where it is on at boot (or to be more precise gets turned on when running the ACPI INIT method of the asus-wmi WMI device). Regards, Hans
diff --git a/drivers/platform/x86/intel/atomisp2/led.c b/drivers/platform/x86/intel/atomisp2/led.c index 5935dfca166f..10077a61d8c5 100644 --- a/drivers/platform/x86/intel/atomisp2/led.c +++ b/drivers/platform/x86/intel/atomisp2/led.c @@ -50,7 +50,8 @@ static const struct dmi_system_id atomisp2_led_systems[] __initconst = { { .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), - DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TA"), + /* Non exact match to also match T100TAF */ + DMI_MATCH(DMI_PRODUCT_NAME, "T100TA"), }, .driver_data = &asus_t100ta_lookup, },
Like the Asus T100TA the Asus T100TAF has a camera LED which is always on by default and both also use the same GPIO for the LED. Relax the DMI match for the Asus T100TA so that it also matches the T100TAF. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/platform/x86/intel/atomisp2/led.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)