| Message ID | 20220805081909.10962-5-luke@ljones.dev (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | asus-wmi: Add support for RGB keyboards | expand |
Hi "Luke, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.19] [cannot apply to linus/master next-20220805] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Luke-D-Jones/asus-wmi-Add-support-for-RGB-keyboards/20220805-162136 base: 3d7cb6b04c3f3115719235cc6866b10326de34cd reproduce: make htmldocs If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> Documentation/ABI/testing/sysfs-platform-asus-wmi:71: WARNING: Unexpected indentation. vim +71 Documentation/ABI/testing/sysfs-platform-asus-wmi > 71 Date: Dec 2022 72 KernelVersion: 5.17 73 Contact: "Luke Jones" <luke@ljones.dev> 74 Description: 75 Enable the external GPU paired with ROG X-Flow laptops. 76 Toggling this setting will also trigger ACPI to disable the dGPU: 77 * 0 - Disable, 78 * 1 - Enable, 79
On Fri, Aug 5, 2022 at 10:21 AM Luke D. Jones <luke@ljones.dev> wrote: > Missed commit message. > Signed-off-by: Luke D. Jones <luke@ljones.dev> ... > +Date: Dec 2022 I would be more optimistic here... > +KernelVersion: 5.17 ...and definitely this is the wrong version. I would suggest 6.0. Both comments are applicable for other similar cases. In case you are documenting new and old APIs, split this to two patches with different dates and kernel versions. And commit messages should be different.
diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi index 04885738cf15..afcaba6c4bfd 100644 --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi @@ -57,3 +57,53 @@ Description: * 0 - default, * 1 - overboost, * 2 - silent + +What: /sys/devices/platform/<platform>/dgpu_disable +Date: Dec 2022 +KernelVersion: 5.17 +Contact: "Luke Jones" <luke@ljones.dev> +Description: + Disable discrete GPU: + * 0 - Enable dGPU, + * 1 - Disable dGPU, + +What: /sys/devices/platform/<platform>/egpu_enable +Date: Dec 2022 +KernelVersion: 5.17 +Contact: "Luke Jones" <luke@ljones.dev> +Description: + Enable the external GPU paired with ROG X-Flow laptops. + Toggling this setting will also trigger ACPI to disable the dGPU: + * 0 - Disable, + * 1 - Enable, + +What: /sys/devices/platform/<platform>/keyboard_rgb_mode +Date: Dec 2022 +KernelVersion: 5.20 +Contact: "Luke Jones" <luke@ljones.dev> +Description: + Set some RGB keyboard modes and features (write-only). + + The accepted input is "save mode speed", where "n n n" options + are: + * save - 0 or 1, if 0 then settings are not retained on boot + * mode - 0 to 12, each is an RGB such as static, rainbow, pulse. + Not all keyboards accept every mode. + * speed - 0, 1, 2, equal to low, medium, high. + Only applies to certain modes. + +What: /sys/devices/platform/<platform>/panel_od +Date: Dec 2022 +KernelVersion: 5.20 +Contact: "Luke Jones" <luke@ljones.dev> +Description: + Set some RGB keyboard power states (write-only). + + The accepted input is "boot awake sleep keyboard", where "n n n n n" + options are: + * save - 0 or 1, if 0 then settings are not retained on boot + * boot - 0 or 1, controls if a boot animation is shown + * awake - 0 or 1, controls if the keyboard LED are on during awake + * sleep - 0 or 1, controls if a suspended animation is shown. + This is only active if the AC is connected. + * keyboard - 0 or 1, unknown what effect this really has
Signed-off-by: Luke D. Jones <luke@ljones.dev> --- .../ABI/testing/sysfs-platform-asus-wmi | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+)