| Message ID | 20220812222509.292692-2-luke@ljones.dev (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | asus-wmi: cleanup dgpu_disable, egpu_enable, panel_od | expand |
Hi Luke, On 8/13/22 00:25, Luke D. Jones wrote: > The dgpu_disable attribute was not documented, this adds the > required documentation. > > Signed-off-by: Luke D. Jones <luke@ljones.dev> Thanks for the patch. Note that the Fixes tag should be above your signed-off-by and then the patch should otherwise have a normal subject + body. I've changed the commit msg to the following while merging this: """ platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute The dgpu_disable attribute was not documented, this adds the required documentation. Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method") Signed-off-by: Luke D. Jones <luke@ljones.dev> """ and I will make similar changes to patch 2/6 and 3/6 > --- > Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi > index 04885738cf15..0f932fd60f4a 100644 > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi > @@ -57,3 +57,12 @@ Description: > * 0 - default, > * 1 - overboost, > * 2 - silent > + > +What: /sys/devices/platform/<platform>/dgpu_disable > +Date: Aug 2022 > +KernelVersion: 5.17 > +Contact: "Luke Jones" <luke@ljones.dev> > +Description: > + Disable discrete GPU: > + * 0 - Enable dGPU, > + * 1 - Disable dGPU, > \ No newline at end of file Next time please make sure the file always ends with a newline even in intermediate patches. Regards, Hans
Hi, On 8/15/22 15:25, Hans de Goede wrote: > Hi Luke, > > On 8/13/22 00:25, Luke D. Jones wrote: >> The dgpu_disable attribute was not documented, this adds the >> required documentation. >> >> Signed-off-by: Luke D. Jones <luke@ljones.dev> > > Thanks for the patch. Note that the Fixes tag should be above your > signed-off-by and then the patch should otherwise have a normal > subject + body. I've changed the commit msg to the following > while merging this: > > """ > platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute > > The dgpu_disable attribute was not documented, this adds the > required documentation. > > Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method") > Signed-off-by: Luke D. Jones <luke@ljones.dev> > """ While merging this I noticed that this is also using spaces instead of tabs for indentation, where as the rest of the file is using tabs. I've also fixed this up while merging, but next time please make sure to use spaces. I will make similar spaces -> tabs changes to patch 2/6 and 3/6 Regards, Hans >> --- >> Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi >> index 04885738cf15..0f932fd60f4a 100644 >> --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi >> +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi >> @@ -57,3 +57,12 @@ Description: >> * 0 - default, >> * 1 - overboost, >> * 2 - silent >> + >> +What: /sys/devices/platform/<platform>/dgpu_disable >> +Date: Aug 2022 >> +KernelVersion: 5.17 >> +Contact: "Luke Jones" <luke@ljones.dev> >> +Description: >> + Disable discrete GPU: >> + * 0 - Enable dGPU, >> + * 1 - Disable dGPU, >> \ No newline at end of file > > Next time please make sure the file always ends with a newline > even in intermediate patches. > > Regards, > > Hans > >
> Thanks for the patch. Note that the Fixes tag should be above your > signed-off-by and then the patch should otherwise have a normal > subject + body. I've changed the commit msg to the following > while merging this: > > """ > platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute > > The dgpu_disable attribute was not documented, this adds the > required documentation. > > Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method") > Signed-off-by: Luke D. Jones <luke@ljones.dev> > """ > > and I will make similar changes to patch 2/6 and 3/6 > Ah thank you, sorry about that, I thought I got it correct Perhaps I didn't read https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-changes well enough. > > --- > > Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi > > b/Documentation/ABI/testing/sysfs-platform-asus-wmi > > index 04885738cf15..0f932fd60f4a 100644 > > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi > > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi > > @@ -57,3 +57,12 @@ Description: > > * 0 - default, > > * 1 - overboost, > > * 2 - silent > > + > > +What: /sys/devices/platform/<platform>/dgpu_disable > > +Date: Aug 2022 > > +KernelVersion: 5.17 > > +Contact: "Luke Jones" <luke@ljones.dev> > > +Description: > > + Disable discrete GPU: > > + * 0 - Enable dGPU, > > + * 1 - Disable dGPU, > > \ No newline at end of file > > Next time please make sure the file always ends with a newline > even in intermediate patches. > > Regards, > > Hans > >
On Mon, 2022-08-15 at 15:40 +0200, Hans de Goede wrote: > Hi, > > On 8/15/22 15:25, Hans de Goede wrote: > > Hi Luke, > > > > On 8/13/22 00:25, Luke D. Jones wrote: > > > The dgpu_disable attribute was not documented, this adds the > > > required documentation. > > > > > > Signed-off-by: Luke D. Jones <luke@ljones.dev> > > > > Thanks for the patch. Note that the Fixes tag should be above your > > signed-off-by and then the patch should otherwise have a normal > > subject + body. I've changed the commit msg to the following > > while merging this: > > > > """ > > platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute > > > > The dgpu_disable attribute was not documented, this adds the > > required documentation. > > > > Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method") > > Signed-off-by: Luke D. Jones <luke@ljones.dev> > > """ > > While merging this I noticed that this is also using spaces > instead of tabs for indentation, where as the rest of > the file is using tabs. > > I've also fixed this up while merging, but next time > please make sure to use spaces. > > I will make similar spaces -> tabs changes to patch 2/6 and 3/6 > I ran these through ./scripts/checkpatch.pl... I'm really not sure what happened. I'll triple-check that in future. > Regards, > > Hans > > > > > > > --- > > > Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi > > > b/Documentation/ABI/testing/sysfs-platform-asus-wmi > > > index 04885738cf15..0f932fd60f4a 100644 > > > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi > > > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi > > > @@ -57,3 +57,12 @@ Description: > > > * 0 - default, > > > * 1 - overboost, > > > * 2 - silent > > > + > > > +What: /sys/devices/platform/<platform>/dgpu_disable > > > +Date: Aug 2022 > > > +KernelVersion: 5.17 > > > +Contact: "Luke Jones" <luke@ljones.dev> > > > +Description: > > > + Disable discrete GPU: > > > + * 0 - Enable dGPU, > > > + * 1 - Disable dGPU, > > > \ No newline at end of file > > > > Next time please make sure the file always ends with a newline > > even in intermediate patches. > > > > Regards, > > > > Hans > > > > >
diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi index 04885738cf15..0f932fd60f4a 100644 --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi @@ -57,3 +57,12 @@ Description: * 0 - default, * 1 - overboost, * 2 - silent + +What: /sys/devices/platform/<platform>/dgpu_disable +Date: Aug 2022 +KernelVersion: 5.17 +Contact: "Luke Jones" <luke@ljones.dev> +Description: + Disable discrete GPU: + * 0 - Enable dGPU, + * 1 - Disable dGPU, \ No newline at end of file
The dgpu_disable attribute was not documented, this adds the required documentation. Signed-off-by: Luke D. Jones <luke@ljones.dev> --- Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++ 1 file changed, 9 insertions(+)